mirror/opencv
1
0
Fork 0
mirror of https://github.com/opencv/opencv.git synced 2025-06-07 17:44:04 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix copyTo memory corruption, but the main problem is still here

Browse Source
This commit is contained in:
Alexander Alekhin 2015-07-01 20:08:36 +03:00
parent 30a5a9ed34
commit 885114ed2c
4 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
modules/core/include/opencv2/core/mat.hpp
View File

@ -222,6 +222,7 @@ public:
bool isMatVector() const;
bool isUMatVector() const;
bool isMatx() const;
bool isVector() const;
~_InputArray();

1
modules/core/include/opencv2/core/mat.inl.hpp
View File

@ -130,6 +130,7 @@ inline bool _InputArray::isUMat() const { return kind() == _InputArray::UMAT; }
inline bool _InputArray::isMatVector() const { return kind() == _InputArray::STD_VECTOR_MAT; }
inline bool _InputArray::isUMatVector() const { return kind() == _InputArray::STD_VECTOR_UMAT; }
inline bool _InputArray::isMatx() const { return kind() == _InputArray::MATX; }
inline bool _InputArray::isVector() const { return kind() == _InputArray::STD_VECTOR || kind() == _InputArray::STD_BOOL_VECTOR; }
////////////////////////////////////////////////////////////////////////////////////////

5
modules/core/src/copy.cpp
View File

@ -285,6 +285,11 @@ void Mat::copyTo( OutputArray _dst ) const
if( rows > 0 && cols > 0 )
{
// For some cases (with vector) dst.size != src.size, so force to column-based form
// It prevents memory corruption in case of column-based src
if (_dst.isVector())
dst = dst.reshape(0, (int)dst.total());
const uchar* sptr = data;
uchar* dptr = dst.data;

5
modules/core/test/test_mat.cpp
View File

@ -1320,7 +1320,8 @@ TEST(Core_SparseMat, footprint)
}
TEST(Core_Mat_vector, OutputArray_create_getMat)
// Can't fix without duty hacks or broken user code (PR #4159)
TEST(Core_Mat_vector, DISABLED_OutputArray_create_getMat)
{
cv::Mat_<uchar> src_base(5, 1);
std::vector<uchar> dst8;
@ -1347,6 +1348,7 @@ TEST(Core_Mat_vector, copyTo_roi_column)
Mat src_full(src_base);
Mat src(src_full.col(0));
#if 0 // Can't fix without duty hacks or broken user code (PR #4159)
OutputArray _dst(dst1);
{
_dst.create(src.rows, src.cols, src.type());
@ -1355,6 +1357,7 @@ TEST(Core_Mat_vector, copyTo_roi_column)
EXPECT_EQ(src.cols, dst.cols);
EXPECT_EQ(src.rows, dst.rows);
}
#endif
std::vector<uchar> dst2;
src.copyTo(dst2);