mirror/opencv
1
0
Fork 0
mirror of https://github.com/opencv/opencv.git synced 2025-06-13 04:52:53 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

rgb2hls_b: out of bounds read fixed

Browse Source
This commit is contained in:
Rostislav Vasilikhin 2019-05-27 16:19:52 +03:00
parent 791ebd05fc
commit 8c698262ea
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
modules/imgproc/src/color_hsv.simd.hpp
View File

@ -724,7 +724,7 @@ struct RGB2HLS_b
{ {
CV_INSTRUMENT_REGION(); CV_INSTRUMENT_REGION();
int i, j, scn = srccn; int scn = srccn;
#if CV_SIMD #if CV_SIMD
float CV_DECL_ALIGNED(CV_SIMD_WIDTH) buf[bufChannels*BLOCK_SIZE]; float CV_DECL_ALIGNED(CV_SIMD_WIDTH) buf[bufChannels*BLOCK_SIZE];
@ -744,15 +744,15 @@ struct RGB2HLS_b
} }
#endif #endif
for( i = 0; i < n; i += BLOCK_SIZE, dst += BLOCK_SIZE*3 ) for(int i = 0; i < n; i += BLOCK_SIZE, dst += BLOCK_SIZE*3 )
{ {
int dn = std::min(n - i, (int)BLOCK_SIZE); int dn = std::min(n - i, (int)BLOCK_SIZE);
j = 0;
#if CV_SIMD #if CV_SIMD
v_float32 v255inv = vx_setall_f32(1.f/255.f); v_float32 v255inv = vx_setall_f32(1.f/255.f);
if (scn == 3) if (scn == 3)
{ {
int j = 0;
static const int nBlock = fsize*2; static const int nBlock = fsize*2;
for ( ; j <= (dn * bufChannels - nBlock); for ( ; j <= (dn * bufChannels - nBlock);
j += nBlock, src += nBlock) j += nBlock, src += nBlock)
@ -763,9 +763,14 @@ struct RGB2HLS_b
v_store_aligned(buf + j + 0*fsize, v_cvt_f32(qrgb0)*v255inv); v_store_aligned(buf + j + 0*fsize, v_cvt_f32(qrgb0)*v255inv);
v_store_aligned(buf + j + 1*fsize, v_cvt_f32(qrgb1)*v255inv); v_store_aligned(buf + j + 1*fsize, v_cvt_f32(qrgb1)*v255inv);
} }
for( ; j < dn*3; j++, src++ )
{
buf[j] = src[0]*(1.f/255.f);
}
} }
else // if (scn == 4) else // if (scn == 4)
{ {
int j = 0;
static const int nBlock = fsize*4; static const int nBlock = fsize*4;
for ( ; j <= dn*bufChannels - nBlock*bufChannels; for ( ; j <= dn*bufChannels - nBlock*bufChannels;
j += nBlock*bufChannels, src += nBlock*4) j += nBlock*bufChannels, src += nBlock*4)
@ -795,17 +800,24 @@ struct RGB2HLS_b
v_store_interleave(buf + j + k*bufChannels*fsize, f[0*4+k], f[1*4+k], f[2*4+k]); v_store_interleave(buf + j + k*bufChannels*fsize, f[0*4+k], f[1*4+k], f[2*4+k]);
} }
} }
for( ; j < dn*3; j += 3, src += 4 )
{
buf[j+0] = src[0]*(1.f/255.f);
buf[j+1] = src[1]*(1.f/255.f);
buf[j+2] = src[2]*(1.f/255.f);
}
} }
#endif #else
for( ; j < dn*3; j += 3, src += scn ) for(int j = 0; j < dn*3; j += 3, src += scn )
{ {
buf[j+0] = src[0]*(1.f/255.f); buf[j+0] = src[0]*(1.f/255.f);
buf[j+1] = src[1]*(1.f/255.f); buf[j+1] = src[1]*(1.f/255.f);
buf[j+2] = src[2]*(1.f/255.f); buf[j+2] = src[2]*(1.f/255.f);
} }
#endif
cvt(buf, buf, dn); cvt(buf, buf, dn);
j = 0; int j = 0;
#if CV_SIMD #if CV_SIMD
for( ; j <= dn*3 - fsize*3*4; j += fsize*3*4) for( ; j <= dn*3 - fsize*3*4; j += fsize*3*4)
{ {