python: discover tests from module/misc/python/test paths

cmake/OpenCVUtils.cmake

@@ -1777,3 +1777,22 @@ macro(ocv_git_describe var_name path)
     set(${var_name} "unknown")
   endif()
 endmacro()
+
+
+# ocv_update_file(filepath content [VERBOSE])
+# - write content to file
+# - will not change modification time in case when file already exists and content has not changed
+function(ocv_update_file filepath content)
+  if(EXISTS "${filepath}")
+    file(READ "${filepath}" actual_content)
+  else()
+    set(actual_content "")
+  endif()
+  if("${actual_content}" STREQUAL "${content}")
+    if(";${ARGN};" MATCHES ";VERBOSE;")
+      message(STATUS "${filepath} contains the same content")
+    endif()
+  else()
+    file(WRITE "${filepath}" "${content}")
+  endif()
+endfunction()

doc/CMakeLists.txt

@@ -15,7 +15,7 @@ if(DOXYGEN_FOUND)
 
   # not documented modules list
   set(blacklist "${DOXYGEN_BLACKLIST}")
-  list(APPEND blacklist "ts" "java_bindings_generator" "java" "python_bindings_generator" "python2" "python3" "js" "world")
+  list(APPEND blacklist "ts" "world")
   unset(CMAKE_DOXYGEN_TUTORIAL_CONTRIB_ROOT)
   unset(CMAKE_DOXYGEN_TUTORIAL_JS_ROOT)
 
@@ -32,7 +32,16 @@ if(DOXYGEN_FOUND)
   set(refs_extra)
   set(deps)
   foreach(m ${OPENCV_MODULES_MAIN} ${OPENCV_MODULES_EXTRA})
+    set(the_module "${m}")
+    if(NOT the_module MATCHES "^opencv_")
+      set(the_module "opencv_${m}")
+    endif()
     list(FIND blacklist ${m} _pos)
+    if(NOT EXISTS "${OPENCV_MODULE_${the_module}_LOCATION}/include"
+        AND NOT EXISTS "${OPENCV_MODULE_${the_module}_LOCATION}/doc"
+    )
+      set(_pos -2)  # blacklist
+    endif()
     if(${_pos} EQUAL -1)
       list(APPEND CMAKE_DOXYGEN_ENABLED_SECTIONS "HAVE_opencv_${m}")
       # include folder

modules/python/CMakeLists.txt

@@ -18,6 +18,8 @@ endif()
 
 add_subdirectory(bindings)
 
+add_subdirectory(test)
+
 if(NOT OPENCV_SKIP_PYTHON_LOADER)
   include("./python_loader.cmake")
   message(STATUS "OpenCV Python: during development append to PYTHONPATH: ${CMAKE_BINARY_DIR}/python_loader")

modules/python/test/CMakeLists.txt

@@ -0,0 +1,32 @@
+set(MODULE_NAME "python_tests")
+set(OPENCV_MODULE_IS_PART_OF_WORLD FALSE)
+ocv_add_module(${MODULE_NAME} INTERNAL)
+
+set(OPENCV_PYTHON_TESTS_CONFIG_FILE_DIR "${OpenCV_BINARY_DIR}" CACHE INTERNAL "")
+set(OPENCV_PYTHON_TESTS_CONFIG_FILE "${OPENCV_PYTHON_TESTS_CONFIG_FILE_DIR}/opencv_python_tests.cfg" CACHE INTERNAL "")
+
+# get list of modules to wrap
+set(OPENCV_PYTHON_MODULES)
+foreach(m ${OPENCV_MODULES_BUILD})
+  if(";${OPENCV_MODULE_${m}_WRAPPERS};" MATCHES ";python.*;" AND HAVE_${m})
+    list(APPEND OPENCV_PYTHON_MODULES ${m})
+    #message(STATUS "\t${m}")
+  endif()
+endforeach()
+
+file(RELATIVE_PATH __loc_relative "${OPENCV_PYTHON_TESTS_CONFIG_FILE_DIR}" "${CMAKE_CURRENT_LIST_DIR}")
+set(opencv_tests_locations "${__loc_relative}")
+foreach(m ${OPENCV_PYTHON_MODULES})
+  set(__loc "${OPENCV_MODULE_${m}_LOCATION}/misc/python/test")
+  if(EXISTS "${__loc}")
+    file(RELATIVE_PATH __loc_relative "${OPENCV_PYTHON_TESTS_CONFIG_FILE_DIR}" "${__loc}")
+    list(APPEND opencv_tests_locations "${__loc_relative}")
+  endif()
+endforeach(m)
+
+string(REPLACE ";" "\n" opencv_tests_locations_ "${opencv_tests_locations}")
+ocv_update_file("${OPENCV_PYTHON_TESTS_CONFIG_FILE}" "${opencv_tests_locations_}")
+
+#
+# TODO: Install rules (with test data?)
+#

modules/python/test/test.py

@@ -1,4 +1,9 @@
 #!/usr/bin/env python
+'''
+Location of tests:
+- <opencv_src>/modules/python/test
+- <opencv_src>/modules/<module>/misc/python/test/
+'''
 
 from __future__ import print_function
 
@@ -20,7 +25,35 @@ from tests_common import NewOpenCVTests
 basedir = os.path.abspath(os.path.dirname(__file__))
 
 def load_tests(loader, tests, pattern):
-    tests.addTests(loader.discover(basedir, pattern=os.environ.get('OPENCV_PYTEST_FILTER', 'test_') + '*.py'))
+    cwd = os.getcwd()
+    config_file = 'opencv_python_tests.cfg'
+    locations = [cwd, basedir]
+    if os.path.exists(config_file):
+        with open(config_file, 'r') as f:
+            locations += [str(s).strip() for s in f.readlines()]
+    else:
+        print('WARNING: OpenCV tests config file ({}) is missing, running subset of tests'.format(config_file))
+
+    tests_pattern = os.environ.get('OPENCV_PYTEST_FILTER', 'test_') + '*.py'
+    if tests_pattern != 'test_*py':
+        print('Tests filter: {}'.format(tests_pattern))
+
+    processed = set()
+    for l in locations:
+        if not os.path.isabs(l):
+            l = os.path.normpath(os.path.join(cwd, l))
+        if l in processed:
+            continue
+        processed.add(l)
+        print('Discovering python tests from: {}'.format(l))
+        sys_path_modify = l not in sys.path
+        if sys_path_modify:
+            sys.path.append(l)  # Hack python loader
+        discovered_tests = loader.discover(l, pattern=tests_pattern, top_level_dir=l)
+        print('    found {} tests'.format(discovered_tests.countTestCases()))
+        tests.addTests(loader.discover(l, pattern=tests_pattern))
+        if sys_path_modify:
+            sys.path.remove(l)
     return tests
 
 if __name__ == '__main__':