TBB executor for GAPI: fix race consition in Async test

The test has race condition, which is addressed by the patch.

The race is next:

    Master thread is calling execute (effectively blocked, waiting for
callback to be called)
    "Async" thread picks up the callback
    Call the callback
    Then sets the variables in test
    After call back is called, master thread is unblocked and may check
the variables (set in point 4 by the "async" thread) earlier then they
actually changed

Changes:

    callback should be called as the last step (after flag variables are
    set), as it effectively unblock the master thread

fixes #18974
This commit is contained in:
Anton Potapov 2020-12-01 11:12:36 +03:00
parent e726ff3296
commit eb6d8e6af2

View File

@ -95,9 +95,9 @@ TEST(TBBExecutor, AsyncBasic) {
if (!slept) {
std::this_thread::sleep_for(std::chrono::milliseconds(1));
}
callback();
callback_called = true;
master_was_blocked_until_callback_called = (master_is_waiting == true);
callback();
});
auto async_task_body = [&](std::function<void()>&& cb, size_t /*total_order_index*/) {