mirror of
https://github.com/opencv/opencv.git
synced 2025-07-30 17:37:05 +08:00
8a0ea789e7
Fix #25696: Solved the problem in Subdiv2D, empty delaunay triangulation #27149 Detailed description Expected behaviour: Given 4 points, where no three points are collinear, the Delaunay Triangulation Algorithm should return 2 triangles. Actual: The algorithm returns zero triangles in this particular case. Fix: The radius of the circumcircle tends to infinity when the points are closer to form collinear points, so the problem occurs because the super-triangles are not large enough, which then results in certain edges are not swapped. The proposed solution just increases the super triangle, duplicating the value of constant for example. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
68 lines
2.9 KiB
C++
68 lines
2.9 KiB
C++
/*M///////////////////////////////////////////////////////////////////////////////////////
|
|
// This file is part of OpenCV project.
|
|
// It is subject to the license terms in the LICENSE file found in the top-level directory
|
|
// of this distribution and at http://opencv.org/license.html.
|
|
//M*/
|
|
#include "test_precomp.hpp"
|
|
|
|
namespace opencv_test { namespace {
|
|
TEST(Imgproc_Subdiv2D_getTriangleList, regression_5788)
|
|
{
|
|
const float points[65][2] = {
|
|
{ 390, 802}, { 397, 883}, { 414, 963 }, { 439, 1042 }, { 472, 1113},
|
|
{ 521, 1181}, { 591, 1238}, { 678, 1284 }, { 771, 1292 }, { 853, 1281},
|
|
{ 921, 1243}, { 982, 1191}, {1030, 1121 }, {1059, 1038 }, {1072, 945},
|
|
{1081, 849}, {1082, 749}, { 459, 734 }, { 502, 704 }, { 554, 696},
|
|
{ 609, 698}, { 660, 707}, { 818, 688 }, { 874, 661 }, { 929, 646},
|
|
{ 982, 653}, {1026, 682}, { 740, 771 }, { 748, 834 }, { 756, 897},
|
|
{ 762, 960}, { 700, 998}, { 733, 1006 }, { 766, 1011 }, { 797, 999},
|
|
{ 825, 987}, { 528, 796}, { 566, 766 }, { 617, 763 }, { 659, 794},
|
|
{ 619, 808}, { 569, 812}, { 834, 777 }, { 870, 735 }, { 918, 729},
|
|
{ 958, 750}, { 929, 773}, { 882, 780 }, { 652, 1102 }, { 701, 1079},
|
|
{ 743, 1063}, { 774, 1068}, { 807, 1057 }, { 852, 1065 }, { 896, 1077},
|
|
{ 860, 1117}, { 820, 1135}, { 783, 1141 }, { 751, 1140 }, { 706, 1130},
|
|
{ 675, 1102}, { 743, 1094}, { 774, 1094 }, { 809, 1088 }, { 878, 1082}
|
|
};
|
|
std::vector<cv::Point2f> pts;
|
|
cv::Rect rect(0, 0, 1500, 2000);
|
|
cv::Subdiv2D subdiv(rect);
|
|
for( int i = 0; i < 65; i++ )
|
|
{
|
|
cv::Point2f pt(points[i][0], points[i][1]);
|
|
pts.push_back(pt);
|
|
}
|
|
|
|
subdiv.insert(pts);
|
|
|
|
std::vector<cv::Vec6f> triangles;
|
|
subdiv.getTriangleList(triangles);
|
|
|
|
int trig_cnt = 0;
|
|
for( std::vector<cv::Vec6f>::const_iterator it = triangles.begin(); it != triangles.end(); it++, trig_cnt++ )
|
|
{
|
|
EXPECT_TRUE( (0 <= triangles.at(trig_cnt).val[0] && triangles.at(trig_cnt).val[0] < 1500) &&
|
|
(0 <= triangles.at(trig_cnt).val[1] && triangles.at(trig_cnt).val[1] < 2000) &&
|
|
(0 <= triangles.at(trig_cnt).val[2] && triangles.at(trig_cnt).val[2] < 1500) &&
|
|
(0 <= triangles.at(trig_cnt).val[3] && triangles.at(trig_cnt).val[3] < 2000) &&
|
|
(0 <= triangles.at(trig_cnt).val[4] && triangles.at(trig_cnt).val[4] < 1500) &&
|
|
(0 <= triangles.at(trig_cnt).val[5] && triangles.at(trig_cnt).val[5] < 2000) );
|
|
}
|
|
EXPECT_EQ(trig_cnt, 105);
|
|
}
|
|
|
|
TEST(Imgproc_Subdiv2D, issue_25696) {
|
|
std::vector<cv::Point2f> points{
|
|
{0, 0}, {40, 40}, {84, 104}, {86, 108}
|
|
};
|
|
|
|
cv::Rect subdivRect{cv::Point{-10, -10}, cv::Point{96, 118}};
|
|
cv::Subdiv2D subdiv{subdivRect};
|
|
subdiv.insert(points);
|
|
|
|
std::vector<cv::Vec6f> triangles;
|
|
subdiv.getTriangleList(triangles);
|
|
|
|
ASSERT_EQ(static_cast<size_t>(2), triangles.size());
|
|
}
|
|
}}
|