mirror of
https://github.com/opencv/opencv.git
synced 2024-11-30 06:10:02 +08:00
8af96248bf
OE-11 Logging revamp (#13909) * Initial commit for log tag support. Part of #11003, incomplete. Should pass build. Moved LogLevel enum to logger.defines.hpp LogTag struct used to convey both name and log level threshold as one argument to the new logging macro. See logtag.hpp file, and CV_LOG_WITH_TAG macro. Global log level is now associated with a global log tag, when a logging statement doesn't specify any log tag. See getLogLevel and getGlobalLogTag functions. A macro CV_LOGTAG_FALLBACK is allowed to be re-defined by other modules or compilation units, internally, so that logging statements inside that unit that specify NULL as tag will fall back to the re-defined tag. Line-of-code information (file name, line number, function name), together with tag name, are passed into the new log message sink. See writeLogMessageEx function. Fixed old incorrect CV_LOG_VERBOSE usage in ocl4dnn_conv_spatial.cpp. * Implemented tag-based log filtering Added LogTagManager. This is an initial version, using standard C++ approach as much as possible, to allow easier code review. Will optimize later. A workaround for all static dynamic initialization issues is implemented. Refer to code comments. * Added LogTagConfigParser. Note: new code does not fully handle old log config parsing behavior. * Fix log tag config vs registering ordering issue. * Started testing LogTagConfigParser, incomplete. The intention of this commit is to illustrate the capabilities of the current design of LogTagConfigParser. The test contained in this commit is not complete. Also, design changes may require throwing away this commit and rewriting test code from scratch. Does not test whitespace segmentation (multiple tags on the config); will do in next commit. * Added CV_LOGTAG_EXPAND_NAME macro This macro allows to be re-defined locally in other compilation units to apply a prefix to whatever argument is passed as the "tag" argument into CV_LOG_WITH_TAG. The default definition in logger.hpp does not modify the argument. It is recommended to include the address-of operator (ampersand) when re-defined locally. * Added a few tests for LogTagManager, some fail. See test_logtagmanager.cpp Failed tests are: non-global ("something"), setting level by name-part (first part or any part) has no effect at all. * LogTagManagerTests substring non-confusion tests * Fix major bugs in LogTagManager The code change is intended to approximate the spec documented in https://gist.github.com/kinchungwong/ec25bc1eba99142e0be4509b0f67d0c6 Refer to test suite in test_logtagmanager.cpp Filter test result in "opencv_test_core" ... with gtest_filter "LogTagManager*" To see the test code that finds the bugs, refer to original commits (before rebase; might be gone) .. f3451208 (2019-03-03T19:45:17Z) .... LogTagManagerTests substring non-confusion tests .. 1b848f5f (2019-03-03T01:55:18Z) .... Added a few tests for LogTagManager, some fail. * Added LogTagManagerNamePartNonConfusionTest. See test_logtagmanager.cpp in modules/core/test. * Added LogTagAuto for auto registration in ctor * Rewritten LogTagManager to resolve issues. * Resolves code review issues around 2019-04-10 LogTagConfigParser::parseLogLevel - as part of resolving code review issues, this function is rewritten to simplify control flow and to improve conformance with legacy usage (for string values "OFF", "DISABLED", and "WARNINGS"). |
||
|---|---|---|
| .. | ||
| ocl | ||
| test_arithm.cpp | ||
| test_concatenation.cpp | ||
| test_conjugate_gradient.cpp | ||
| test_countnonzero.cpp | ||
| test_downhill_simplex.cpp | ||
| test_ds.cpp | ||
| test_dxt.cpp | ||
| test_eigen.cpp | ||
| test_hal_core.cpp | ||
| test_intrin128.simd.hpp | ||
| test_intrin256.simd.hpp | ||
| test_intrin_utils.hpp | ||
| test_intrin.cpp | ||
| test_io.cpp | ||
| test_logtagconfigparser.cpp | ||
| test_logtagmanager.cpp | ||
| test_lpsolver.cpp | ||
| test_main.cpp | ||
| test_mat.cpp | ||
| test_math.cpp | ||
| test_misc.cpp | ||
| test_operations.cpp | ||
| test_precomp.hpp | ||
| test_ptr.cpp | ||
| test_rand.cpp | ||
| test_rotatedrect.cpp | ||
| test_umat.cpp | ||
| test_utils.cpp | ||