Open Source Computer Vision Library
Go to file
Abduragim Shtanchaev d0820dac38
Merge pull request #26391 from Abdurrahheem:ash/lstm-new-graph-engine-latest
LSTM layer for new graph engine. #26391

Merge with extra: https://github.com/opencv/opencv_extra/pull/1218

This PR updates/creates LSTM layer compatible with new graph engine. It is based on previous LSTM implementation with some modification on how initializers blobs are processed.

Note: Following tests are currently are disabled 


Two following two tests are disbled since ONNNRuntime does not support `layout=1` attiribute inference. See a detailed issue #26456 on this.
- `LSTM_layout_seq` 
- `LSTM_layout_batch`

Following test fails with the new engine as it is not able to deal with shapes of the form [?, C, H, W]
- `LSTM_Activations`

Works:
- [x] One directional case any batch type 
 - [x] Fix directional case when batch size large than 1
 - [x] Add peepholes attribute

TODO with the next PRs:
 - [ ] Activation support

Note: 
  

> Currently `LSTM_layout_seq`, `LSTM_layout_batch` are disabled as the tests are incorrect. They do not comply with the ONNX standard. Particularly test outputs are of incorrect dimensionality. They produce 3-dimentinal output instead of 4-dimentional. 

------

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
2024-11-20 14:12:58 +03:00
.github Windows UWP build in CI for 5.x 2024-11-12 09:33:08 +03:00
3rdparty Merge branch 4.x 2024-11-13 09:02:39 +03:00
apps Merge pull request #26405 from kaingwade:rename_features2d 2024-11-12 11:04:48 +03:00
cmake Merge pull request #26469 from vpisarev:move_gapi_to_contrib_part1 2024-11-19 10:29:24 +03:00
doc Merge pull request #26469 from vpisarev:move_gapi_to_contrib_part1 2024-11-19 10:29:24 +03:00
include Merge pull request #26405 from kaingwade:rename_features2d 2024-11-12 11:04:48 +03:00
modules Merge pull request #26391 from Abdurrahheem:ash/lstm-new-graph-engine-latest 2024-11-20 14:12:58 +03:00
platforms Merge pull request #26405 from kaingwade:rename_features2d 2024-11-12 11:04:48 +03:00
samples Merge pull request #26469 from vpisarev:move_gapi_to_contrib_part1 2024-11-19 10:29:24 +03:00
.editorconfig add .editorconfig 2018-10-11 17:57:51 +00:00
.gitattributes cmake: generate and install ffmpeg-download.ps1 2018-06-09 13:19:48 +03:00
.gitignore Merge pull request #17165 from komakai:objc-binding 2020-06-08 18:32:53 +00:00
CMakeLists.txt Merge branch 4.x 2024-11-13 09:02:39 +03:00
CONTRIBUTING.md migration: github.com/opencv/opencv 2016-07-12 12:51:12 +03:00
COPYRIGHT Merge pull request #25520 from gursimarsingh:add-bigvision-copyright 2024-09-09 17:44:30 +03:00
LICENSE Merge pull request #18073 from vpisarev:apache2_license 2020-08-17 11:49:11 +00:00
README.md Merge branch 4.x 2024-04-02 16:39:54 +03:00
SECURITY.md Updated PGP key for security reports 2023-04-19 19:16:55 +03:00

OpenCV: Open Source Computer Vision Library

Resources

Contributing

Please read the contribution guidelines before starting work on a pull request.

Summary of the guidelines:

  • One pull request per issue;
  • Choose the right base branch;
  • Include tests and documentation;
  • Clean up "oops" commits before submitting;
  • Follow the coding style guide.

Additional Resources