Open Source Computer Vision Library
Go to file
Gregory Morse d30a0c6f03 Merge pull request #9856 from GregoryMorse:patch-1
* Update OpenCVCompilerOptimizations.cmake

Neon not supported on MSVC ARM breaking build fix

* Update OpenCVCompilerOptimizations.cmake

Whitespace

* Update intrin.hpp

Many problems in MSVC ARM builds (at least on VS2017) being fixed in this PR now.

C:\Users\Gregory\DOCUME~1\MYLIBR~1\OPENCV~3\opencv\sources\modules\core\include\opencv2/core/hal/intrin.hpp(444): error C3861: '_tzcnt_u32': identifier not found

* Update hal_replacement.hpp

Passing variadic expansion in a macro to another macro does not work properly in MSVC and a famous known workaround is hereby applied.  Discussion of it: https://stackoverflow.com/questions/5134523/msvc-doesnt-expand-va-args-correctly
Only needed the fix for ARM builds: TEGRA_ macros are used for cv_hal_ functions in the carotene library.

C:\Users\Gregory\Documents\My Libraries\opencv330\opencv\sources\modules\core\src\arithm.cpp(2378): warning C4003: not enough actual parameters for macro 'TEGRA_ADD'
C:\Users\Gregory\Documents\My Libraries\opencv330\opencv\sources\modules\core\src\arithm.cpp(2378): error C2143: syntax error: missing ')' before ','
C:\Users\Gregory\Documents\My Libraries\opencv330\opencv\sources\modules\core\src\arithm.cpp(2378): error C2059: syntax error: ')'

* Update hal_replacement.hpp

All hal_replacement's using carotene\hal\tegra_hal.hpp TEGRA_ functions as macros preprocessed by variadic macros should be changed, identical as was done in core.
C:\Users\Gregory\Documents\My Libraries\opencv330\opencv\sources\modules\imgproc\src\color.cpp(9604): warning C4003: not enough actual parameters for macro 'TEGRA_CVTBGRTOBGR'
C:\Users\Gregory\Documents\My Libraries\opencv330\opencv\sources\modules\imgproc\src\color.cpp(9604): error C2059: syntax error: '=='

* Update OpenCVCompilerOptimizations.cmake

* Update hal_replacement.hpp

* Update hal_replacement.hpp
2017-10-16 12:12:35 +03:00
.github migration: github.com/opencv/opencv 2016-07-12 12:51:12 +03:00
3rdparty Merge pull request #9805 from alalek:ffmpeg_update 2017-10-10 09:02:02 +00:00
apps cmake: drop INSTALL_NAME_DIR 2017-08-22 15:26:20 +03:00
cmake Merge pull request #9856 from GregoryMorse:patch-1 2017-10-16 12:12:35 +03:00
data fixing models to resolve XML violation issue 2017-06-13 09:42:15 +02:00
doc fix some grammatical errors 2017-10-10 21:37:26 -05:00
include Merge pull request #7370 from souch55:Fixxn 2016-10-01 10:44:56 +00:00
modules Merge pull request #9856 from GregoryMorse:patch-1 2017-10-16 12:12:35 +03:00
platforms Merge pull request #9466 from huningxin:js 2017-09-25 16:52:07 +03:00
samples Merge pull request #9824 from sturkmen72:upd_minEnclosingTriangle 2017-10-11 17:11:15 +00:00
.gitattributes build: added VERSIONINFO resource 2017-06-20 15:45:21 +03:00
.gitignore .gitignore: added ".cache" directory back 2017-06-21 19:03:17 +03:00
.tgitconfig Add tgit.icon project config 2014-02-26 17:46:52 +08:00
CMakeLists.txt MediaSDK video backend: Windows support 2017-10-11 16:33:37 +03:00
CONTRIBUTING.md migration: github.com/opencv/opencv 2016-07-12 12:51:12 +03:00
LICENSE Update license year range to 2016 2016-01-18 10:11:01 +05:30
README.md Improve README (#9243) 2017-09-13 17:58:34 +03:00

OpenCV: Open Source Computer Vision Library

Resources

Contributing

Please read the contribution guidelines before starting work on a pull request.

Summary of the guidelines:

  • One pull request per issue;
  • Choose the right base branch;
  • Include tests and documentation;
  • Clean up "oops" commits before submitting;
  • Follow the coding style guide.