Merge pull request #6186 from fufesou/fix/dialog_block_tab_on_remote_page

fix comments
This commit is contained in:
RustDesk 2023-10-26 17:27:08 +08:00 committed by GitHub
commit 0da6d51150
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -309,20 +309,20 @@ class _RemotePageState extends State<RemotePage>
final imageReady = _ffi.ffiModel.pi.isSet.isTrue && final imageReady = _ffi.ffiModel.pi.isSet.isTrue &&
_ffi.ffiModel.waitForFirstImage.isFalse; _ffi.ffiModel.waitForFirstImage.isFalse;
if (imageReady) { if (imageReady) {
// dismissAll() is ensure the state is clean. // `dismissAll()` is to ensure that the state is clean.
// It's ok to call dismissAll() here. // It's ok to call dismissAll() here.
_ffi.dialogManager.dismissAll(); _ffi.dialogManager.dismissAll();
// Recreate the block state to refresh the state. // Recreate the block state to refresh the state.
_blockableOverlayState = BlockableOverlayState(); _blockableOverlayState = BlockableOverlayState();
_blockableOverlayState.applyFfi(_ffi); _blockableOverlayState.applyFfi(_ffi);
// Block the whole bodyWidget() when dialog shows. // Block the whole `bodyWidget()` when dialog shows.
return BlockableOverlay( return BlockableOverlay(
underlying: bodyWidget(), underlying: bodyWidget(),
state: _blockableOverlayState, state: _blockableOverlayState,
); );
} else { } else {
// _blockableOverlayState is not recreated here. // `_blockableOverlayState` is not recreated here.
// The block state for the toolbar will not work on reconnecting, but it's ok. // The toolbar's block state won't work properly when reconnecting, but that's okay.
return bodyWidget(); return bodyWidget();
} }
}), }),