2014-04-13 16:29:52 +08:00
|
|
|
package topology
|
2013-04-16 15:10:21 +08:00
|
|
|
|
|
|
|
import (
|
2017-01-08 22:34:26 +08:00
|
|
|
"encoding/json"
|
2016-04-29 00:11:01 +08:00
|
|
|
"errors"
|
|
|
|
"fmt"
|
2014-10-27 02:34:55 +08:00
|
|
|
"net/http"
|
2017-01-08 22:34:26 +08:00
|
|
|
"net/url"
|
2014-10-27 02:34:55 +08:00
|
|
|
"strconv"
|
2016-04-29 00:11:01 +08:00
|
|
|
"strings"
|
2014-10-27 02:34:55 +08:00
|
|
|
|
2016-06-03 09:09:14 +08:00
|
|
|
"github.com/chrislusf/seaweedfs/weed/glog"
|
|
|
|
"github.com/chrislusf/seaweedfs/weed/operation"
|
|
|
|
"github.com/chrislusf/seaweedfs/weed/security"
|
|
|
|
"github.com/chrislusf/seaweedfs/weed/storage"
|
2019-04-19 12:43:36 +08:00
|
|
|
"github.com/chrislusf/seaweedfs/weed/storage/needle"
|
2020-08-19 08:04:28 +08:00
|
|
|
"github.com/chrislusf/seaweedfs/weed/storage/types"
|
2016-06-03 09:09:14 +08:00
|
|
|
"github.com/chrislusf/seaweedfs/weed/util"
|
2013-04-16 15:10:21 +08:00
|
|
|
)
|
|
|
|
|
2021-02-18 12:55:55 +08:00
|
|
|
func ReplicatedWrite(masterFn operation.GetMasterFn, s *storage.Store, volumeId needle.VolumeId, n *needle.Needle, r *http.Request) (isUnchanged bool, err error) {
|
2015-02-08 07:35:28 +08:00
|
|
|
|
|
|
|
//check JWT
|
|
|
|
jwt := security.GetJwt(r)
|
|
|
|
|
2020-04-12 12:39:16 +08:00
|
|
|
// check whether this is a replicated write request
|
2019-12-07 23:54:46 +08:00
|
|
|
var remoteLocations []operation.Location
|
|
|
|
if r.FormValue("type") != "replicate" {
|
2020-04-12 12:39:16 +08:00
|
|
|
// this is the initial request
|
2021-02-18 12:55:55 +08:00
|
|
|
remoteLocations, err = getWritableRemoteReplications(s, volumeId, masterFn)
|
2019-12-07 23:54:46 +08:00
|
|
|
if err != nil {
|
|
|
|
glog.V(0).Infoln(err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-04-12 12:39:16 +08:00
|
|
|
// read fsync value
|
|
|
|
fsync := false
|
|
|
|
if r.FormValue("fsync") == "true" {
|
|
|
|
fsync = true
|
|
|
|
}
|
|
|
|
|
2020-03-15 18:11:26 +08:00
|
|
|
if s.GetVolume(volumeId) != nil {
|
2020-04-12 12:39:16 +08:00
|
|
|
isUnchanged, err = s.WriteVolumeNeedle(volumeId, n, fsync)
|
2020-03-15 18:11:26 +08:00
|
|
|
if err != nil {
|
|
|
|
err = fmt.Errorf("failed to write to local disk: %v", err)
|
|
|
|
glog.V(0).Infoln(err)
|
|
|
|
return
|
|
|
|
}
|
2013-04-16 15:10:21 +08:00
|
|
|
}
|
2019-01-17 09:17:19 +08:00
|
|
|
|
2019-12-07 23:54:46 +08:00
|
|
|
if len(remoteLocations) > 0 { //send to other replica locations
|
|
|
|
if err = distributedOperation(remoteLocations, s, func(location operation.Location) error {
|
|
|
|
u := url.URL{
|
|
|
|
Scheme: "http",
|
|
|
|
Host: location.Url,
|
|
|
|
Path: r.URL.Path,
|
|
|
|
}
|
|
|
|
q := url.Values{
|
|
|
|
"type": {"replicate"},
|
|
|
|
"ttl": {n.Ttl.String()},
|
|
|
|
}
|
|
|
|
if n.LastModified > 0 {
|
|
|
|
q.Set("ts", strconv.FormatUint(n.LastModified, 10))
|
|
|
|
}
|
|
|
|
if n.IsChunkedManifest() {
|
|
|
|
q.Set("cm", "true")
|
|
|
|
}
|
|
|
|
u.RawQuery = q.Encode()
|
|
|
|
|
|
|
|
pairMap := make(map[string]string)
|
|
|
|
if n.HasPairs() {
|
|
|
|
tmpMap := make(map[string]string)
|
|
|
|
err := json.Unmarshal(n.Pairs, &tmpMap)
|
|
|
|
if err != nil {
|
|
|
|
glog.V(0).Infoln("Unmarshal pairs error:", err)
|
2016-02-27 17:42:41 +08:00
|
|
|
}
|
2019-12-07 23:54:46 +08:00
|
|
|
for k, v := range tmpMap {
|
|
|
|
pairMap[needle.PairNamePrefix+k] = v
|
2017-01-08 22:34:26 +08:00
|
|
|
}
|
2013-04-16 15:10:21 +08:00
|
|
|
}
|
2019-12-07 23:54:46 +08:00
|
|
|
|
2020-03-06 16:49:47 +08:00
|
|
|
// volume server do not know about encryption
|
2020-11-12 04:51:27 +08:00
|
|
|
// TODO optimize here to compress data only once
|
2020-06-20 13:45:27 +08:00
|
|
|
_, err := operation.UploadData(u.String(), string(n.Name), false, n.Data, n.IsCompressed(), string(n.Mime), pairMap, jwt)
|
2019-12-07 23:54:46 +08:00
|
|
|
return err
|
|
|
|
}); err != nil {
|
|
|
|
err = fmt.Errorf("failed to write to replicas for volume %d: %v", volumeId, err)
|
|
|
|
glog.V(0).Infoln(err)
|
2013-04-16 15:10:21 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-02-18 12:55:55 +08:00
|
|
|
func ReplicatedDelete(masterFn operation.GetMasterFn, store *storage.Store,
|
2019-04-19 12:43:36 +08:00
|
|
|
volumeId needle.VolumeId, n *needle.Needle,
|
2020-08-19 08:04:28 +08:00
|
|
|
r *http.Request) (size types.Size, err error) {
|
2015-02-08 07:35:28 +08:00
|
|
|
|
|
|
|
//check JWT
|
|
|
|
jwt := security.GetJwt(r)
|
|
|
|
|
2019-12-07 23:54:46 +08:00
|
|
|
var remoteLocations []operation.Location
|
|
|
|
if r.FormValue("type") != "replicate" {
|
2021-02-18 12:55:55 +08:00
|
|
|
remoteLocations, err = getWritableRemoteReplications(store, volumeId, masterFn)
|
2019-12-07 23:54:46 +08:00
|
|
|
if err != nil {
|
|
|
|
glog.V(0).Infoln(err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
size, err = store.DeleteVolumeNeedle(volumeId, n)
|
2013-04-16 15:10:21 +08:00
|
|
|
if err != nil {
|
2013-08-09 14:57:22 +08:00
|
|
|
glog.V(0).Infoln("delete error:", err)
|
2019-12-07 23:54:46 +08:00
|
|
|
return
|
2013-04-16 15:10:21 +08:00
|
|
|
}
|
|
|
|
|
2019-12-07 23:54:46 +08:00
|
|
|
if len(remoteLocations) > 0 { //send to other replica locations
|
|
|
|
if err = distributedOperation(remoteLocations, store, func(location operation.Location) error {
|
|
|
|
return util.Delete("http://"+location.Url+r.URL.Path+"?type=replicate", string(jwt))
|
|
|
|
}); err != nil {
|
|
|
|
size = 0
|
2013-04-16 15:10:21 +08:00
|
|
|
}
|
|
|
|
}
|
2019-12-07 23:54:46 +08:00
|
|
|
return
|
2016-04-29 00:11:01 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
type DistributedOperationResult map[string]error
|
|
|
|
|
|
|
|
func (dr DistributedOperationResult) Error() error {
|
|
|
|
var errs []string
|
|
|
|
for k, v := range dr {
|
|
|
|
if v != nil {
|
|
|
|
errs = append(errs, fmt.Sprintf("[%s]: %v", k, v))
|
|
|
|
}
|
|
|
|
}
|
2016-05-06 01:37:33 +08:00
|
|
|
if len(errs) == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
2016-04-29 00:11:01 +08:00
|
|
|
return errors.New(strings.Join(errs, "\n"))
|
|
|
|
}
|
|
|
|
|
|
|
|
type RemoteResult struct {
|
|
|
|
Host string
|
|
|
|
Error error
|
2013-04-16 15:10:21 +08:00
|
|
|
}
|
|
|
|
|
2019-12-07 23:54:46 +08:00
|
|
|
func distributedOperation(locations []operation.Location, store *storage.Store, op func(location operation.Location) error) error {
|
|
|
|
length := len(locations)
|
|
|
|
results := make(chan RemoteResult)
|
|
|
|
for _, location := range locations {
|
|
|
|
go func(location operation.Location, results chan RemoteResult) {
|
|
|
|
results <- RemoteResult{location.Url, op(location)}
|
|
|
|
}(location, results)
|
|
|
|
}
|
|
|
|
ret := DistributedOperationResult(make(map[string]error))
|
|
|
|
for i := 0; i < length; i++ {
|
|
|
|
result := <-results
|
|
|
|
ret[result.Host] = result.Error
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret.Error()
|
|
|
|
}
|
|
|
|
|
2021-02-18 12:55:55 +08:00
|
|
|
func getWritableRemoteReplications(s *storage.Store, volumeId needle.VolumeId, masterFn operation.GetMasterFn) (
|
2019-12-07 23:54:46 +08:00
|
|
|
remoteLocations []operation.Location, err error) {
|
volume: proxy writes to remote volume server, with replication or not
the panic is triggered by uploading a file to a volume server not holding the designated replica.
2020-03-15 10:20:14.365488 I | http: panic serving 127.0.0.1:57124: runtime error: invalid memory address or nil pointer dereference
goroutine 119 [running]:
net/http.(*conn).serve.func1(0xc0001a8000)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1772 +0x139
panic(0x2316fe0, 0x3662900)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/runtime/panic.go:973 +0x396
github.com/chrislusf/seaweedfs/weed/topology.getWritableRemoteReplications(0xc00009c000, 0x2, 0x7ffeefbffbd2, 0xe, 0x0, 0xa, 0x0, 0x0, 0xbb4bf1f7)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:157 +0x53
github.com/chrislusf/seaweedfs/weed/topology.ReplicatedWrite(0x7ffeefbffbd2, 0xe, 0xc00009c000, 0xc000000002, 0xc000472750, 0xc0001b2200, 0x0, 0x1, 0x0)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:29 +0xc7
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).PostHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers_write.go:52 +0x56f
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).privateStoreHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers.go:37 +0x21f
net/http.HandlerFunc.ServeHTTP(0xc0004420e0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2012 +0x44
net/http.(*ServeMux).ServeHTTP(0xc0001fc800, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2387 +0x1a5
net/http.serverHandler.ServeHTTP(0xc0001781c0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2807 +0xa3
net/http.(*conn).serve(0xc0001a8000, 0x2934420, 0xc000212400)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1895 +0x86c
created by net/http.(*Server).Serve
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2933 +0x35c
Eg:
server A (datacenter 1) and server B (datacenter 2) hold replica (100) for volume 1.
If you upload a file with a key 1,xxxxx to server C (datacenter 3) will trigger the panic on server C.
The server C should either proxy upload file to the correct volume server or should return an HTTP error code and not panic.
2020-03-15 17:50:42 +08:00
|
|
|
|
2020-03-15 07:32:16 +08:00
|
|
|
v := s.GetVolume(volumeId)
|
volume: proxy writes to remote volume server, with replication or not
the panic is triggered by uploading a file to a volume server not holding the designated replica.
2020-03-15 10:20:14.365488 I | http: panic serving 127.0.0.1:57124: runtime error: invalid memory address or nil pointer dereference
goroutine 119 [running]:
net/http.(*conn).serve.func1(0xc0001a8000)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1772 +0x139
panic(0x2316fe0, 0x3662900)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/runtime/panic.go:973 +0x396
github.com/chrislusf/seaweedfs/weed/topology.getWritableRemoteReplications(0xc00009c000, 0x2, 0x7ffeefbffbd2, 0xe, 0x0, 0xa, 0x0, 0x0, 0xbb4bf1f7)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:157 +0x53
github.com/chrislusf/seaweedfs/weed/topology.ReplicatedWrite(0x7ffeefbffbd2, 0xe, 0xc00009c000, 0xc000000002, 0xc000472750, 0xc0001b2200, 0x0, 0x1, 0x0)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:29 +0xc7
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).PostHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers_write.go:52 +0x56f
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).privateStoreHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers.go:37 +0x21f
net/http.HandlerFunc.ServeHTTP(0xc0004420e0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2012 +0x44
net/http.(*ServeMux).ServeHTTP(0xc0001fc800, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2387 +0x1a5
net/http.serverHandler.ServeHTTP(0xc0001781c0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2807 +0xa3
net/http.(*conn).serve(0xc0001a8000, 0x2934420, 0xc000212400)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1895 +0x86c
created by net/http.(*Server).Serve
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2933 +0x35c
Eg:
server A (datacenter 1) and server B (datacenter 2) hold replica (100) for volume 1.
If you upload a file with a key 1,xxxxx to server C (datacenter 3) will trigger the panic on server C.
The server C should either proxy upload file to the correct volume server or should return an HTTP error code and not panic.
2020-03-15 17:50:42 +08:00
|
|
|
if v != nil && v.ReplicaPlacement.GetCopyCount() == 1 {
|
|
|
|
return
|
2020-03-15 07:06:03 +08:00
|
|
|
}
|
volume: proxy writes to remote volume server, with replication or not
the panic is triggered by uploading a file to a volume server not holding the designated replica.
2020-03-15 10:20:14.365488 I | http: panic serving 127.0.0.1:57124: runtime error: invalid memory address or nil pointer dereference
goroutine 119 [running]:
net/http.(*conn).serve.func1(0xc0001a8000)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1772 +0x139
panic(0x2316fe0, 0x3662900)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/runtime/panic.go:973 +0x396
github.com/chrislusf/seaweedfs/weed/topology.getWritableRemoteReplications(0xc00009c000, 0x2, 0x7ffeefbffbd2, 0xe, 0x0, 0xa, 0x0, 0x0, 0xbb4bf1f7)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:157 +0x53
github.com/chrislusf/seaweedfs/weed/topology.ReplicatedWrite(0x7ffeefbffbd2, 0xe, 0xc00009c000, 0xc000000002, 0xc000472750, 0xc0001b2200, 0x0, 0x1, 0x0)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:29 +0xc7
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).PostHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers_write.go:52 +0x56f
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).privateStoreHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers.go:37 +0x21f
net/http.HandlerFunc.ServeHTTP(0xc0004420e0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2012 +0x44
net/http.(*ServeMux).ServeHTTP(0xc0001fc800, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2387 +0x1a5
net/http.serverHandler.ServeHTTP(0xc0001781c0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2807 +0xa3
net/http.(*conn).serve(0xc0001a8000, 0x2934420, 0xc000212400)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1895 +0x86c
created by net/http.(*Server).Serve
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2933 +0x35c
Eg:
server A (datacenter 1) and server B (datacenter 2) hold replica (100) for volume 1.
If you upload a file with a key 1,xxxxx to server C (datacenter 3) will trigger the panic on server C.
The server C should either proxy upload file to the correct volume server or should return an HTTP error code and not panic.
2020-03-15 17:50:42 +08:00
|
|
|
|
|
|
|
// not on local store, or has replications
|
2021-02-18 12:55:55 +08:00
|
|
|
lookupResult, lookupErr := operation.Lookup(masterFn, volumeId.String())
|
volume: proxy writes to remote volume server, with replication or not
the panic is triggered by uploading a file to a volume server not holding the designated replica.
2020-03-15 10:20:14.365488 I | http: panic serving 127.0.0.1:57124: runtime error: invalid memory address or nil pointer dereference
goroutine 119 [running]:
net/http.(*conn).serve.func1(0xc0001a8000)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1772 +0x139
panic(0x2316fe0, 0x3662900)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/runtime/panic.go:973 +0x396
github.com/chrislusf/seaweedfs/weed/topology.getWritableRemoteReplications(0xc00009c000, 0x2, 0x7ffeefbffbd2, 0xe, 0x0, 0xa, 0x0, 0x0, 0xbb4bf1f7)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:157 +0x53
github.com/chrislusf/seaweedfs/weed/topology.ReplicatedWrite(0x7ffeefbffbd2, 0xe, 0xc00009c000, 0xc000000002, 0xc000472750, 0xc0001b2200, 0x0, 0x1, 0x0)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:29 +0xc7
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).PostHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers_write.go:52 +0x56f
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).privateStoreHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers.go:37 +0x21f
net/http.HandlerFunc.ServeHTTP(0xc0004420e0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2012 +0x44
net/http.(*ServeMux).ServeHTTP(0xc0001fc800, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2387 +0x1a5
net/http.serverHandler.ServeHTTP(0xc0001781c0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2807 +0xa3
net/http.(*conn).serve(0xc0001a8000, 0x2934420, 0xc000212400)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1895 +0x86c
created by net/http.(*Server).Serve
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2933 +0x35c
Eg:
server A (datacenter 1) and server B (datacenter 2) hold replica (100) for volume 1.
If you upload a file with a key 1,xxxxx to server C (datacenter 3) will trigger the panic on server C.
The server C should either proxy upload file to the correct volume server or should return an HTTP error code and not panic.
2020-03-15 17:50:42 +08:00
|
|
|
if lookupErr == nil {
|
|
|
|
selfUrl := s.Ip + ":" + strconv.Itoa(s.Port)
|
|
|
|
for _, location := range lookupResult.Locations {
|
|
|
|
if location.Url != selfUrl {
|
|
|
|
remoteLocations = append(remoteLocations, location)
|
2015-12-28 14:23:26 +08:00
|
|
|
}
|
volume: proxy writes to remote volume server, with replication or not
the panic is triggered by uploading a file to a volume server not holding the designated replica.
2020-03-15 10:20:14.365488 I | http: panic serving 127.0.0.1:57124: runtime error: invalid memory address or nil pointer dereference
goroutine 119 [running]:
net/http.(*conn).serve.func1(0xc0001a8000)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1772 +0x139
panic(0x2316fe0, 0x3662900)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/runtime/panic.go:973 +0x396
github.com/chrislusf/seaweedfs/weed/topology.getWritableRemoteReplications(0xc00009c000, 0x2, 0x7ffeefbffbd2, 0xe, 0x0, 0xa, 0x0, 0x0, 0xbb4bf1f7)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:157 +0x53
github.com/chrislusf/seaweedfs/weed/topology.ReplicatedWrite(0x7ffeefbffbd2, 0xe, 0xc00009c000, 0xc000000002, 0xc000472750, 0xc0001b2200, 0x0, 0x1, 0x0)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/topology/store_replicate.go:29 +0xc7
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).PostHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers_write.go:52 +0x56f
github.com/chrislusf/seaweedfs/weed/server.(*VolumeServer).privateStoreHandler(0xc0001513f0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/gopath/src/github.com/chrislusf/seaweedfs/weed/server/volume_server_handlers.go:37 +0x21f
net/http.HandlerFunc.ServeHTTP(0xc0004420e0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2012 +0x44
net/http.(*ServeMux).ServeHTTP(0xc0001fc800, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2387 +0x1a5
net/http.serverHandler.ServeHTTP(0xc0001781c0, 0x292bde0, 0xc0001fe2a0, 0xc0001b2200)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2807 +0xa3
net/http.(*conn).serve(0xc0001a8000, 0x2934420, 0xc000212400)
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:1895 +0x86c
created by net/http.(*Server).Serve
/home/travis/.gimme/versions/go1.14.linux.amd64/src/net/http/server.go:2933 +0x35c
Eg:
server A (datacenter 1) and server B (datacenter 2) hold replica (100) for volume 1.
If you upload a file with a key 1,xxxxx to server C (datacenter 3) will trigger the panic on server C.
The server C should either proxy upload file to the correct volume server or should return an HTTP error code and not panic.
2020-03-15 17:50:42 +08:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
err = fmt.Errorf("failed to lookup for %d: %v", volumeId, lookupErr)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if v != nil {
|
|
|
|
// has one local and has remote replications
|
|
|
|
copyCount := v.ReplicaPlacement.GetCopyCount()
|
|
|
|
if len(lookupResult.Locations) < copyCount {
|
|
|
|
err = fmt.Errorf("replicating opetations [%d] is less than volume %d replication copy count [%d]",
|
|
|
|
len(lookupResult.Locations), volumeId, copyCount)
|
2015-12-31 14:48:19 +08:00
|
|
|
}
|
2013-04-16 15:10:21 +08:00
|
|
|
}
|
2019-12-12 14:22:09 +08:00
|
|
|
|
2019-12-07 23:54:46 +08:00
|
|
|
return
|
2013-04-16 15:10:21 +08:00
|
|
|
}
|