From d821cb3b187a381a42da3fcbc2749c5e66077f1d Mon Sep 17 00:00:00 2001 From: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.com> Date: Thu, 21 Mar 2024 00:54:29 +0500 Subject: [PATCH 1/3] fix: sync without dir /buckets/some/.uploads/hash_hash (#5402) --- weed/command/filer_sync.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/weed/command/filer_sync.go b/weed/command/filer_sync.go index 292fb0956..9ad76e31b 100644 --- a/weed/command/filer_sync.go +++ b/weed/command/filer_sync.go @@ -394,7 +394,7 @@ func genProcessFunction(sourcePath string, targetPath string, excludePaths []str glog.V(0).Infof("received %v", resp) } - if isMultipartUploadDir(resp.Directory) { + if isMultipartUploadDir(resp.Directory + "/") { return nil } From 50023fe1cf11a5f0d3920de393c188a7186bafb4 Mon Sep 17 00:00:00 2001 From: chrislu Date: Thu, 21 Mar 2024 08:07:56 -0700 Subject: [PATCH 2/3] adjust log level --- weed/util/log_buffer/log_read.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/weed/util/log_buffer/log_read.go b/weed/util/log_buffer/log_read.go index 0354f0e7f..29ac88b18 100644 --- a/weed/util/log_buffer/log_read.go +++ b/weed/util/log_buffer/log_read.go @@ -57,7 +57,7 @@ func (logBuffer *LogBuffer) LoopProcessLogData(readerName string, startPosition if bytesBuf != nil { readSize = bytesBuf.Len() } - glog.V(0).Infof("%s ReadFromBuffer at %v batch %d. Read bytes %v batch %d", readerName, lastReadPosition, lastReadPosition.BatchIndex, readSize, batchIndex) + glog.V(4).Infof("%s ReadFromBuffer at %v batch %d. Read bytes %v batch %d", readerName, lastReadPosition, lastReadPosition.BatchIndex, readSize, batchIndex) if bytesBuf == nil { if batchIndex >= 0 { lastReadPosition = NewMessagePosition(lastReadPosition.UnixNano(), batchIndex) From 25643cfbc6fdde5a73725b557fd2d6ae8e66484f Mon Sep 17 00:00:00 2001 From: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.com> Date: Thu, 21 Mar 2024 20:12:31 +0500 Subject: [PATCH 3/3] fix: panic: assignment to entry in nil map on S3Sink.CreateEntry (#5406) --- weed/replication/sink/s3sink/s3_sink.go | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/weed/replication/sink/s3sink/s3_sink.go b/weed/replication/sink/s3sink/s3_sink.go index 276ea30d6..81acd9a2d 100644 --- a/weed/replication/sink/s3sink/s3_sink.go +++ b/weed/replication/sink/s3sink/s3_sink.go @@ -175,18 +175,23 @@ func (s3sink *S3Sink) CreateEntry(key string, entry *filer_pb.Entry, signatures uploader.PartSize = 0 } } - if _, ok := entry.Extended[s3_constants.AmzUserMetaMtime]; !ok { + + doSaveMtime := true + if entry.Extended == nil { + entry.Extended = make(map[string][]byte) + } else if _, ok := entry.Extended[s3_constants.AmzUserMetaMtime]; ok { + doSaveMtime = false + } + if doSaveMtime { entry.Extended[s3_constants.AmzUserMetaMtime] = []byte(strconv.FormatInt(entry.Attributes.Mtime, 10)) } // process tagging tags := "" - if true { - for k, v := range entry.Extended { - if len(tags) > 0 { - tags = tags + "&" - } - tags = tags + k + "=" + string(v) + for k, v := range entry.Extended { + if len(tags) > 0 { + tags = tags + "&" } + tags = tags + k + "=" + string(v) } // Upload the file to S3.