seaweedfs/weed/mount
Chris Lu 952afd810c
Fix dead lock (#5815)
* reduce locks to avoid dead lock

Flush->FlushData->uplloadPipeline.FluahAll
uploaderCount>0

goroutine 1 [sync.Cond.Wait, 71 minutes]:
sync.runtime_notifyListWait(0xc0007ae4d0, 0x0)
	/usr/local/go/src/runtime/sema.go:569 +0x159
sync.(*Cond).Wait(0xc001a59290?)
	/usr/local/go/src/sync/cond.go:70 +0x85
github.com/seaweedfs/seaweedfs/weed/mount/page_writer.(*UploadPipeline).waitForCurrentWritersToComplete(0xc0002ee4d0)
	/github/workspace/weed/mount/page_writer/upload_pipeline_lock.go:58 +0x32
github.com/seaweedfs/seaweedfs/weed/mount/page_writer.(*UploadPipeline).FlushAll(0xc0002ee4d0)
	/github/workspace/weed/mount/page_writer/upload_pipeline.go:151 +0x25
github.com/seaweedfs/seaweedfs/weed/mount.(*ChunkedDirtyPages).FlushData(0xc00087e840)
	/github/workspace/weed/mount/dirty_pages_chunked.go:54 +0x29
github.com/seaweedfs/seaweedfs/weed/mount.(*PageWriter).FlushData(...)
	/github/workspace/weed/mount/page_writer.go:50
github.com/seaweedfs/seaweedfs/weed/mount.(*WFS).doFlush(0xc0006ad600, 0xc00030d380, 0x0, 0x0)
	/github/workspace/weed/mount/weedfs_file_sync.go:101 +0x169
github.com/seaweedfs/seaweedfs/weed/mount.(*WFS).Flush(0xc0006ad600, 0xc001a594a8?, 0xc0004c1ca0)
	/github/workspace/weed/mount/weedfs_file_sync.go:59 +0x48
github.com/hanwen/go-fuse/v2/fuse.doFlush(0xc0000da870?, 0xc0004c1b08)

SaveContent -> MemChunk.RLock ->
	ChunkedDirtyPages.saveChunkedFileIntervalToStorage
	pages.fh.AddChunks([]*filer_pb.FileChunk{chunk})
		fh.entryLock.Lock()

sync.(*RWMutex).Lock(0x0?)
	/usr/local/go/src/sync/rwmutex.go:146 +0x31
github.com/seaweedfs/seaweedfs/weed/mount.(*FileHandle).AddChunks(0xc00030d380, {0xc00028bdc8, 0x1, 0x1})
	/github/workspace/weed/mount/filehandle.go:93 +0x45
github.com/seaweedfs/seaweedfs/weed/mount.(*ChunkedDirtyPages).saveChunkedFileIntervalToStorage(0xc00087e840, {0x2be7ac0, 0xc00018d9e0}, 0x0, 0x121, 0x17e3c624565ace45, 0x1?)
	/github/workspace/weed/mount/dirty_pages_chunked.go:80 +0x2d4
github.com/seaweedfs/seaweedfs/weed/mount/page_writer.(*MemChunk).SaveContent(0xc0008d9130, 0xc0008093e0)
	/github/workspace/weed/mount/page_writer/page_chunk_mem.go:115 +0x112
github.com/seaweedfs/seaweedfs/weed/mount/page_writer.(*UploadPipeline).moveToSealed.func1()
	/github/workspace/weed/mount/page_writer/upload_pipeline.go:187 +0x55
github.com/seaweedfs/seaweedfs/weed/util.(*LimitedConcurrentExecutor).Execute.func1()
	/github/workspace/weed/util/limited_executor.go:38 +0x62
created by github.com/seaweedfs/seaweedfs/weed/util.(*LimitedConcurrentExecutor).Execute in goroutine 1
	/github/workspace/weed/util/limited_executor.go:33 +0x97

On metadata update
fh.entryLock.Lock()
	fh.dirtyPages.Destroy()
		up.chunksLock.Lock => each sealed chunk.FreeReference => MemChunk.Lock

goroutine 134 [sync.RWMutex.Lock, 71 minutes]:
sync.runtime_SemacquireRWMutex(0xc0007c3558?, 0xea?, 0x3fb0800?)
	/usr/local/go/src/runtime/sema.go:87 +0x25
sync.(*RWMutex).Lock(0xc0007c35a8?)
	/usr/local/go/src/sync/rwmutex.go:151 +0x6a
github.com/seaweedfs/seaweedfs/weed/mount/page_writer.(*MemChunk).FreeResource(0xc0008d9130)
	/github/workspace/weed/mount/page_writer/page_chunk_mem.go:38 +0x2a
github.com/seaweedfs/seaweedfs/weed/mount/page_writer.(*SealedChunk).FreeReference(0xc00071cdb0, {0xc0006ba1a0, 0x20})
	/github/workspace/weed/mount/page_writer/upload_pipeline.go:38 +0xb7
github.com/seaweedfs/seaweedfs/weed/mount/page_writer.(*UploadPipeline).Shutdown(0xc0002ee4d0)
	/github/workspace/weed/mount/page_writer/upload_pipeline.go:220 +0x185
github.com/seaweedfs/seaweedfs/weed/mount.(*ChunkedDirtyPages).Destroy(0xc0008cea40?)
	/github/workspace/weed/mount/dirty_pages_chunked.go:87 +0x17
github.com/seaweedfs/seaweedfs/weed/mount.(*PageWriter).Destroy(...)
	/github/workspace/weed/mount/page_writer.go:78
github.com/seaweedfs/seaweedfs/weed/mount.NewSeaweedFileSystem.func3({0xc00069a6c0, 0x30}, 0x6?)
	/github/workspace/weed/mount/weedfs.go:119 +0x17a
github.com/seaweedfs/seaweedfs/weed/mount/meta_cache.NewMetaCache.func1({0xc00069a6c0?, 0xc00069a480?}, 0x4015b40?)
	/github/workspace/weed/mount/meta_cache/meta_cache.go:37 +0x1c
github.com/seaweedfs/seaweedfs/weed/mount/meta_cache.SubscribeMetaEvents.func1(0xc000661810)
	/github/workspace/weed/mount/meta_cache/meta_cache_subscribe.go:43 +0x570

* use locked entry everywhere

* modifiable remote entry

* skip locking after getting lock from fhLockTable
2024-07-24 23:46:40 -07:00
..
meta_cache ensure metadata follow a specific folder 2024-07-12 11:17:30 -07:00
page_writer go fmt 2024-05-20 11:03:56 -07:00
unmount fix GOOS 2022-02-14 03:14:05 -08:00
dirty_pages_chunked.go Revert "Revert "Merge branch 'master' into sub"" 2023-09-18 18:47:34 -07:00
filehandle_map.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
filehandle_read.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
filehandle.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
inode_to_path_test.go move to https://github.com/seaweedfs/seaweedfs 2022-07-29 00:17:28 -07:00
inode_to_path.go Fix Issue #5649 (#5652) 2024-06-06 12:49:33 -07:00
locked_entry.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
page_writer_pattern.go atomic operation 2022-08-26 17:04:11 -07:00
page_writer.go more solid weed mount (#4089) 2023-01-02 23:20:45 -08:00
weedfs_attr_darwin.go can attr root directory 2022-02-12 01:54:16 -08:00
weedfs_attr_linux.go can attr root directory 2022-02-12 01:54:16 -08:00
weedfs_attr.go [mount] fix GetAttr blocks count (#5409) 2024-03-22 06:11:16 -07:00
weedfs_dir_lookup.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
weedfs_dir_mkrm.go Skip parent directory creation in mount (#4310) 2023-03-15 12:37:25 -07:00
weedfs_dir_read.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
weedfs_file_copy_range.go read source uses shared lock 2023-09-23 10:33:44 -07:00
weedfs_file_io.go mount: return open status 2022-03-12 22:38:14 -08:00
weedfs_file_lseek.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
weedfs_file_mkrm.go [mount]: delete redundant code (#4173) 2023-01-31 18:54:46 -08:00
weedfs_file_read.go mount switch to ordered lock requests 2023-09-21 11:08:26 -07:00
weedfs_file_sync.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
weedfs_file_write.go mount switch to ordered lock requests 2023-09-21 11:08:26 -07:00
weedfs_filehandle.go remove unused symlink resolving 2022-08-04 01:35:18 -07:00
weedfs_forget.go move to https://github.com/seaweedfs/seaweedfs 2022-07-29 00:17:28 -07:00
weedfs_grpc_server.go move to https://github.com/seaweedfs/seaweedfs 2022-07-29 00:17:28 -07:00
weedfs_link.go Skip parent directory creation in mount (#4310) 2023-03-15 12:37:25 -07:00
weedfs_quota.go move to https://github.com/seaweedfs/seaweedfs 2022-07-29 00:17:28 -07:00
weedfs_rename.go refactor: moved to locked entry 2022-12-04 23:33:05 -08:00
weedfs_stats.go mount: adjust on du stats reporting 2022-08-09 20:21:01 -07:00
weedfs_symlink.go Skip parent directory creation in mount (#4310) 2023-03-15 12:37:25 -07:00
weedfs_unsupported.go Implement lseek syscall in FUSE (#3491) 2022-08-23 01:47:18 -07:00
weedfs_write.go Added tls for http clients (#5766) 2024-07-16 23:14:09 -07:00
weedfs_xattr.go Fix large file chunks deleted by mistake (#4678) 2023-07-17 07:52:14 -07:00
weedfs.go Fix dead lock (#5815) 2024-07-24 23:46:40 -07:00
wfs_filer_client.go grpc connection to filer add sw-client-id header 2023-01-20 01:48:12 -08:00
wfs_save.go move to https://github.com/seaweedfs/seaweedfs 2022-07-29 00:17:28 -07:00