mirror/tesseract
1
0
Fork 0
mirror of https://github.com/tesseract-ocr/tesseract.git synced 2025-01-18 06:30:14 +08:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

WERD_RES: Remove comparisons which are constant

Browse Source 
This fixes warnings from LGTM:

Comparison is always false because id >= 0.
Comparison is always true because mirrored >= 1.
Comparison is always false because id >= 0.

INVALID_UNICHAR_ID is -1, so the warnings are correct.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
This commit is contained in:
Stefan Weil 2018-10-06 20:06:38 +02:00
parent 238c872753
commit 18f7ab751e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ccstruct/pageres.h
View File

@ -363,10 +363,10 @@ class WERD_RES : public ELIST_LINK {
blob_index >= best_choice->length()) blob_index >= best_choice->length())
return nullptr; return nullptr;
UNICHAR_ID id = best_choice->unichar_id(blob_index); UNICHAR_ID id = best_choice->unichar_id(blob_index);
if (id < 0 || id >= uch_set->size() || id == INVALID_UNICHAR_ID) if (id < 0 || id >= uch_set->size())
return nullptr; return nullptr;
UNICHAR_ID mirrored = uch_set->get_mirror(id); UNICHAR_ID mirrored = uch_set->get_mirror(id);
if (in_rtl_context && mirrored > 0 && mirrored != INVALID_UNICHAR_ID) if (in_rtl_context && mirrored > 0)
id = mirrored; id = mirrored;
return uch_set->id_to_unichar_ext(id); return uch_set->id_to_unichar_ext(id);
} }
@ -375,7 +375,7 @@ class WERD_RES : public ELIST_LINK {
if (blob_index < 0 || blob_index >= raw_choice->length()) if (blob_index < 0 || blob_index >= raw_choice->length())
return nullptr; return nullptr;
UNICHAR_ID id = raw_choice->unichar_id(blob_index); UNICHAR_ID id = raw_choice->unichar_id(blob_index);
if (id < 0 || id >= uch_set->size() || id == INVALID_UNICHAR_ID) if (id < 0 || id >= uch_set->size())
return nullptr; return nullptr;
return uch_set->id_to_unichar(id); return uch_set->id_to_unichar(id);
} }