From 9f87c36e237100402d2965bd565cb2b33d0bb444 Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Tue, 24 Nov 2015 18:21:57 +0100 Subject: [PATCH] Fix duplicate fclose Coverity bug report: CID 1270401 (#1 of 1): Use after free As the comment (which was also fixed) says, ReadNextBox() already calls fclose(box_file), so don't call it a 2nd time. Signed-off-by: Stefan Weil --- ccmain/recogtraining.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ccmain/recogtraining.cpp b/ccmain/recogtraining.cpp index 27d7e97e..a2388106 100644 --- a/ccmain/recogtraining.cpp +++ b/ccmain/recogtraining.cpp @@ -84,7 +84,7 @@ void Tesseract::recog_training_segmented(const STRING &fname, const char *lastdot = strrchr(box_fname.string(), '.'); if (lastdot != NULL) box_fname[lastdot - box_fname.string()] = '\0'; box_fname += ".box"; - // read_next_box() will close box_file + // ReadNextBox() will close box_file FILE *box_file = open_file(box_fname.string(), "r"); PAGE_RES_IT page_res_it; @@ -132,7 +132,6 @@ void Tesseract::recog_training_segmented(const STRING &fname, } page_res_it.forward(); } while (keep_going); - fclose(box_file); // Set up scripts on all of the words that did not get sent to // ambigs_classify_and_output. They all should have, but if all the