From eb00574c4a8355cb6ee902c7124b3fe4c493fe1f Mon Sep 17 00:00:00 2001 From: Michael McConville Date: Wed, 13 Apr 2016 15:15:56 -0400 Subject: [PATCH] Remove conditional definition of off_t As pointed out by Stefan Weil, conditionally defining off_t using a macro isn't a valid approach. off_t does not have a fixed size and is used in ABI definitions (e.g. syscalls), so silently guessing its size risks breaking the build. Additionally, all sane and modern platforms will have off_t. --- ccutil/scanutils.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/ccutil/scanutils.cpp b/ccutil/scanutils.cpp index fca4f8192..cba7d5491 100644 --- a/ccutil/scanutils.cpp +++ b/ccutil/scanutils.cpp @@ -37,11 +37,6 @@ #include "scanutils.h" #include "tprintf.h" -// workaround for "'off_t' was not declared in this scope" with -std=c++11 -#if !defined(HAVE_OFF_T) -typedef long off_t; -#endif // off_t - enum Flags { FL_SPLAT = 0x01, // Drop the value, do not assign FL_INV = 0x02, // Character-set with inverse