mirror/tiptap
1
0
Fork 0
mirror of https://github.com/ueberdosis/tiptap.git synced 2024-11-24 03:39:01 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(bubble-menu): prevent null pointer exception in BubbleMenu (#5842)

Browse Source
This commit is contained in:
Felix Gabler 2024-11-19 03:27:06 +01:00 committed by GitHub
parent 2ea807d1db
commit 1959eb5920
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/seven-hats-thank.md Normal file
View File

@ -0,0 +1,5 @@
---
"@tiptap/extension-bubble-menu": patch
---
Fix a potential null pointer exception

16
packages/extension-bubble-menu/src/bubble-menu-plugin.ts
View File

@ -266,14 +266,16 @@ export class BubbleMenuView {
if (isNodeSelection(state.selection)) { if (isNodeSelection(state.selection)) {
let node = view.nodeDOM(from) as HTMLElement let node = view.nodeDOM(from) as HTMLElement
const nodeViewWrapper = node.dataset.nodeViewWrapper ? node : node.querySelector('[data-node-view-wrapper]')
if (nodeViewWrapper) {
node = nodeViewWrapper.firstChild as HTMLElement
}
if (node) { if (node) {
return node.getBoundingClientRect() const nodeViewWrapper = node.dataset.nodeViewWrapper ? node : node.querySelector('[data-node-view-wrapper]')
if (nodeViewWrapper) {
node = nodeViewWrapper.firstChild as HTMLElement
}
if (node) {
return node.getBoundingClientRect()
}
} }
} }