mirror/tiptap
1
0
Fork 0
mirror of https://github.com/ueberdosis/tiptap.git synced 2024-12-15 11:09:01 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor src/Utils/ExtensionManager.js

Browse Source 
- remove duplication of logic
- reduce code lines to half (not entire module, but the part this refactor is applied to)
This commit is contained in:
GIL B. Chan 2019-05-08 07:27:05 +09:00
parent 364c744cef
commit 22100ff76a
1 changed files with 19 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
packages/tiptap/src/Utils/ExtensionManager.js
View File

@ -137,44 +137,28 @@ export default class ExtensionManager {
} : {},
})
if (Array.isArray(value)) {
commands[name] = attrs => value
.forEach(callback => {
if (!editable) {
return false
}
view.focus()
return callback(attrs)(view.state, view.dispatch, view)
})
} else if (typeof value === 'function') {
commands[name] = attrs => {
if (!editable) {
return false
}
view.focus()
return value(attrs)(view.state, view.dispatch, view)
const apply = (cb, attrs) => {
if (!editable) {
return false
}
} else if (typeof value === 'object') {
view.focus()
return cb(attrs)(view.state, view.dispatch, view)
}
const handle = (_name, _value) => {
if (Array.isArray(_value)) {
commands[_name] = attrs => _value.forEach(callback => apply(callback, attrs))
} else if (typeof _value === 'function') {
commands[_name] = attrs => apply(_value, attrs)
}
}
if (typeof value === 'object') {
Object.entries(value).forEach(([commandName, commandValue]) => {
if (Array.isArray(commandValue)) {
commands[commandName] = attrs => commandValue
.forEach(callback => {
if (!editable) {
return false
}
view.focus()
return callback(attrs)(view.state, view.dispatch, view)
})
} else {
commands[commandName] = attrs => {
if (!editable) {
return false
}
view.focus()
return commandValue(attrs)(view.state, view.dispatch, view)
}
}
handle(commandName, commandValue)
})
} else {
handle(name, value)
}
return {