mirror/tiptap
1
0
Fork 0
mirror of https://github.com/ueberdosis/tiptap.git synced 2025-01-24 02:23:18 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fix sending of emptystring class for Prosemirror decoration (#1004)

Browse Source 
Prosemirror does not handle emptystring classes well for decorations when the decoration applies to a range that has other decorations. For example, both a spellchecking plugin and the tiptap highlighting plugin.

Furthermore, there is no reason to emit empty decorations, so this change resolves that issue as well.
This commit is contained in:
Andrew Scott 2021-04-14 12:42:58 -07:00 committed by GitHub
parent d2cf88fd16
commit 2466d3398f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/tiptap-extensions/src/plugins/Highlight.js
View File

@ -47,6 +47,11 @@ function getDecorations({ doc, name }) {
} }
}) })
.forEach(node => { .forEach(node => {
if (node.classes.length === 0) {
// Do not emit empty decorations.
return
}
const decoration = Decoration.inline(node.from, node.to, { const decoration = Decoration.inline(node.from, node.to, {
class: node.classes.join(' '), class: node.classes.join(' '),
}) })