mirror/tiptap
1
0
Fork 0
mirror of https://github.com/ueberdosis/tiptap.git synced 2025-06-13 13:13:12 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(react): preserve editable option across renders

Browse Source
This commit is contained in:
Armando Guarino 2024-10-21 16:33:31 +02:00
parent ffb51d3b7e
commit 304eedb769
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/loud-maps-work.md Normal file
View File

@ -0,0 +1,5 @@
---
"@tiptap/react": patch
---
preserve editable option across re-renders #5547

5
packages/react/src/useEditor.ts
View File

@ -199,7 +199,10 @@ class EditorInstanceManager {
if (this.editor && !this.editor.isDestroyed && deps.length === 0) { if (this.editor && !this.editor.isDestroyed && deps.length === 0) {
// if the editor does exist & deps are empty, we don't need to re-initialize the editor // if the editor does exist & deps are empty, we don't need to re-initialize the editor
// we can fast-path to update the editor options on the existing instance // we can fast-path to update the editor options on the existing instance
this.editor.setOptions(this.options.current) this.editor.setOptions({
...this.options.current,
editable: this.editor.isEditable,
})
} else { } else {
// When the editor: // When the editor:
// - does not yet exist // - does not yet exist