Use correct reference for options.editorProps

This commit is contained in:
Robert van Hoesel 2021-07-04 19:37:29 +02:00
parent 9c64432fc8
commit 3aba2f6359
No known key found for this signature in database
GPG Key ID: 806FDCEBB51DF15E
2 changed files with 64 additions and 0 deletions

View File

@ -133,6 +133,12 @@ export class Editor extends EventEmitter {
*/
public setOptions(options: Partial<EditorOptions> = {}): void {
this.options = { ...this.options, ...options }
// Update editorProps directly on the view and store reference to configured props
if (this.view) {
if (options.editorProps) this.view.setProps(options.editorProps)
this.options.editorProps = this.view.props
}
}
/**
@ -251,6 +257,9 @@ export class Editor extends EventEmitter {
// So well have access to it for tests.
const dom = this.view.dom as HTMLElement
dom.editor = this
// Reference the resulting view props in our options
this.options.editorProps = this.view.props
}
/**

View File

@ -0,0 +1,55 @@
/// <reference types="cypress" />
import { Editor } from '@tiptap/core'
import Document from '@tiptap/extension-document'
import Paragraph from '@tiptap/extension-paragraph'
import Text from '@tiptap/extension-text'
describe('editorProps', () => {
it('editorProps can be set while constructing Editor', () => {
function transformPastedHTML(html: string) {
return html
}
const editor = new Editor({
extensions: [Document, Paragraph, Text],
editorProps: { transformPastedHTML },
})
expect(transformPastedHTML)
.to.eq(editor.options.editorProps.transformPastedHTML)
.and.to.eq(editor.options.editorProps.transformPastedHTML)
})
it('editorProps can be set through setOptions', () => {
function transformPastedHTML(html: string) {
return html
}
const editor = new Editor({
extensions: [Document, Paragraph, Text],
})
editor.setOptions({ editorProps: { transformPastedHTML } })
expect(transformPastedHTML)
.to.eq(editor.options.editorProps.transformPastedHTML)
.and.to.eq(editor.options.editorProps.transformPastedHTML)
})
it('editorProps can be set directly through options', () => {
function transformPastedHTML(html: string) {
return html
}
const editor = new Editor({
extensions: [Document, Paragraph, Text],
})
editor.options.editorProps.transformPastedHTML = transformPastedHTML
expect(transformPastedHTML)
.to.eq(editor.options.editorProps.transformPastedHTML)
.and.to.eq(editor.options.editorProps.transformPastedHTML)
})
})