mirror/tiptap
1
0
Fork 0
mirror of https://github.com/ueberdosis/tiptap.git synced 2025-06-08 01:53:04 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix(core): adjust the splitBlock to return false when failed (#5371)

Browse Source
This commit is contained in:
Markus Greystone 2024-07-22 09:10:29 -04:00 committed by GitHub
parent 2104f0fa70
commit 618bca91e8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 33 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/eleven-needles-argue.md Normal file
View File

@ -0,0 +1,5 @@
---
"@tiptap/core": patch
---
Adjust the `splitBlock` command to return `false` when it was unsuccessful.

56
packages/core/src/commands/splitBlock.ts
View File

@ -61,18 +61,30 @@ export const splitBlock: RawCommands['splitBlock'] = ({ keepMarks = true } = {})
return false return false
} }
if (dispatch) { const atEnd = $to.parentOffset === $to.parent.content.size
const atEnd = $to.parentOffset === $to.parent.content.size
if (selection instanceof TextSelection) { const deflt = $from.depth === 0
tr.deleteSelection() ? undefined
} : defaultBlockAt($from.node(-1).contentMatchAt($from.indexAfter(-1)))
const deflt = $from.depth === 0 let types = atEnd && deflt
? undefined ? [
: defaultBlockAt($from.node(-1).contentMatchAt($from.indexAfter(-1))) {
type: deflt,
attrs: newAttributes,
},
]
: undefined
let types = atEnd && deflt let can = canSplit(tr.doc, tr.mapping.map($from.pos), 1, types)
if (
!types
&& !can
&& canSplit(tr.doc, tr.mapping.map($from.pos), 1, deflt ? [{ type: deflt }] : undefined)
) {
can = true
types = deflt
? [ ? [
{ {
type: deflt, type: deflt,
@ -80,26 +92,14 @@ export const splitBlock: RawCommands['splitBlock'] = ({ keepMarks = true } = {})
}, },
] ]
: undefined : undefined
}
let can = canSplit(tr.doc, tr.mapping.map($from.pos), 1, types) if (dispatch) {
if (
!types
&& !can
&& canSplit(tr.doc, tr.mapping.map($from.pos), 1, deflt ? [{ type: deflt }] : undefined)
) {
can = true
types = deflt
? [
{
type: deflt,
attrs: newAttributes,
},
]
: undefined
}
if (can) { if (can) {
if (selection instanceof TextSelection) {
tr.deleteSelection()
}
tr.split(tr.mapping.map($from.pos), 1, types) tr.split(tr.mapping.map($from.pos), 1, types)
if (deflt && !atEnd && !$from.parentOffset && $from.parent.type !== deflt) { if (deflt && !atEnd && !$from.parentOffset && $from.parent.type !== deflt) {
@ -119,5 +119,5 @@ export const splitBlock: RawCommands['splitBlock'] = ({ keepMarks = true } = {})
tr.scrollIntoView() tr.scrollIntoView()
} }
return true return can
} }