mirror/tiptap
1
0
Fork 0
mirror of https://github.com/ueberdosis/tiptap.git synced 2025-06-07 09:25:29 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

fix(core): update the typing of addOptions, addStorage to have an optional parent #5768 (#5770)

Browse Source
This commit is contained in:
Nick Perez 2024-10-28 21:44:47 +01:00 committed by GitHub
parent cc4b82654a
commit d2f366d6d4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/happy-vans-smash.md Normal file
View File

@ -0,0 +1,5 @@
---
"@tiptap/core": patch
---
Updates the types of `addOptions` and `addStorage` to have the parent be possibly undefined which is the most accurate typing

4
packages/core/src/Extension.ts
View File

@ -61,7 +61,7 @@ declare module '@tiptap/core' {
*/ */
addOptions?: (this: { addOptions?: (this: {
name: string name: string
parent: Exclude<ParentConfig<ExtensionConfig<Options, Storage>>['addOptions'], undefined> parent: ParentConfig<ExtensionConfig<Options, Storage>>['addOptions']
}) => Options }) => Options
/** /**
@ -76,7 +76,7 @@ declare module '@tiptap/core' {
addStorage?: (this: { addStorage?: (this: {
name: string name: string
options: Options options: Options
parent: Exclude<ParentConfig<ExtensionConfig<Options, Storage>>['addStorage'], undefined> parent: ParentConfig<ExtensionConfig<Options, Storage>>['addStorage']
}) => Storage }) => Storage
/** /**

4
packages/core/src/Mark.ts
View File

@ -64,7 +64,7 @@ declare module '@tiptap/core' {
*/ */
addOptions?: (this: { addOptions?: (this: {
name: string name: string
parent: Exclude<ParentConfig<MarkConfig<Options, Storage>>['addOptions'], undefined> parent: ParentConfig<MarkConfig<Options, Storage>>['addOptions']
}) => Options }) => Options
/** /**
@ -79,7 +79,7 @@ declare module '@tiptap/core' {
addStorage?: (this: { addStorage?: (this: {
name: string name: string
options: Options options: Options
parent: Exclude<ParentConfig<MarkConfig<Options, Storage>>['addStorage'], undefined> parent: ParentConfig<MarkConfig<Options, Storage>>['addStorage']
}) => Storage }) => Storage
/** /**

4
packages/core/src/Node.ts
View File

@ -65,7 +65,7 @@ declare module '@tiptap/core' {
*/ */
addOptions?: (this: { addOptions?: (this: {
name: string name: string
parent: Exclude<ParentConfig<NodeConfig<Options, Storage>>['addOptions'], undefined> parent: ParentConfig<NodeConfig<Options, Storage>>['addOptions']
}) => Options }) => Options
/** /**
@ -80,7 +80,7 @@ declare module '@tiptap/core' {
addStorage?: (this: { addStorage?: (this: {
name: string name: string
options: Options options: Options
parent: Exclude<ParentConfig<NodeConfig<Options, Storage>>['addStorage'], undefined> parent: ParentConfig<NodeConfig<Options, Storage>>['addStorage']
}) => Storage }) => Storage
/** /**