mirror/tiptap
1
0
Fork 0
mirror of https://github.com/ueberdosis/tiptap.git synced 2025-06-12 12:43:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(react): reorder handleSelectionUpdate callback (#5982)
Some checks failed
build / lint (20) (push) Has been cancelled
Details
build / test (20, map[name:Demos/Examples spec:./demos/src/Examples/**/*.spec.{js,ts}]) (push) Has been cancelled
Details
build / test (20, map[name:Demos/Experiments spec:./demos/src/Experiments/**/*.spec.{js,ts}]) (push) Has been cancelled
Details
build / test (20, map[name:Demos/Extensions spec:./demos/src/Extensions/**/*.spec.{js,ts}]) (push) Has been cancelled
Details
build / test (20, map[name:Demos/GuideContent spec:./demos/src/GuideContent/**/*.spec.{js,ts}]) (push) Has been cancelled
Details
build / test (20, map[name:Demos/GuideGettingStarted spec:./demos/src/GuideGettingStarted/**/*.spec.{js,ts}]) (push) Has been cancelled
Details
build / test (20, map[name:Demos/Marks spec:./demos/src/Marks/**/*.spec.{js,ts}]) (push) Has been cancelled
Details
build / test (20, map[name:Demos/Nodes spec:./demos/src/Nodes/**/*.spec.{js,ts}]) (push) Has been cancelled
Details
build / test (20, map[name:Integration spec:./tests/cypress/integration/**/*.spec.{js,ts}]) (push) Has been cancelled
Details
Publish / Release (20) (push) Has been cancelled
Details
build / build (20) (push) Has been cancelled
Details

Browse Source
This commit is contained in:
rushillshah 2025-01-03 18:53:32 +05:30 committed by GitHub
parent 5370cbeab5
commit dac7fd2a0c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/early-parrots-carry.md Normal file
View File

@ -0,0 +1,5 @@
---
"@tiptap/react": patch
---
Resolves #5870 by re-ordering executation of selectionUpdate handler

2
packages/react/src/ReactNodeViewRenderer.tsx
View File

@ -141,7 +141,6 @@ export class ReactNodeView<
const { className = '' } = this.options
this.handleSelectionUpdate = this.handleSelectionUpdate.bind(this)
this.editor.on('selectionUpdate', this.handleSelectionUpdate)
this.renderer = new ReactRenderer(ReactNodeViewProvider, {
editor: this.editor,
@ -150,6 +149,7 @@ export class ReactNodeView<
className: `node-${this.node.type.name} ${className}`.trim(),
})
this.editor.on('selectionUpdate', this.handleSelectionUpdate)
this.updateElementAttributes()
}