From a7f4ee7dab205736bccc9d7541248882607b3c76 Mon Sep 17 00:00:00 2001 From: murata0705 Date: Fri, 5 Jul 2019 09:44:06 +0900 Subject: [PATCH 1/2] Add composing handler to Menu class --- packages/tiptap/src/Plugins/MenuBubble.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/tiptap/src/Plugins/MenuBubble.js b/packages/tiptap/src/Plugins/MenuBubble.js index 34b93166c..256f4faf5 100644 --- a/packages/tiptap/src/Plugins/MenuBubble.js +++ b/packages/tiptap/src/Plugins/MenuBubble.js @@ -85,6 +85,10 @@ class Menu { update(view, lastState) { const { state } = view + + if (view.composing) { + return + } // Don't do anything if the document/selection didn't change if (lastState && lastState.doc.eq(state.doc) && lastState.selection.eq(state.selection)) { From f527e8535dc6b05e6fc5249b67cdb7055fbf3697 Mon Sep 17 00:00:00 2001 From: murata0705 Date: Fri, 5 Jul 2019 10:16:28 +0900 Subject: [PATCH 2/2] fix lint error --- packages/tiptap/src/Plugins/MenuBubble.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tiptap/src/Plugins/MenuBubble.js b/packages/tiptap/src/Plugins/MenuBubble.js index 256f4faf5..2a43992bd 100644 --- a/packages/tiptap/src/Plugins/MenuBubble.js +++ b/packages/tiptap/src/Plugins/MenuBubble.js @@ -85,7 +85,7 @@ class Menu { update(view, lastState) { const { state } = view - + if (view.composing) { return }