mirror/tiptap
1
0
Fork 0
mirror of https://github.com/ueberdosis/tiptap.git synced 2025-06-07 17:43:49 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix: mark characterCount storage method types as optional

Browse Source
This commit is contained in:
Philipp Kühn 2021-12-10 17:41:36 +01:00
parent 914c75b305
commit ed7f93a2b8
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/extension-character-count/src/character-count.ts
View File

@ -17,7 +17,7 @@ export interface CharacterCountStorage {
/** /**
* Get the number of characters for the current document. * Get the number of characters for the current document.
*/ */
characters?: (options?: { characters: (options?: {
node?: ProseMirrorNode, node?: ProseMirrorNode,
mode?: 'textSize' | 'nodeSize', mode?: 'textSize' | 'nodeSize',
}) => number, }) => number,
@ -25,7 +25,7 @@ export interface CharacterCountStorage {
/** /**
* Get the number of words for the current document. * Get the number of words for the current document.
*/ */
words?: (options?: { words: (options?: {
node?: ProseMirrorNode, node?: ProseMirrorNode,
}) => number, }) => number,
} }
@ -42,8 +42,8 @@ export const CharacterCount = Extension.create<CharacterCountOptions, CharacterC
addStorage() { addStorage() {
return { return {
characters: undefined, characters: () => 0,
words: undefined, words: () => 0,
} }
}, },
@ -84,8 +84,8 @@ export const CharacterCount = Extension.create<CharacterCountOptions, CharacterC
return true return true
} }
const oldSize = this.storage.characters?.({ node: state.doc }) || 0 const oldSize = this.storage.characters({ node: state.doc })
const newSize = this.storage.characters?.({ node: transaction.doc }) || 0 const newSize = this.storage.characters({ node: transaction.doc })
// Everything is in the limit. Good. // Everything is in the limit. Good.
if (newSize <= limit) { if (newSize <= limit) {
@ -123,7 +123,7 @@ export const CharacterCount = Extension.create<CharacterCountOptions, CharacterC
// This happens e.g. when truncating within a complex node (e.g. table) // This happens e.g. when truncating within a complex node (e.g. table)
// and ProseMirror has to close this node again. // and ProseMirror has to close this node again.
// If this is the case, we prevent the transaction completely. // If this is the case, we prevent the transaction completely.
const updatedSize = this.storage.characters?.({ node: transaction.doc }) || 0 const updatedSize = this.storage.characters({ node: transaction.doc })
if (updatedSize > limit) { if (updatedSize > limit) {
return false return false