Commit Graph

110 Commits

Author SHA1 Message Date
Matt Gorman
9a0af5dfeb
fix(link): fixes links with marks (#6078)
* fixes links with marks

* Create popular-geckos-pay.md

* Update clickHandler.ts

---------

Co-authored-by: bdbch <6538827+bdbch@users.noreply.github.com>
2025-03-31 02:14:58 +02:00
Timo Isik
0b927e0e41 fix(extension-link): update regex to allow numbers in URI 2025-01-29 15:37:48 +01:00
guanriyue
0e91b1c3af
fix(extension-link): fixes #5994 where link cannot be pasted in some scenarios (#6010)
Co-authored-by: cool-zero <37545916+cool-zero@users.noreply.github.com>
2025-01-09 16:03:38 +01:00
bdbch
1c2fefe3d6
Fixed Link extension's commands not respecting XSS prevention via unallowed protocols (#5945)
* fixed link commands not respecting allowed protocols

* added changesets

* refactor(link): don't use throw for invalid uri handling
2024-12-19 12:16:03 +01:00
鸿则
ccd014728a fix(link): change type HTMLLinkElement to HTMLAnchorElement (#5858) 2024-11-26 17:47:53 +01:00
Nick Perez
62c6dddf80
fix(link): add backwards compat by deprecating validate and using isAllowedUri instead (#5812) 2024-11-07 13:18:01 +01:00
Armando Guarino
6b8ce3778e refactor: add jsdoc validate and shouldAutoLink comment 2024-11-06 14:14:59 +01:00
Armando Guarino
035862b698 refactor: update tests url checking logic and comments 2024-11-06 14:11:48 +01:00
Armando Guarino
6bdb5917a5 refactor: remove logs and fix typo 2024-11-06 14:06:48 +01:00
Armando Guarino
444e6e5a11 refactor: adjust validate and add shouldAutoLink to improve URL handling 2024-11-06 13:43:54 +01:00
Nick Perez
593f1070a8
fix(link): respect custom protocols #5468 (#5470)
When [we fixed a XSS vuln](https://github.com/ueberdosis/tiptap/pull/5160), we inadvertently broke the ability to use custom protocols, this resolves that by allowing additional custom protocols to be considered valid and not stripped out
2024-08-15 08:57:59 +02:00
Stepan Yurtsiv
08b4319215
fix(link): Do not convert link href to number or boolean (#5391) 2024-08-11 19:48:54 +02:00
Nick the Sick
9e0e167885
fix(link): use the view's editable property as the indicator instead 2024-07-23 12:21:18 +02:00
Nick Perez
c0e5398685
fix(link): do not open links twice when not editable #4877 (#5378) 2024-07-23 10:57:15 +02:00
Nick the Sick
a2cce1f486
fix: backwards compat for whenNotEditable openOnClick option 2024-07-17 12:56:08 +02:00
Nick Perez
a95ba3fa6f
fix(extension-link): make links exitable resolving #3293 (#5181) 2024-06-07 16:38:54 +02:00
Henry Stelle
ff6e00a356
feat(extension-link): add support for default protocol (#5022) 2024-06-07 16:37:48 +02:00
Benjamin Kroeger
ef635db6c0
revert: remove 'whenNotEditable' as option for openOnClick" (#5040)
This reverts commit 0f41e389b3.

Co-authored-by: Nick Perez <nicholas.perez@tiptap.dev>
2024-05-24 16:58:58 +02:00
Nantris
e95140c889
fix: validate pasted links (#5061) 2024-05-24 14:02:37 +02:00
Nick the Sick
738c436a9f
fix: disable parsing javascript: links, add tests 2024-05-16 17:10:15 +02:00
Christofer Roth
980b54f62b fix(extension-link): use whitelist for allowed href values 2024-05-16 09:05:42 +02:00
bdbch
b941eea6da
feat: added jsdocs (#4356)
* added JSDocs for almost all extensions

* start adding commands jsdocs

* add jsdocs for rest of extensions

* add jsdocs for Extensions

* add js docs for all extensions

* add more jsdocs

* add js docs for node spec definitions
2024-05-11 14:30:44 +02:00
Benjamin Kroeger
0f41e389b3
extension/link: adds 'whenNotEditable' as option for openOnClick (#3312)
* checks whenNotEditable condition in clickHandler

* passes whenNotEditable option from to helper

* adds docs for whenNotEditable

* adds  to ClickHandlerOptions type
2024-04-08 13:21:10 +02:00
Ricardo Amaral
4474d056da
fix(extension-link): Avoid auto-linking partial text for invalid TLDs (#4865) 2024-03-28 22:00:24 +01:00
Dominik Biedebach
e8cfe043b7 fix links not being pasted correctly 2024-02-15 16:40:57 +01:00
Dominik Biedebach
8c99685545 sync with main 2024-01-08 12:54:37 +01:00
bdbch
eaee9c7177
Fix/link pasting (#4700)
* revert link paste handling to behavior before

* fix(link): fix linking while typing

* add validate support for autolinking back

* revert autolink behaviour

* fix autolinking on pasting text

* remove broken link

* fix react link test

* fix savvy test

---------

Co-authored-by: bdbch <dominik@bdbch.com>
2024-01-08 12:48:14 +01:00
Dominik Biedebach
2bb371126e merge main 2023-11-23 09:28:26 +01:00
Jakub Kolčář
ef10ae53b2
Revert "autolink improvement"
This reverts commit 9a9e94b4cb.
2023-11-20 21:13:41 +01:00
Jakub Kolčář
82f16d2d91
link click handler fixed 2023-11-20 21:13:40 +01:00
Jakub Kolčář
d9cdf1e1c1
autolink improvement 2023-11-20 21:12:57 +01:00
Cameron Hessler
7debf2baf0 fix(extension-youtube) Add fix for link too 2023-11-20 18:48:22 +01:00
Dominik Biedebach
c1d0f30f47 fix clipboard is undefined issue 2023-10-11 17:22:26 +02:00
bdbch
1a7b4280d2
fix(link): restore pasteHandler and add existing url check (#4523)
* fix(link): restore pasteHandler and add existing url check

* make pasteEvent optional
2023-10-11 15:54:14 +02:00
bdbch
361a821245
feature(core): pass through paste event to pasteHandler getAttributes (#4354)
* add pass through of paste event for paste handlers

* remove unused pasteHandler.ts

* remove link extension from youtube demo

* added missing prop for handler
2023-09-20 17:23:43 +02:00
Manueljlin
74b6444388 fix: add missing attributes in extension-link (#4429)
Despite `rel` and `class` already being defined as an attribute in `addAttributes()`, the interface was missing these two particular attributes so it wasn't accessible when using TypeScript without workarounds.
2023-09-14 17:09:55 +02:00
Aldin Nezirić
73202a0afb
prevent opening link when clicking on selection containing a link (#4346)
* prevent opening link when clicking on selection containing a link

* Fix lint err
2023-09-04 21:38:11 +02:00
Dominik Biedebach
5686dfa86b style(link): fix linting 2023-08-18 08:54:22 -07:00
Steven Qi
f2ac7b9091
fix: fix autolink when code is not enabled for editor (#4344) 2023-08-17 23:28:16 -07:00
bdbch
a2ce734d68
fix(link): Fix autolinking and pasting (#4292)
* fix linkOnPaste
* fix link on paste breaking links / link behavior
2023-08-10 16:44:31 -07:00
Abdullah Atta
4bca77e4e9
fix: do not use window.open for links in readonly mode (#4073)
* fix: do not use window.open for links in readonly mode

When `contenteditable` is `true`, the browser doesn't allow
direct link opens on clicking the `a` element. This is why we
need to call `window.open` to open our links.

However, when `contenteditable` is `false`, the default
browser mechanism for opening links works and there is no
need for using `window.open`.

* fix: linting errors
2023-07-07 15:31:41 +02:00
joenarus
3053865475
fix(extension-link): fixes link going to wrong url (#4078)
Co-authored-by: Joe Narus <joe@status.cx>
2023-07-07 15:30:13 +02:00
Thomas Portelange
193b991acc
Rel cannot be set (#4112)
Without the addAttributes entry, passing the rel attribute doesn't work (tested in 2.0.3)
2023-07-07 15:18:02 +02:00
Ricardo Amaral
b24df3aa4c
fix(link): Prevent auto-linking when typing URL inside inline code mark (#4160) 2023-07-07 11:05:34 +02:00
Ben Asher
e97630c639
Require file extensions for imports and exports (#4001)
* Require .js endings

* add extension alias for cypress to resolve ts files with js endings
2023-06-30 21:03:49 +02:00
Sven Adlung
d19267ecef
fix(extension-link): fix paste handling
* do not dispatch transaction without any links getting pasted
* prevent onPaste handling in code blocks
2023-05-25 13:47:27 +02:00
Dominik
71946c18ac
fix(link): fix links autolinking when not needed (#3989) 2023-04-27 12:02:56 +02:00
Dominik
e7d7d49637
fix(extension-link): fix link not being kept when pasting url with link (#3975)
* fix(extension-link): fix llinks not being kept when pasted text includes url

* fix(extension-link): fix links not being linked correctly on the correct pos

* fix(link): fix pasting behavior and move all to one plugin

* fix(link): dont do custom behavior if no links were pasted

* fix(link): copied text link should be kept

* fix(link): fix autolink overriding pasted links

* fix(link): fix links not pasting the correct link on selected text
2023-04-26 14:17:59 +02:00
jhsy
98144a86c8
Update clickHandler.ts (#3917)
Fix left click invalid
2023-03-30 12:38:56 +02:00
Abdullah Atta
dd3c7618ac
Only allow left mouse button to open links (#3777)
* Only allow left mouse button to open links

* fix lint errors
2023-03-02 17:00:23 +01:00