Commit Graph

86 Commits

Author SHA1 Message Date
Shaun Tan
8a5b3cf67a
Prevent overriding 'whiteSpace' styling for NodeView React components (#2884)
Fixes ueberdosis/tiptap#2883
2022-06-20 19:41:33 +02:00
Dominik
1ebc8f8e14
chore: migrate to new versions of prosemirror packages (#2854)
* refactor: upgrade prosemirror packages to new typescript versions

* refactor: migrate to new typings from prosemirror

* style: fix linting issues

* style: fix linting issues

* style: fix linting issues

* fix(ci): fix build process by reimplement filterTransaction

* fix(extension-test): fix broken build because of wrong output file names

* fix: fix prosemirror-tables not being bundled correctly for ES6

* fix: move to prosemirror-tables-contently until es6 build is working

* fix: fix tests for youtube

* fix: fix youtube test

* fix(demos): fix demos build
2022-06-20 11:45:37 +02:00
Dominik
8c6751f0c6
add precommit hook for linting and automatic eslint fixes + update eslint packages (#2862)
* chore: add precommit hook for eslint fixes, fix linting issues
* chore: add eslint import sort plugin
2022-06-08 14:10:25 +02:00
Anton Liubushkin
d84ce08dcf Update ReactNodeViewRenderer.tsx
remove trailing spaces
2022-05-20 13:33:17 +02:00
Anton Liubushkin
21913445bc Update ReactNodeViewRenderer.tsx 2022-05-20 13:33:17 +02:00
Anton Liubushkin
00cd74e2c6 Add className option and pass through to ReactRenderer 2022-05-20 13:33:17 +02:00
Dany Castillo
a6fd827d31 fix children property not being defined in React.FC type 2022-04-14 00:18:29 +02:00
philippkuehn
7160b19c73 ci: fix code style linting errors 2022-01-03 13:29:53 +00:00
Luke Murray
64dfae8511
fix: change reactrenderer component type definition (#2327) 2022-01-03 14:28:31 +01:00
Tomas Valenta
561941d5e0
fix: Remove element.current from useEffect in BubbleMenu and FloatingMenu (#2297)
* Remove `element.current` from `useEffect` dependencies

Changes to the `element.current` don't trigger `useEffect` rerender and shouldn't be used in the dependency array.
One discussion about is this is for example here: https://stackoverflow.com/questions/60476155/is-it-safe-to-use-ref-current-as-useeffects-dependency-when-ref-points-to-a-dom

It's also causing some subtle bugs when mounting and unmounting editors.

* Fix `FloatingMenu` and `BubbleMenu` element references

* Fix linting errors

* Don't register plugin when the editor is already destroyed; Simplify `HTMLElement` reference handling

* Fix lint error
2021-12-22 12:13:36 +01:00
Philipp Kühn
40a9404c94 add newline-after-var rule to eslint config 2021-12-03 00:03:39 +01:00
Jessica Chong
dedcf17d53
feat: Add as option and pass through to ReactRenderer (#2213)
* Add `as` option and pass through to ReactRenderer

* Fix type, oops

* type `as` as string
2021-12-02 14:13:03 +01:00
Philipp Kühn
c9dc1e1ec3 feat: add className option to ReactRenderer, see #2166 2021-11-18 09:58:38 +01:00
Jon Noronha
ddc9ca8d4f
fix: Check node type above custom update function for node views (#2081) 2021-10-25 09:52:34 +02:00
Philipp Kühn
7ffabf251c
feat: Add extension storage (#2069) 2021-10-22 08:52:54 +02:00
Philipp Kühn
2d0e6d02d1 refactoring 2021-10-12 11:38:01 +02:00
Tomas Valenta
e9465ec0f6
fix: Add editor dependency when registering BubbleMenuPlugin and FloatingMenuPlugin (#2018)
* Add `editor` dependency when registering `BubbleMenuPlugin`

When we are initializing editor via the `useEditor` hook with dependencies the `BubbleMenu` component is only registered the first time the editor is initialized.

Adding editor to the dependency array registering/unregistering the `BubbleMenuPlugin` fixes this. (I tested exactly this code in our project.)

I also added a check that ensures that the menu element referenced via the `useRef` is defined when registering the plugin - otherwise, there is no point in registering the plugin.

* Add `editor` dependency when registering `FloatingMenuPlugin`
2021-10-12 11:09:00 +02:00
Ricardo Amaral
31d8ab3593
fix: Improve ReactRenderer types (#2011) 2021-10-11 20:37:35 +02:00
Philipp Kühn
2af187023d fix: fix editor type for ReactRenderer 2021-10-11 08:45:46 +02:00
Philipp Kühn
dead826250
fix: use ref to move contentDOM (#1960), fix #1942 2021-09-30 21:13:37 +02:00
Philipp Kühn
fe47c388ce fix: set correct component type for ReactRenderer, fix #1904 2021-09-18 20:45:00 +02:00
Philipp Kühn
b06a1f4364 refactoring 2021-09-07 23:20:46 +02:00
castroCrea
d1f2ad293f
feat: add support for forwardRef component in reactRenderer (#1690, fix #1040) 2021-09-07 23:13:39 +02:00
Philipp Kühn
b15a8a8683 fix: fix a bug when using nested node views in react, fix #1747 2021-08-24 22:13:18 +02:00
Philipp Kühn
70a328bd3d fix: make shouldShow and pluginKey option for menus, fix #1779 2021-08-23 18:44:40 +02:00
Philipp Kühn
89d26f7cba fix: rename key to pluginKey for menus 2021-08-13 12:33:06 +02:00
Philipp Kühn
956566eaad
fix: fix some react focus issues (#1724), fix #1716, fix #1608, fix #1520
* remove async createNodeViews

* focus asynchronously to fix weird bugs in react
2021-08-12 18:03:45 +02:00
Philipp Kühn
9ba61c1582
feat: add key option and shouldShow option to menus (fix #1480, fix #1043, fix #1268, fix #1503)
* add key option to bubble menu

* ignore react for now

* add shouldShow option to bubble menu extension

* improve types

* remove BubbleMenuPluginKey

* add key and shouldShow option to floating menu extension

* fix: don’t show floating menu within code block

* docs: add new menu options
2021-08-11 14:37:58 +02:00
Philipp Kühn
6ef931f85d fix another bug for updating node views 2021-07-28 14:51:58 +02:00
Philipp Kühn
d7f6e0ce3f fix: fix updating node views, fix #1656 2021-07-28 14:49:00 +02:00
Philipp Kühn
d720edbe24
feat!: provide more context to update function of node views, fix #1611
* add more powerful update option to node views

* add object params for all node view option props
2021-07-27 12:26:24 +02:00
Philipp Kühn
651e6911e3 feat: add ignoreMutation option to NodeViewRenderer, fix #1538 2021-07-26 18:44:02 +02:00
Philipp Kühn
44e47222a0 fix: check for destroyed editor before creating node views in react 2021-06-24 19:59:06 +02:00
Philipp Kühn
a3a847f711 code style 2021-06-14 16:06:49 +02:00
philippkuehn
15edaf0561 ci: fix code style linting errors 2021-06-14 14:03:29 +00:00
Yousef
df8310407d
Update NodeViewWrapper.tsx 2021-06-11 08:33:35 +02:00
Yousef
cc6bc0fa40
Update NodeViewContent.tsx 2021-06-11 08:33:22 +02:00
Yousef
deb79ea729
NodeViewContent forwardRef 2021-06-11 08:06:44 +02:00
Yousef
83525ec4f1
NodeViewWrapper forwardRef 2021-06-11 08:04:53 +02:00
Philipp Kühn
78f75c3e0e fix: maybe move content dom on update, fix #1370 2021-05-29 20:12:21 +02:00
Philipp Kühn
60708a7817 fix: maybe move content dom on update, see #1370 2021-05-28 15:00:51 +02:00
Yousef
bdd6e2b87c
Allow passing of DependencyList to useEditor
in case the options depend on props of the consuming component, it would be nice to be able to pass a dependencylist to `useEditor`. Unless there's a better way to handle dependency updates
2021-05-25 14:51:36 +02:00
Philipp Kühn
fcee5f82c6 feat: add deleteNode method to node views 2021-05-19 00:03:41 +02:00
Philipp Kühn
0f299d228e fix: move all child nodes within EditorContent 2021-05-18 23:41:54 +02:00
Philipp Kühn
8979143c37 fix: add prop support for EditorContent, fix #1332 2021-05-18 15:09:15 +02:00
Philipp Kühn
cfb3b80f63 fix: allow passing props to NodeViewWrapper and NodeViewContent 2021-04-23 23:38:38 +02:00
Philipp Kühn
e885ffa15b fix: prevents a bug where a line break was incorrectly added at enter in react node views, fix #1197 2021-04-22 14:23:48 +02:00
Philipp Kühn
1c8ca95de2 refactor: remove AnyObject type 2021-04-21 09:43:31 +02:00
Philipp Kühn
9a56f666a1 feat: add tippyOptions prop 2021-04-16 12:42:56 +02:00
Philipp Kühn
d7282f168b feat: remove keepInBounds 2021-04-16 10:46:50 +02:00