mirror of
https://github.com/microsoft/vcpkg.git
synced 2024-11-28 02:29:01 +08:00
[vcpkg ci] Ask for adding a license field (#20790)
* [vcpkg ci] Ask for adding a license field
* Apply suggestions from code review
* try out license field thing
* fix two newlines after </details>
* add more newlines
* Revert "try out license field thing"
This reverts commit 3ab82662ae
.
Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
This commit is contained in:
parent
bc4b12f517
commit
ee3cd46dca
13
.github/workflows/untrustedPR.yml
vendored
13
.github/workflows/untrustedPR.yml
vendored
@ -39,6 +39,7 @@ jobs:
|
||||
git config user.name github-actions@github.com
|
||||
|
||||
git diff --name-status --merge-base HEAD^ HEAD --diff-filter=MAR -- '*portfile.cmake' | sed 's/[MAR]\t*//' | while read filename; do grep -q -E '(vcpkg_install_cmake|vcpkg_build_cmake|vcpkg_configure_cmake|vcpkg_fixup_cmake_targets)' "$filename" && echo " - \`$filename\`" || true; done > .github-pr.deprecated-cmake
|
||||
git diff --name-status --merge-base HEAD^ HEAD --diff-filter=MAR -- '*vcpkg.json' | sed 's/[MAR]\t*//' | while read filename; do grep -q -E '"license": ' "$filename" || echo " - \`$filename\`" || true; done > .github-pr.missing-license
|
||||
./vcpkg format-manifest --all --convert-control
|
||||
git diff > .github-pr.format-manifest
|
||||
git add -u
|
||||
@ -58,6 +59,7 @@ jobs:
|
||||
const add_version_out = (await fs.readFile('.github-pr.x-add-version.out', 'utf8')).trim()
|
||||
const format = (await fs.readFile('.github-pr.format-manifest', 'utf8')).trim()
|
||||
const cmake = (await fs.readFile('.github-pr.deprecated-cmake', 'utf8')).trim()
|
||||
const missing_license = (await fs.readFile('.github-pr.missing-license', 'utf8')).trim()
|
||||
|
||||
let approve = true;
|
||||
var output = ''
|
||||
@ -72,7 +74,7 @@ jobs:
|
||||
if (add_version_out !== "") {
|
||||
output += "<details><summary><b>PRs must add only one version and must not modify any published versions</b></summary>\n\n"
|
||||
output += "When making any changes to a library, the version or port-version in `vcpkg.json` or `CONTROL` must be modified.\n"
|
||||
output += "```\n" + add_version_out + "\n```\n</details>\n"
|
||||
output += "```\n" + add_version_out + "\n```\n</details>\n\n"
|
||||
approve = false;
|
||||
}
|
||||
if (add_version !== "") {
|
||||
@ -102,7 +104,14 @@ jobs:
|
||||
output += '{\n "name": "vcpkg-cmake-config",\n "host": true\n}\n'
|
||||
output += "```\n"
|
||||
output += `The following files are affected:\n${cmake}\n`
|
||||
output += "</details>\n"
|
||||
output += "</details>\n\n"
|
||||
}
|
||||
if (missing_license !== "") {
|
||||
output += 'You have modified or added at least one vcpkg.json where a "license" field is missing.\n'
|
||||
output += 'If you feel able to do so, please consider adding a "license" field to the following files:\n'
|
||||
|
||||
output += missing_license
|
||||
output += "\n\nValid values for the license field are listed at <https://spdx.org/licenses/>\n\n"
|
||||
}
|
||||
|
||||
if (approve) {
|
||||
|
Loading…
Reference in New Issue
Block a user