If a call to `vcpkg_replace_string` makes no changes i.e doesn't
effectively replace a string, A warning is logged.
This should also help identify ports that no longer need these calls to
fix things in `.pc` files etc.
Given the following manifest (when `dnn` feature is not included):
```json
"dependencies": [
{
"name": "opencv4",
"version>=": "4.8.0#18",
"default-features": false,
"features": [
"png"
]
}
]
```
it failed and here is what
`vcpkg/buildtrees/opencv4/config-x64-linux-out.log` said:
```
...
CMake Error at /home/peter/open-source/git/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package):
Could not find a package configuration file provided by "flatbuffers" with
any of the following names:
flatbuffersConfig.cmake
flatbuffers-config.cmake
Add the installation prefix of "flatbuffers" to CMAKE_PREFIX_PATH or set
"flatbuffers_DIR" to a directory containing one of the above files. If
"flatbuffers" provides a separate development package or SDK, be sure it
has been installed.
Call Stack (most recent call first):
CMakeLists.txt:759 (find_package)
...
```
This problem is introduced by [commit
6d2c9714](6d2c971458)
contributed by @jimwang118
In the patch `vcpkg/ports/opencv4/0023-fix-no-flatbuffers.patch`, Jim
disabled the procedure of `Flatbuffers` detection introduced by the
previous patch `0017-fix-flatbuffers.patch`, which has correctly fixed
the `flatbuffers`-related issues.
```patch
...
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -756,7 +756,7 @@ include(cmake/OpenCVFindLibsVideo.cmake)
include(cmake/OpenCVFindLibsPerf.cmake)
include(cmake/OpenCVFindLAPACK.cmake)
include(cmake/OpenCVFindProtobuf.cmake)
-include(cmake/OpenCVDetectFlatbuffers.cmake)
+find_package(flatbuffers CONFIG REQUIRED)
...
```
In `vcpkg/ports/opencv4/vcpkg.json` we can see, `flatbuffers` is only
the dependency of feature `dnn`:
```json
"dependencies": [
...
"dnn": {
"description": "Enable dnn module",
"dependencies": [
"flatbuffers",
{
"name": "flatbuffers",
"host": true,
"default-features": false
},
"protobuf"
]
},
...
```
and when `dnn` is not enabled, it broke down at the line
`find_package(flatbuffers CONFIG REQUIRED)`
And this change is unnecessary either:
```patch
- list(APPEND libs ocv.3rdparty.flatbuffers)
+ list(APPEND libs flatbuffers::flatbuffers)
```
Thus, we'd better to revert those changes.
Co-authored-by: WentsingNee <8090395+wentsingnee@user.noreply.gitee.com>
Fixes https://github.com/microsoft/vcpkg/issues/38009
Remove the statement renaming liblapack.lib.
- [X] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~~SHA512s are updated for each updated download.~~
- [ ] ~~The "supports" clause reflects platforms that may be fixed by
this new version.~~
- [ ] ~~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~~
- [ ] ~~Any patches that are no longer applied are deleted from the
port's directory.~~
- [X] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [X] Only one version is added to each modified port's versions file.
Usage test pass with following triplets:
```
x64-windows
```
---------
Co-authored-by: Jim wang (BEYONDSOFT CONSULTING INC) <v-wangjim@microsoft.com>
* Switch stuff to Qt6
* give opencv4 the correct deps
* add Qt5Compat to find_dependency
* refine vtk deps and promote targets to global
* fix dep
* ci is probably faster than my desktop pc building.
* remove invalid patch part
* add qt6 patch
* second patch
* make openimageio ignore qt5
* [skip actions] qt6 part 3
* vtk qt6 patch
* try openimageio again
* move gl include
* fix patch
* does it work now?
* remove qualified name
* more qt6 fixes
* more patches
* update and fix rtabmap
* gles feature in qtbase needs to be disabled for vtk since vtk assumes desktop opengl
* remove patch add error if qtbase was build with gles2
* disable also second patch
* fix theia
* paraview consolidate patches
* fix case issue
* fix missing ,
* add more qt6 changes
* remove unnecessary patches
* bump port version
* remove comments from vtk
* add platform features for tools.
* fix format
* bump ports
* another one to bump
* v db
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
* [cgns] update to 4.2.0
* [vtk-m] update to 1.6.0
* [vtk] Update to 9.0.1-pv5.9.1
- VTK update to match release version of ParaView
* [ParaView] Update to 5.9.1
* version stuff
* fix automatic svg linkage in static builds
* update qt5-svg
* revisit vtk
- fix build with vtk-m 1.6
- remove unused patches
- remove comments
* bump version
* remove two commented lines
* version stuff
* remove old PR version
* commit stuff
* commit stuff
* update notes
* wip commit
* update paraview
* fix hdf5 patch
* fix patch
* fix patch
* fix portfile
* add mpi feature
* format manifest
* use relativ path
* trace
* retry
* move qml files again
* try with host triplet
* - use VCPKG_CRT_LINKAGE
- use METIS not metis
* fix casing Zlib
* hopefully more fixes on other platforms.
* fix patch
* fix missing ws
* fix typos
* scale down to warning
* revert jsoncpp change
fix zoltan on osx?
* move trace option to failing port
* move trace option to failing port
* Revert "trilinos vcpkg.json changes"
* verdict fix osx build ?
* fix patch
* fix internal find_package call
* also apply correct case for metis
* disable METIS on osx
* vtk-m don't support arm.
* force more features in Ci
* fix missing ,
* more fixes
* more vtk python try and error.
* - paraview python setup same as vtk
- remove openvr from platforms not supporting it
- trace openimageio
* fix case and remove fmt for openimageio.
* trying to fix stuff
* set hash to 0
* [skip actions] add missing module
* WebCore module moved to paraview&python
* fixes
* remove patch in vtk-dicom
* add var to maybe unused
* use correct 5.11 ref instead of the one in release
* Patch cleanup round 1
* remove empty patch parts
* fix vtkm configs
* reintegrate jsoncpp.patch
* fix patch
* add single seacas/kokkos/zoltan ports
* throw out trilinos, zoltan, kokkos
replace trilinos with seacas
make seacas work for dynamic windows
* fix mpi feature
* fix dependency
* retry dep fix
* rename target
* remove double line
* fix target
* fix patch
* retry
* remove cgns config
* fix cgns
* no seacas trace
* lowercase hdf5 target
* fix case of metis
* disable Fortran
* add iotr patch
* add additional config folder
* handel case sensitive Seacas again
* get trace again and force jsoncpp
* update cmake to 3.25.0
* bump port-version
* add patch from vtk upstream
* cleanup, format-manifest
* fix port version
* v db
* opencv4 always inject deps.
* fix test port to not require stuff which is not supported on x86
* Fix HDF5 lookup in opencv4
* only delete bin folder in static builds
* add license field
* v db
* add missing "
* v db
* trace again
* fix rtabmap python dep
* fix openimageio by deleting the find module
* v db
* cr cleanup
* v db
* opencv4 v db due to merge with master. Had to bump port version
* v db
* v db
* v db
* CR comments
* v db for cr comments
* trace theia output
* revert theia trace
* v db
* try without patch
* revert rtabmap changes
* v db after merge
* v db for all
* Update to 3.1.5
* Add feature 'tools'
* ilmbase is now imath
* [theia] Use openimageio cmake config
* [freeimage] Use OpenEXR 3 and Imath
* [opencv4] Use upstream's OpenEXR 3 support
* [opencv3] Use upstream's OpenEXR 3 support
* [opencv2] Use OpenEXR 3 and Imath
* [osg] Use OpenEXR 3
* [openvdb] Use Imath, enable OpenEXR
* [pangolin] Use OpenEXR 3
* [directxtex] Use OpenEXR 3
* [uvatlas] Disable /guard:ehcont when directxtex uses openexr
* Update versions
Co-authored-by: chausner <chausner@users.noreply.github.com>
* [tesseract] update to 5.2.0
* x-add-version
* fix windows build error
* version
* fix opencv4 build error
* version
* conflict
* version
* fix opencv build error on uwp
* version
* fix linux build error
* version
* fix
* version
* version
* [opencv4] Fix import paths for debug Android builds
* [opencv3] Fix import paths for debug Android builds in the same way as v4
* Only apply changes to OpenCVModules-debug.cmake when it is expected to exist
* add upstream patch
* [skip actions] add the patch file
* fine tune
* [opencv] update portfiles to use vcpkg-get-python-packages
* fix references
* try another fix
* add all deps
* add code from tensorflow about venv
* retry
* fix file path
* new approach
* unset pythonhome
* next unset
* try this instead.
* retry without the PYTHON_LIB_PATH stuff
* try and error
* next try
* retry
* typo fix
* try updating
* retry
* more try and error
* reorder
* drop qface version
* use qface 2.0.5
* bump watchdog
* fix call on !windows
* fine tuning
* refactor function signature
* update version
* fix formating
* version stuff
* create dir before usage
* fine tuning
* version stuff
* update and patch libilbc
* formating stuff
* fix version-string
* version stuff
* add license
* version update
* bump version
* version stuff
* version stuff
Co-authored-by: Alexander Neumann <you@example.com>
Co-authored-by: Stefano Sinigardi <stesinigardi@hotmail.com>
* [llvm] update to 13.0.0
* add version
* [llvm] rework processing of the CMake packages
* update versions
* [llvm] return patch to fix config paths
* update version
* [llvm] allow to build Flang on Windows
* add version
* [llvm] temporary enable Flang by default for test
* update version
* [llvm] fix Flang installation
* update version
* [llvm] try to fix Flang build
* update version
* [llvm] remove Flang from defaults and use Perl path
* [halide] update to 13.0.0
* update versions
* [mesa] update to v21.2.5 and fix build with LLVM 13
* [llvm] use version
* update versions
* [opencv4] fix build with Halide 13
* update version
* update ci.baseline
* [halide] update usage file
* [llvm] update supports
* update versions
* [vcpkg-ci-llvm] add test port
* [vcpkg-ci-llvm] rework test port
* [vcpkg-ci-llvm] test more features
* [halide] update to v13.0.1
* update version
* [mesa] recover port version
* update versions
* [opencv4] update version
* update version
* Update opencv4.json
* [halide] update to v13.0.2 and fix usage
* update version
* Update ports/halide/portfile.cmake
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
* update version
* enable LLVM ABI breaking checks to avoid Halide build fail
Co-authored-by: Phoebe <20694052+PhoebeHui@users.noreply.github.com>
* [protobuf] upgrade to latest release (v3.18.0)
This requires patching OpenCV as it uses a function removed in the
latest version of protobuf (FWIW, upstream OpenCV has a similar patch).
* The arcus port also needs a patch
* The caffe2 port also needs a patch
* The brpc port also needs a patch
