Commit Graph

1 Commits

Author SHA1 Message Date
Cheney Wang
8c228c8eca
[arrow/concurrencpp/qtwebengine] Fix error C2039: 'string': is not a member of 'std' (#39160)
In an internal version of Visual Studio, `arrow`, `concurrencpp` and
`qtwebengine` install failed with following error:
```
arrow:        \cpp\src\arrow/json/object_writer.h(39): error C2039: 'string': is not a member of 'std'
concurrencpp: \include\concurrencpp/threads/thread.h(23): error C2039: 'string': is not a member of 'std'
qtwebengine:  \src\3rdparty\gn\src\gn\escape.h(77): error C2039: 'string': is not a member of 'std'
```
This issue caused by the STL PR:
https://github.com/microsoft/STL/pull/4633, and according to Stephan's
suggestion, the affected files need to include the `Standard <string>
header`.

I have submitted an issue on the qt upstream:
https://bugreports.qt.io/browse/QTBUG-126156
2024-06-10 16:46:17 -07:00