* Audit use of TO_NATIVE_PATH.
TO_NATIVE_PATH should only be used when (1) pasting a path into a command line, or (2) displaying a path to a user. It must not be used before calling other CMake operations like file(WRITE.
Fixes https://github.com/microsoft/vcpkg/issues/26178
ports/ffmpeg/portfile.cmake:
Both uses are being embedded into a command line ✅
ports/gdal/dependency_win.cmake
117: This used TO_NATIVE_PATH but didn't actually connect the result. It's going on a command line so TO_NATIVE_PATH is appropriate.
Drive by: Added quotes around other uses (all of which seem to be going to command lines).
202: ${EXPAT_LIBRARY_REL} ${ZLIB_LIBRARY_REL} don't seem to be set even though they are used; I think this is wrong but I don't know for sure that it is so I'm leaving it alone for now.
ports/msmpi/portfile.cmake
All 3 uses are being embedded into a command line ✅
ports/jemalloc/fix-utilities.patch
ports/libproxy/fix-dependency-libmodman.patch
ports/qtbase/env.patch
These are in upstream content / context so it is not edited.
ports/opengl/portfile.cmake
Broken! Drive by fixes:
* Modernized checking VCPKG_BUILD_TYPE
* Ordered things consistently to be release then debug.
* Removed funny newlines.
ports/openni2/portfile.cmake
Borderline OK; it goes into an MSBuild / vcxproj. I'm leaving it alone. Drive by fixes:
* Guarded debug-only copies for VCPKG_BUILD_TYPE
* Fixed supports expression
ports/openssl/unix/CMakeLists.txt:
Unused!
ports/pthreads/portfile.cmake:
Both uses are being embedded into a command line ✅
ports/qt5-base/cmake/qt_fix_makefile_install.cmake
I'm not sure if this one is OK but it's being embedded into a file so it's probably fine.
ports/qtapplicationmanager/portfile.cmake:
I'm pretty sure this one is wrong, but it's guarded by VCPKG_TARGET_IS_WINDOWS so the ability to create damage is limited.
ports/readosm/portfile.cmake:
The use is being embedded into a command line ✅
ports/spatialite-tools/portfile.cmake:
The use is being embedded into a command line ✅
ports/sqlcipher/portfile.cmake:
Both uses are being embedded into a command line ✅
scripts/ports.cmake:
Some uses were unused, others are immediately used and printed to the console. ✅
scripts/buildsystems/vcpkg.cmake:
Fixed :)
scripts/cmake/vcpkg_build_qmake:
Looks unused.
scripts/cmake/vcpkg_build_process.cmake:
Added to console message only. ✅
scripts/cmake/vcpkg_execute_required_process_repeat.cmake:
Added to console message only. ✅
Drive by: Fixed typo in variable name in the message.
scripts/cmake/vcpkg_execute_required_process.cmake:
Added to console message only. ✅
* Fix missing license.
* Update to 3.4.3RC2
* Add control of AWS EC2 detection dependency
* Use libtool's DLL_EXPORT for mingw
* Move patches to vcpkg_from_github
* Update to 3.4.3
* Update versions
* Update to 3.4.2
* Disable ATL for uwp and for arm64
* Fix linking on uwp
* Fix pc file fixup
* Update versions
* Declare dependency on atlmfc.
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
* Major update to port poppler
* Fixup usage requirements via main pc file
* Add usage based on FindPkgConfig
* Export unofficial cmake config
* uwp is unsupported
* [gdal] Add poppler feature
* [gdal] Update poppler dependency
* [gdal] Add patch for poppler C++17 API
* Disable ENABLE_RELOCATABLE
* Update to 22.02.0 from poppler gitlab
* Update versions
* [skip actions] CI with gdal tools
* Revert "[skip actions] CI with gdal tools"
* Modify feature name for private API
* Update versions
* Add license field to gdal manifest
* Add port name to unofficial namespace
* Rectify poppler version number
* Update versions
* poppler[fontconfig] doesn't build for MSVC
* Update versions
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
* Update to 8.1.1, cleanup patches
* Patch and use pc file installation from upstream
* Simplify dependency fixup
* Remove obsolete VCPKG_BUILD_SHARED_LIBS
* Revise feature and dependency interface
* Update versions
* Use all libs from proj.pc for gdal
* Set CMP0012 for dependency control
* Update versions
* Update versions
* Fix missing user32.lib when using libcrypto
* Update versions
* Fix missing user32.lib when using libcrypto
* Update versions
* Modernize lodepng portfile
* Update to 8c6a9e30
* Install LICENSE as copyright
* Don't install examples
* Remove unused parameter
* Merge lodepng-c into lodepng
* Add usage
* Omit lodepng-util: not official API
* Update versions
* [gdal] Don't use lz4: not a dependency
* [libjxl] Fix link flags
* Revise install cleanup, handle .dylib
* Add extra flags for uwp
* Workaround uwp toolchain quirks
* More dependency control, jxl_extras for tools only
* Pass the version to the build
* Update versions
* Skip CI for libjxl:arm-uwp
* Install usage file
* Update versions
* Use version-date for lodepng, mark lodepng-c as deprecated, and update version database.
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
* [osgearth] Re-fix dependency gdal
* [gdal] Add dependency freexl on UNIX
* update version record
* fix patch
* convert to manifest
* update version record
* re-fix
* update version record
* add dependency freexl
* update version record
* Disable freexl
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
* Don't require freexl on Windows
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
* Revert osgearth change
* Fix the baseline version
* Fix osgearth baseline version
* [protouf] Automatic set protobuf_MODULE_COMPATIBLE to include the module file
* Set protobuf_MODULE_COMPATIBLE in wrapper
* Re-fix protobuf
* update version record
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Co-authored-by: PhoebeHui <20694052+PhoebeHui@users.noreply.github.com>
