Commit Graph

2 Commits

Author SHA1 Message Date
Kai Pastor
47633daa65
[vcpkg-scripts] Catch use of ambiguous cmake vars (#34546)
Avoid wrong use of popular but ambiguous variables (`WIN32` etc.) in
scripts and portfiles by detection in CI.

Sometimes the variables are used wrongly, and sometimes this isn't
caught in PR review. This PR tries to catch those variables (when in the
active code path in script mode). [This can happen to every
contributor](https://github.com/microsoft/vcpkg/pull/34356#discussion_r1360074122),
even if he/she knows the rules ... vcpkg is raising the bar higher than
usual, having to deal with targets and hosts even in script mode.

(`b2-options.cmake` (boost fragment) shows where we get if we don't pay
attention: the same code being used in script mode (`WIN32` meaning
host) and in project mode (`WIN32` meaning target).)

The new check doesn't break any user builds because it relies on command
line options. However it changes the ABI hashes.
2024-06-14 11:40:01 -07:00
Samuel Marks
621b7abe07
[ports/keccak-tiny] New port (#34356)
* [ports/keccak-tiny] New port

* [ports/keccak-tiny] Resolve hand-lint from vcpkg team

* [ports/keccak-tiny/portfile.cmake] Guard check linkage for Windows

Co-authored-by: Kai Pastor <dg0yt@darc.de>

* [versions/k-/keccak-tiny.json] `./vcpkg x-add-version --all --overwrite-version`

---------

Co-authored-by: Kai Pastor <dg0yt@darc.de>
2023-10-17 11:42:31 -07:00