mirror of
https://github.com/microsoft/vcpkg.git
synced 2024-11-24 19:29:08 +08:00
d816079874
While authoring vcpkg_from_git to authenticated servers documentation, @JavierMatosD and I discovered some failure modes that are not clear in the output. Example with REF set to a branch name: ```console The port under test is: vcpkg_from_git( OUT_SOURCE_PATH out URL https://github.com/microsoft/vcpkg REF 2024.01.12 ) ========== BEFORE =============== Computing installation plan... The following packages will be built and installed: test-port:x64-windows@1 -- D:\test\test-port Detecting compiler hash for triplet x64-windows... Installing 1/1 test-port:x64-windows@1... Building test-port:x64-windows@1... -- Installing port from location: D:\test\test-port -- Fetching https://github.com/microsoft/vcpkg 2024.01.12... CMake Error at scripts/cmake/vcpkg_from_git.cmake:141 (message): unable to rev-parse 2024.01.12 after fetching git repository Call Stack (most recent call first): D:/test/test-port/portfile.cmake:1 (vcpkg_from_git) scripts/ports.cmake:170 (include) error: building test-port:x64-windows failed with: BUILD_FAILED Elapsed time to handle test-port:x64-windows: 1.8 s Please ensure you're using the latest port files with `git pull` and `vcpkg update`. Then check for known issues at: https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+test-port You can submit a new issue at: https://github.com/microsoft/vcpkg/issues/new?title=[test-port]+Build+error+on+x64-windows&body=Copy+issue+body+from+D%3A%2Fvcpkg2%2Finstalled%2Fvcpkg%2Fissue_body.md ========== AFTER ================ Computing installation plan... The following packages will be built and installed: test-port:x64-windows@1 -- D:\test\test-port Detecting compiler hash for triplet x64-windows... Installing 1/1 test-port:x64-windows@1... Building test-port:x64-windows@1... -- Installing port from location: D:\test\test-port -- Fetching https://github.com/microsoft/vcpkg 2024.01.12... CMake Error at scripts/cmake/vcpkg_from_git.cmake:142 (message): After fetching 2024.01.12, the target ref 2024.01.12 appears inaccessible. A common cause of this failure is setting REF to a named branch or tag rather than a commit SHA. REF must be a commit SHA. If the git server does not advertise commit SHAs (uploadpack.allowReachableSHA1InWant is false), you can set FETCH_REF to a named branch in which the desired commit SHA is in the history. For example, you may be able to fix this error by changing "REF 2024.01.12" to "REF a-commit-sha FETCH_REF 2024.01.12". (git rev-parse 2024.01.12 failed) Call Stack (most recent call first): D:/test/test-port/portfile.cmake:1 (vcpkg_from_git) scripts/ports.cmake:170 (include) error: building test-port:x64-windows failed with: BUILD_FAILED Elapsed time to handle test-port:x64-windows: 1.9 s Please ensure you're using the latest port files with `git pull` and `vcpkg update`. Then check for known issues at: https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+test-port You can submit a new issue at: https://github.com/microsoft/vcpkg/issues/new?title=[test-port]+Build+error+on+x64-windows&body=Copy+issue+body+from+D%3A%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md ``` Example with REF ste to a branch name with FETCH_REF set: ```console PS D:\test> run-test The following packages are not installed: test-port:x64-windows The following packages are not installed: test-port:x64-windows The port under test is: vcpkg_from_git( OUT_SOURCE_PATH out URL https://github.com/microsoft/vcpkg REF 2024.01.12 FETCH_REF master ) ========== BEFORE =============== Computing installation plan... The following packages will be built and installed: test-port:x64-windows@1 -- D:\test\test-port Detecting compiler hash for triplet x64-windows... Installing 1/1 test-port:x64-windows@1... Building test-port:x64-windows@1... -- Installing port from location: D:\test\test-port -- Fetching https://github.com/microsoft/vcpkg master... CMake Error at scripts/cmake/vcpkg_from_git.cmake:141 (message): unable to rev-parse 2024.01.12 after fetching git repository Call Stack (most recent call first): D:/test/test-port/portfile.cmake:1 (vcpkg_from_git) scripts/ports.cmake:170 (include) error: building test-port:x64-windows failed with: BUILD_FAILED Elapsed time to handle test-port:x64-windows: 1.6 s Please ensure you're using the latest port files with `git pull` and `vcpkg update`. Then check for known issues at: https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+test-port You can submit a new issue at: https://github.com/microsoft/vcpkg/issues/new?title=[test-port]+Build+error+on+x64-windows&body=Copy+issue+body+from+D%3A%2Fvcpkg2%2Finstalled%2Fvcpkg%2Fissue_body.md ========== AFTER ================ Computing installation plan... The following packages will be built and installed: test-port:x64-windows@1 -- D:\test\test-port Detecting compiler hash for triplet x64-windows... Installing 1/1 test-port:x64-windows@1... Building test-port:x64-windows@1... -- Installing port from location: D:\test\test-port -- Fetching https://github.com/microsoft/vcpkg master... CMake Error at scripts/cmake/vcpkg_from_git.cmake:138 (message): After fetching master, the target ref 2024.01.12 appears inaccessible. A common cause of this failure is setting REF to a named branch or tag rather than a commit SHA. REF must be a commit SHA. (git rev-parse 2024.01.12 failed) Call Stack (most recent call first): D:/test/test-port/portfile.cmake:1 (vcpkg_from_git) scripts/ports.cmake:170 (include) error: building test-port:x64-windows failed with: BUILD_FAILED Elapsed time to handle test-port:x64-windows: 1.5 s Please ensure you're using the latest port files with `git pull` and `vcpkg update`. Then check for known issues at: https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+test-port You can submit a new issue at: https://github.com/microsoft/vcpkg/issues/new?title=[test-port]+Build+error+on+x64-windows&body=Copy+issue+body+from+D%3A%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md ``` --------- Co-authored-by: Thomas1664 <46387399+Thomas1664@users.noreply.github.com>
190 lines
8.0 KiB
CMake
190 lines
8.0 KiB
CMake
function(vcpkg_from_git)
|
|
cmake_parse_arguments(PARSE_ARGV 0 "arg"
|
|
""
|
|
"OUT_SOURCE_PATH;URL;REF;FETCH_REF;HEAD_REF;TAG;LFS"
|
|
"PATCHES"
|
|
)
|
|
|
|
if(DEFINED arg_UNPARSED_ARGUMENTS)
|
|
message(WARNING "vcpkg_from_git was passed extra arguments: ${arg_UNPARSED_ARGUMENTS}")
|
|
endif()
|
|
if(DEFINED arg_TAG)
|
|
message(WARNING "The TAG argument to vcpkg_from_git has been deprecated and has no effect.")
|
|
endif()
|
|
|
|
if(NOT DEFINED arg_OUT_SOURCE_PATH)
|
|
message(FATAL_ERROR "OUT_SOURCE_PATH must be specified")
|
|
endif()
|
|
if(NOT DEFINED arg_URL)
|
|
message(FATAL_ERROR "URL must be specified")
|
|
endif()
|
|
if(NOT DEFINED arg_REF AND NOT DEFINED arg_HEAD_REF)
|
|
message(FATAL_ERROR "At least one of REF or HEAD_REF must be specified")
|
|
endif()
|
|
if(DEFINED arg_FETCH_REF AND NOT DEFINED arg_REF)
|
|
message(FATAL_ERROR "REF must be specified if FETCH_REF is specified")
|
|
endif()
|
|
if(NOT DEFINED arg_LFS AND "LFS" IN_LIST arg_KEYWORDS_MISSING_VALUES)
|
|
set(arg_LFS "${arg_URL}")
|
|
endif()
|
|
|
|
vcpkg_list(SET git_fetch_shallow_param --depth 1)
|
|
vcpkg_list(SET extract_working_directory_param)
|
|
vcpkg_list(SET skip_patch_check_param)
|
|
set(git_working_directory "${DOWNLOADS}/git-tmp")
|
|
set(do_download OFF)
|
|
|
|
if(VCPKG_USE_HEAD_VERSION AND DEFINED arg_HEAD_REF)
|
|
vcpkg_list(SET working_directory_param "WORKING_DIRECTORY" "${CURRENT_BUILDTREES_DIR}/src/head")
|
|
vcpkg_list(SET git_fetch_shallow_param --depth 1)
|
|
vcpkg_list(SET skip_patch_check_param SKIP_PATCH_CHECK)
|
|
set(ref_to_fetch "${arg_HEAD_REF}")
|
|
set(git_working_directory "${CURRENT_BUILDTREES_DIR}/src/git-tmp")
|
|
string(REPLACE "/" "_-" sanitized_ref "${arg_HEAD_REF}")
|
|
|
|
if(NOT _VCPKG_NO_DOWNLOADS)
|
|
set(do_download ON)
|
|
endif()
|
|
else()
|
|
if(NOT DEFINED arg_REF)
|
|
message(FATAL_ERROR "Package does not specify REF. It must be built using --head.")
|
|
endif()
|
|
if(VCPKG_USE_HEAD_VERSION)
|
|
message(STATUS "Package does not specify HEAD_REF. Falling back to non-HEAD version.")
|
|
endif()
|
|
|
|
if(DEFINED arg_FETCH_REF)
|
|
set(ref_to_fetch "${arg_FETCH_REF}")
|
|
vcpkg_list(SET git_fetch_shallow_param)
|
|
else()
|
|
set(ref_to_fetch "${arg_REF}")
|
|
endif()
|
|
string(REPLACE "/" "_-" sanitized_ref "${arg_REF}")
|
|
endif()
|
|
|
|
set(temp_archive "${DOWNLOADS}/temp/${PORT}-${sanitized_ref}.tar.gz")
|
|
set(archive "${DOWNLOADS}/${PORT}-${sanitized_ref}.tar.gz")
|
|
|
|
if(NOT EXISTS "${archive}")
|
|
if(_VCPKG_NO_DOWNLOADS)
|
|
message(FATAL_ERROR "Downloads are disabled, but '${archive}' does not exist.")
|
|
endif()
|
|
set(do_download ON)
|
|
endif()
|
|
|
|
if(do_download)
|
|
message(STATUS "Fetching ${arg_URL} ${ref_to_fetch}...")
|
|
find_program(GIT NAMES git git.cmd)
|
|
file(MAKE_DIRECTORY "${DOWNLOADS}")
|
|
# Note: git init is safe to run multiple times
|
|
vcpkg_execute_required_process(
|
|
ALLOW_IN_DOWNLOAD_MODE
|
|
COMMAND "${GIT}" init "${git_working_directory}"
|
|
WORKING_DIRECTORY "${CURRENT_BUILDTREES_DIR}"
|
|
LOGNAME "git-init-${TARGET_TRIPLET}"
|
|
)
|
|
vcpkg_execute_required_process(
|
|
ALLOW_IN_DOWNLOAD_MODE
|
|
COMMAND "${GIT}" fetch "${arg_URL}" "${ref_to_fetch}" ${git_fetch_shallow_param} -n
|
|
WORKING_DIRECTORY "${git_working_directory}"
|
|
LOGNAME "git-fetch-${TARGET_TRIPLET}"
|
|
)
|
|
if(arg_LFS)
|
|
# Running "git lfs" searches for "git-lfs[.exe]" on the path
|
|
vcpkg_execute_in_download_mode(
|
|
COMMAND "${GIT}" lfs --version
|
|
OUTPUT_VARIABLE lfs_version_output
|
|
ERROR_VARIABLE lfs_version_error
|
|
RESULT_VARIABLE lfs_version_result
|
|
WORKING_DIRECTORY "${git_working_directory}"
|
|
)
|
|
if(lfs_version_result)
|
|
message(FATAL_ERROR "Git LFS is required for ${PORT}")
|
|
endif()
|
|
|
|
vcpkg_execute_required_process(
|
|
ALLOW_IN_DOWNLOAD_MODE
|
|
COMMAND "${GIT}" lfs install --local --force
|
|
WORKING_DIRECTORY "${git_working_directory}"
|
|
LOGNAME "git-lfs-install-${TARGET_TRIPLET}"
|
|
)
|
|
vcpkg_execute_required_process(
|
|
ALLOW_IN_DOWNLOAD_MODE
|
|
COMMAND "${GIT}" lfs fetch "${arg_LFS}" "${ref_to_fetch}"
|
|
WORKING_DIRECTORY "${git_working_directory}"
|
|
LOGNAME "git-lfs-fetch-${TARGET_TRIPLET}"
|
|
)
|
|
endif()
|
|
|
|
if(VCPKG_USE_HEAD_VERSION)
|
|
set(expected_rev_parse FETCH_HEAD)
|
|
else()
|
|
set(expected_rev_parse "${arg_REF}")
|
|
endif()
|
|
|
|
vcpkg_execute_in_download_mode(
|
|
COMMAND "${GIT}" rev-parse "${expected_rev_parse}"
|
|
OUTPUT_VARIABLE rev_parse_ref
|
|
ERROR_VARIABLE rev_parse_ref
|
|
RESULT_VARIABLE error_code
|
|
WORKING_DIRECTORY "${git_working_directory}"
|
|
)
|
|
|
|
if(error_code)
|
|
if(VCPKG_USE_HEAD_VERSION)
|
|
message(FATAL_ERROR "Unable to determine the commit SHA of the HEAD version to use after \
|
|
fetching ${ref_to_fetch} from the git repository. (git rev-parse ${expected_rev_parse} failed)")
|
|
elseif(DEFINED arg_FETCH_REF)
|
|
message(FATAL_ERROR "After fetching ${ref_to_fetch}, the target ref ${expected_rev_parse} appears \
|
|
inaccessible. A common cause of this failure is setting REF to a named branch or tag rather than a commit SHA. REF \
|
|
must be a commit SHA. (git rev-parse ${expected_rev_parse} failed)")
|
|
else()
|
|
message(FATAL_ERROR "After fetching ${ref_to_fetch}, the target ref ${expected_rev_parse} appears \
|
|
inaccessible. A common cause of this failure is setting REF to a named branch or tag rather than a commit SHA. REF \
|
|
must be a commit SHA. If the git server does not advertise commit SHAs \
|
|
(uploadpack.allowReachableSHA1InWant is false), you can set FETCH_REF to a named branch in which the desired commit \
|
|
SHA is in the history. For example, you may be able to fix this error by changing \"REF ${arg_REF}\" to \
|
|
\"REF a-commit-sha FETCH_REF ${arg_REF}\". (git rev-parse ${expected_rev_parse} failed)")
|
|
endif()
|
|
endif()
|
|
|
|
string(STRIP "${rev_parse_ref}" rev_parse_ref)
|
|
if(VCPKG_USE_HEAD_VERSION)
|
|
set(VCPKG_HEAD_VERSION "${rev_parse_ref}" PARENT_SCOPE)
|
|
elseif(NOT "${rev_parse_ref}" STREQUAL "${arg_REF}")
|
|
message(FATAL_ERROR "After fetching ${ref_to_fetch}, the requested REF (${arg_REF}) does not match \
|
|
its commit SHA returned by git rev-parse (${rev_parse_ref}). This is usually caused by trying to set REF to a named \
|
|
branch or tag rather than a commit SHA. REF must be a commit SHA. If the git server does not advertise commit SHAs \
|
|
(uploadpack.allowReachableSHA1InWant is false), you can set FETCH_REF to a named branch in which the desired commit \
|
|
SHA is in the history. For example, you may be able to fix this error by changing \"REF ${arg_REF}\" to \
|
|
\"REF a-commit-sha FETCH_REF ${arg_REF}\".
|
|
[Expected : ( ${arg_REF} )])
|
|
[ Actual : ( ${rev_parse_ref} )]"
|
|
)
|
|
endif()
|
|
|
|
file(MAKE_DIRECTORY "${DOWNLOADS}/temp")
|
|
vcpkg_execute_required_process(
|
|
ALLOW_IN_DOWNLOAD_MODE
|
|
COMMAND "${GIT}" -c core.autocrlf=false archive "${rev_parse_ref}" -o "${temp_archive}"
|
|
WORKING_DIRECTORY "${git_working_directory}"
|
|
LOGNAME git-archive
|
|
)
|
|
file(RENAME "${temp_archive}" "${archive}")
|
|
else()
|
|
message(STATUS "Using cached ${archive}")
|
|
endif()
|
|
|
|
vcpkg_extract_source_archive_ex(
|
|
OUT_SOURCE_PATH SOURCE_PATH
|
|
ARCHIVE "${archive}"
|
|
REF "${sanitized_ref}"
|
|
PATCHES ${arg_PATCHES}
|
|
NO_REMOVE_ONE_LEVEL
|
|
${extract_working_directory_param}
|
|
${skip_patch_check_param}
|
|
)
|
|
|
|
set("${arg_OUT_SOURCE_PATH}" "${SOURCE_PATH}" PARENT_SCOPE)
|
|
endfunction()
|