mirror of
https://github.com/microsoft/vcpkg.git
synced 2024-12-11 15:59:16 +08:00
561d171d79
Resolves https://github.com/microsoft/vcpkg/issues/35566 This pr includes https://github.com/microsoft/vcpkg/pull/31159 and https://github.com/microsoft/vcpkg/pull/35399 Ports changed in this pr: Most of these changes stem from the fact that protobuf now depends on abseil and requires c++14 while ports consume protobuf using `target_link_libraries(lib ${Protobuf_LIBRARIES})` instead of `target_link_libraries(lib PUBLIC protobuf::libprotobuf)`. * **abseil** Updated to 03/04/2024 to address MSVC build issue in openvino * **arcus** Updated to 4.13.2 * **braft** Patched to use `find_package(Protobuf` instead of custom FindProtobuf module. also link with `PUBLIC protobuf::libprotobuf)`. * **brpc** Patch several `target_link_library` calls to include `PUBLIC` instead of nothing. Patch some warnings that are treated as errors by some OSX compiler. Patch usage of changed protobuf features most importantly removal of `SetLogHandler`, tbd whether this patch is acceptable with upstream. * **cld3** Use CONFIG to find protobuf to propagate dependent abseil libs and cxx14 correctly. * **ecal** Use CONFIG to find protobuf. Use PUBLIC when linking it. * **gamenetworkingsockets** Add `-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=on` for protobuf. * **gz-transport12** Update to fix usage of removed protobuf features. * **ignition-msgs1/5/6** Remove protobuf version check which is confused by the duplicate versioning scheme (v25.1 vs. 3.25.1 vs 4.x). Why are we even maintaining this no longer maintained major version of this port? I would welcome a more strict policy on removing ports/adding them to ci.baseline.txt * **ignition-transport4/8/9** Same as above + cherry-pick a protobuf deprecation patch. * **libprotobuf-mutator** Cherry-pick two commits to address altered protobuf functionality. Add CONFIG and PUBLIC to protobuf handling in CMake. * **marble** Explicitly set protobuf to not found since it is not part of the vcpkg.json but is made available transitively but another dependency. * **mysql-connector-cpp** Several CMake changes and removal of protobuf::SetLogHandler patch. * **openvino** Find protobuf using CONFIG * **osgearth** Link libraries using PUBLIC and link with protobuf::libprotobuf instead of Protobuf_LIBRARIES * **paraview** Find protobuf using CONFIG and remove version check * **pulsar-client-cpp** Add protobuf linkage to PULSAR_OBJECT_LIB. Simplify protoc patch. Remove -Werror. * **shogun** Update and patch as much as possible. Users are required to override bitsery version to 4.x to use shogun since it does not support 5.x provided by vcpkg. Therefore add shogun to ci.baseline.txt. * **srpc** Update and fix static crt linkage. Patch protobuf linkage and remove hardcoded `-std=c++11` flag. Protobuf requires c++14 and CMake does not recognize the hardcoded c++11 flag and will therefore not add a c++14 flag when the compiler uses c++14 by default. * **upb** Update to align version with protobuf/grpc and use new github repo. Patch usual CMake mess (they do not support CMake officially) which should probably be `unofficial-upbConfig.cmake` but I didn't dig into downstream implications so I kept it at `upbConfig.cmake` as before. * **utf8-range** Update to allign version with protobuf.
77 lines
2.4 KiB
Diff
77 lines
2.4 KiB
Diff
diff --git a/cdk/cmake/DepFindProtobuf.cmake b/cdk/cmake/DepFindProtobuf.cmake
|
|
index 730389de..7c3fd78b 100644
|
|
--- a/cdk/cmake/DepFindProtobuf.cmake
|
|
+++ b/cdk/cmake/DepFindProtobuf.cmake
|
|
@@ -44,6 +44,7 @@
|
|
#
|
|
#
|
|
|
|
+if(0)
|
|
if(TARGET ext::protobuf)
|
|
return()
|
|
endif()
|
|
@@ -64,7 +65,7 @@ add_ext_targets(protobuf
|
|
LIBRARY protobuf pb_libprotobuf
|
|
EXECUTABLE protoc pb_protoc
|
|
)
|
|
-
|
|
+endif()
|
|
|
|
# Standard PROTOBUF_GENERATE_CPP modified to our usage
|
|
function(mysqlx_protobuf_generate_cpp SRCS HDRS)
|
|
@@ -90,7 +91,7 @@ function(mysqlx_protobuf_generate_cpp SRCS HDRS)
|
|
"${CMAKE_CURRENT_BINARY_DIR}/protobuf/${FIL_WE}.pb.h"
|
|
COMMAND ${CMAKE_COMMAND}
|
|
-E make_directory "${CMAKE_CURRENT_BINARY_DIR}/protobuf"
|
|
- COMMAND ext::protoc
|
|
+ COMMAND protobuf::protoc
|
|
ARGS --cpp_out "${CMAKE_CURRENT_BINARY_DIR}/protobuf"
|
|
-I ${ABS_PATH} ${ABS_FIL}
|
|
|
|
diff --git a/cdk/core/CMakeLists.txt b/cdk/core/CMakeLists.txt
|
|
index 30f7baf1..2a4a9434 100644
|
|
--- a/cdk/core/CMakeLists.txt
|
|
+++ b/cdk/core/CMakeLists.txt
|
|
@@ -33,6 +33,7 @@ cmake_minimum_required(VERSION 2.8)
|
|
|
|
#ADD_SUBDIRECTORY(tests)
|
|
|
|
+find_package(Protobuf CONFIG REQUIRED)
|
|
|
|
SET(cdk_sources
|
|
session.cc
|
|
@@ -45,7 +46,7 @@ add_library(cdk STATIC ${cdk_sources} ${HEADERS})
|
|
|
|
target_link_libraries(cdk
|
|
PUBLIC cdk_mysqlx cdk_parser
|
|
- PRIVATE ext::protobuf-lite # required by codecc.cc
|
|
+ PRIVATE protobuf::libprotobuf-lite # required by codecc.cc
|
|
)
|
|
|
|
add_coverage(cdk)
|
|
diff --git a/cdk/protocol/mysqlx/CMakeLists.txt b/cdk/protocol/mysqlx/CMakeLists.txt
|
|
index cfc81daf..6c484575 100644
|
|
--- a/cdk/protocol/mysqlx/CMakeLists.txt
|
|
+++ b/cdk/protocol/mysqlx/CMakeLists.txt
|
|
@@ -26,8 +26,9 @@
|
|
# along with this program; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
|
|
-find_dependency(Protobuf)
|
|
-find_dependency(Compression)
|
|
+include(DepFindCompression)
|
|
+find_package(Protobuf CONFIG REQUIRED)
|
|
+include(DepFindProtobuf)
|
|
|
|
include(CheckIncludeFile)
|
|
|
|
@@ -132,7 +133,7 @@ target_include_directories(cdk_proto_mysqlx PRIVATE
|
|
if(use_full_protobuf)
|
|
target_link_libraries(cdk_proto_mysqlx PRIVATE ext::protobuf)
|
|
else()
|
|
- target_link_libraries(cdk_proto_mysqlx PRIVATE ext::protobuf-lite)
|
|
+ target_link_libraries(cdk_proto_mysqlx PRIVATE protobuf::libprotobuf-lite)
|
|
endif()
|
|
|
|
if (WIN32)
|