mirror of
https://github.com/opencv/opencv.git
synced 2024-12-03 00:10:21 +08:00
60848519b5
G-API: Fix incorrect OpaqueKind for Kernel outputs #23843 ### Pull Request Readiness Checklist #### Overview The PR is going to fix several problems: 1. Major: `GKernel` doesn't hold `kind` for its outputs. Since `GModelBuilder` traverse graph from outputs to inputs once it reaches any output of the operation it will use its `kind` to create `Data` meta for all operation outputs. Since it essential for `python` to know `GTypeInfo` (which is `shape` and `kind`) it will be confused. Consider this operation: ``` @cv.gapi.op('custom.square_mean', in_types=[cv.GArray.Int], out_types=[cv.GOpaque.Float, cv.GArray.Int]) class GSquareMean: @staticmethod def outMeta(desc): return cv.empty_gopaque_desc(), cv.empty_array_desc() ``` Even though `GOpaque` is `Float`, corresponding metadata might have `Int` kind because it might be taken from `cv.GArray.Int` so it will be a problem if one of the outputs of these operation is graph output because python will cast it to the wrong type based on `Data` meta. 2. Minor: Some of the OpenVINO `IR`'s doesn't any layout information for input. It's usually true only for `IRv10` but since `OpenVINO 2.0` need this information to correctly configure resize we need to put default layout if there no such assigned in `ov::Model`. See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake |
||
|---|---|---|
| .. | ||
| common | ||
| cpu | ||
| executor | ||
| gpu | ||
| infer | ||
| internal | ||
| oak | ||
| own | ||
| render | ||
| rmat | ||
| s11n | ||
| streaming | ||
| util | ||
| gapi_array_tests.cpp | ||
| gapi_async_test.cpp | ||
| gapi_basic_hetero_tests.cpp | ||
| gapi_compile_args_tests.cpp | ||
| gapi_desc_tests.cpp | ||
| gapi_fluid_parallel_rois_test.cpp | ||
| gapi_fluid_resize_test.cpp | ||
| gapi_fluid_roi_test.cpp | ||
| gapi_fluid_test_kernels.cpp | ||
| gapi_fluid_test_kernels.hpp | ||
| gapi_fluid_test.cpp | ||
| gapi_frame_tests.cpp | ||
| gapi_gcompiled_tests.cpp | ||
| gapi_gcomputation_tests.cpp | ||
| gapi_gpu_test.cpp | ||
| gapi_graph_meta_tests.cpp | ||
| gapi_kernel_tests.cpp | ||
| gapi_mock_kernels.hpp | ||
| gapi_opaque_tests.cpp | ||
| gapi_plaidml_pipelines.cpp | ||
| gapi_planar_test.cpp | ||
| gapi_sample_pipelines.cpp | ||
| gapi_scalar_tests.cpp | ||
| gapi_smoke_test.cpp | ||
| gapi_transform_tests.cpp | ||
| gapi_typed_tests.cpp | ||
| gapi_util_tests.cpp | ||
| opencl_kernels_test_gapi.hpp | ||
| test_main.cpp | ||
| test_precomp.hpp | ||