mirror of
https://github.com/opencv/opencv.git
synced 2024-12-15 18:09:11 +08:00
e0b489e917
Handle degenerate cases in RQDecomp3x3 #25050 The point of the Givens rotations here is to iteratively set the lower left matrix entries to zero. If an element is zero already, we don't need to do anything. This resolves #24330. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
164 lines
5.0 KiB
C++
164 lines
5.0 KiB
C++
/*M///////////////////////////////////////////////////////////////////////////////////////
|
|
//
|
|
// IMPORTANT: READ BEFORE DOWNLOADING, COPYING, INSTALLING OR USING.
|
|
//
|
|
// By downloading, copying, installing or using the software you agree to this license.
|
|
// If you do not agree to this license, do not download, install,
|
|
// copy or use the software.
|
|
//
|
|
//
|
|
// License Agreement
|
|
// For Open Source Computer Vision Library
|
|
//
|
|
// Copyright (C) 2000-2008, Intel Corporation, all rights reserved.
|
|
// Copyright (C) 2009, Willow Garage Inc., all rights reserved.
|
|
// Third party copyrights are property of their respective owners.
|
|
//
|
|
// Redistribution and use in source and binary forms, with or without modification,
|
|
// are permitted provided that the following conditions are met:
|
|
//
|
|
// * Redistribution's of source code must retain the above copyright notice,
|
|
// this list of conditions and the following disclaimer.
|
|
//
|
|
// * Redistribution's in binary form must reproduce the above copyright notice,
|
|
// this list of conditions and the following disclaimer in the documentation
|
|
// and/or other materials provided with the distribution.
|
|
//
|
|
// * The name of the copyright holders may not be used to endorse or promote products
|
|
// derived from this software without specific prior written permission.
|
|
//
|
|
// This software is provided by the copyright holders and contributors "as is" and
|
|
// any express or implied warranties, including, but not limited to, the implied
|
|
// warranties of merchantability and fitness for a particular purpose are disclaimed.
|
|
// In no event shall the Intel Corporation or contributors be liable for any direct,
|
|
// indirect, incidental, special, exemplary, or consequential damages
|
|
// (including, but not limited to, procurement of substitute goods or services;
|
|
// loss of use, data, or profits; or business interruption) however caused
|
|
// and on any theory of liability, whether in contract, strict liability,
|
|
// or tort (including negligence or otherwise) arising in any way out of
|
|
// the use of this software, even if advised of the possibility of such damage.
|
|
//
|
|
//M*/
|
|
|
|
#include "test_precomp.hpp"
|
|
|
|
namespace opencv_test { namespace {
|
|
|
|
class CV_DecomposeProjectionMatrixTest : public cvtest::BaseTest
|
|
{
|
|
public:
|
|
CV_DecomposeProjectionMatrixTest();
|
|
protected:
|
|
void run(int);
|
|
};
|
|
|
|
CV_DecomposeProjectionMatrixTest::CV_DecomposeProjectionMatrixTest()
|
|
{
|
|
test_case_count = 30;
|
|
}
|
|
|
|
|
|
void CV_DecomposeProjectionMatrixTest::run(int start_from)
|
|
{
|
|
|
|
ts->set_failed_test_info(cvtest::TS::OK);
|
|
|
|
cv::RNG& rng = ts->get_rng();
|
|
int progress = 0;
|
|
|
|
|
|
for (int iter = start_from; iter < test_case_count; ++iter)
|
|
{
|
|
ts->update_context(this, iter, true);
|
|
progress = update_progress(progress, iter, test_case_count, 0);
|
|
|
|
// Create the original (and random) camera matrix, rotation, and translation
|
|
cv::Vec2d f, c;
|
|
rng.fill(f, cv::RNG::UNIFORM, 300, 1000);
|
|
rng.fill(c, cv::RNG::UNIFORM, 150, 600);
|
|
|
|
double alpha = 0.01*rng.gaussian(1);
|
|
|
|
cv::Matx33d origK(f(0), alpha*f(0), c(0),
|
|
0, f(1), c(1),
|
|
0, 0, 1);
|
|
|
|
|
|
cv::Vec3d rVec;
|
|
rng.fill(rVec, cv::RNG::UNIFORM, -CV_PI, CV_PI);
|
|
|
|
cv::Matx33d origR;
|
|
cv::Rodrigues(rVec, origR); // TODO cvtest
|
|
|
|
cv::Vec3d origT;
|
|
rng.fill(origT, cv::RNG::NORMAL, 0, 1);
|
|
|
|
|
|
// Compose the projection matrix
|
|
cv::Matx34d P(3,4);
|
|
hconcat(origK*origR, origK*origT, P);
|
|
|
|
|
|
// Decompose
|
|
cv::Matx33d K, R;
|
|
cv::Vec4d homogCameraCenter;
|
|
decomposeProjectionMatrix(P, K, R, homogCameraCenter);
|
|
|
|
|
|
// Recover translation from the camera center
|
|
cv::Vec3d cameraCenter(homogCameraCenter(0), homogCameraCenter(1), homogCameraCenter(2));
|
|
cameraCenter /= homogCameraCenter(3);
|
|
|
|
cv::Vec3d t = -R*cameraCenter;
|
|
|
|
|
|
const double thresh = 1e-6;
|
|
if (cv::norm(origK, K, cv::NORM_INF) > thresh)
|
|
{
|
|
ts->set_failed_test_info(cvtest::TS::FAIL_BAD_ACCURACY);
|
|
break;
|
|
}
|
|
|
|
if (cv::norm(origR, R, cv::NORM_INF) > thresh)
|
|
{
|
|
ts->set_failed_test_info(cvtest::TS::FAIL_BAD_ACCURACY);
|
|
break;
|
|
}
|
|
|
|
if (cv::norm(origT, t, cv::NORM_INF) > thresh)
|
|
{
|
|
ts->set_failed_test_info(cvtest::TS::FAIL_BAD_ACCURACY);
|
|
break;
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
TEST(Calib3d_DecomposeProjectionMatrix, accuracy)
|
|
{
|
|
CV_DecomposeProjectionMatrixTest test;
|
|
test.safe_run();
|
|
}
|
|
|
|
TEST(Calib3d_DecomposeProjectionMatrix, degenerate_cases)
|
|
{
|
|
for (int i = 0; i < 3; i++)
|
|
{
|
|
for (int j = 0; j < 2; j++)
|
|
{
|
|
cv::Matx34d P;
|
|
P(0, i) = 1;
|
|
P(1, (i + j + 1) % 3) = 1;
|
|
P(2, (i + 2 * j + 2) % 3) = 1;
|
|
|
|
cv::Matx33d K, R;
|
|
cv::Vec4d t;
|
|
decomposeProjectionMatrix(P, K, R, t);
|
|
EXPECT_LT(cv::norm(K * R, P.get_minor<3, 3>(0, 0), cv::NORM_INF), 1e-6);
|
|
}
|
|
}
|
|
}
|
|
|
|
}} // namespace
|