8398 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
ocornut	c527cba470	MultiSelect: we don't need to ever write to EndIO.RangeSrcItem as this is not meant to be used.	2024-07-18 18:19:16 +02:00
ocornut	6feff6ff05	MultiSelect: (Breaking) io contains a ImVector<ImGuiSelectionRequest> list.	2024-07-18 18:19:16 +02:00
ocornut	a6adfb2b49	MultiSelect: added missing call on Shutdown(). Better reuse selection buffer.	2024-07-18 18:19:16 +02:00
ocornut	c3998b70cc	MultiSelect: clarified purpose and use of IsItemToggledSelection(). Added assert. Moved to multi-selection section of imgui.h.	2024-07-18 18:19:16 +02:00
ocornut	2765fdb43e	MultiSelect: removed seemingly unnecessary block in BeginMultiSelect(). ... - EndIO.RangeSelected always set along with EndIO.RequestSetRange - Trying to assert for the assignment making a difference when EndIO.RequestSetRange is already set couldn't find a case (tests passing).	2024-07-18 18:19:16 +02:00
ocornut	88df590145	Demo: Assets Browser: store items, sorting, type overlay.	2024-07-18 18:19:16 +02:00
ocornut	d18e57e673	Demo: Assets Browser: Added assets browser demo.	2024-07-18 18:19:16 +02:00
ocornut	82de6c470b	MultiSelect: Added ImGuiMultiSelectFlags_SelectOnClickRelease to allow dragging an unselected item without altering selection + update drag and drop demo.	2024-07-18 18:19:16 +02:00
ocornut	5628dda5a5	MultiSelect: move shared logic to MultiSelectItemHeader(). ... No logic change AFAIK but added an indent level in MultiSelectItemHeader(). Logic changes will come in next commit.	2024-07-18 18:19:16 +02:00
ocornut	9da4efed2a	MultiSelect: moved RequestClear output so it'll match request list version better. Use Storage->RangeSrcItem in EndMultiSelect().	2024-07-18 18:19:16 +02:00
ocornut	a6f43dfadd	MultiSelect: ImGuiMultiSelectIO's field are not used during loop anymore, stripping them out of comments.	2024-07-18 18:19:16 +02:00
ocornut	dce02f5c4b	Demo: Dual List Box: Added a dual list box (6648)	2024-07-18 18:19:16 +02:00
ocornut	ba698df7bb	MultiSelect: Demo: Deletion: Various renames to clarify. Use adapter and item list in both ApplyDeletion functions. ... This also minify the patch for an alternative/wip attmept at redesgining pre/post deletion logic. But turns out current attempt may be easier to grasp.	2024-07-18 18:19:16 +02:00
ocornut	e1d2109208	MultiSelect: Demo: Deletion: Rework ApplyDeletionPreLoop to use adapter + fix PostLoop not using right value of RequestFocusItem. ... Recovery made it transparent visually but user side selection would be empty for a frame before recovery.	2024-07-18 18:19:16 +02:00
ocornut	fa516c3d76	MultiSelect: Demo: Make ExampleSelection use ImGuiID. More self-explanatory.	2024-07-18 18:19:15 +02:00
ocornut	530155d85a	MultiSelect: Demo: Remove UserDataToIndex from ExampleSelectionAdapter. ... Seems to make a better demo this way.	2024-07-18 18:19:15 +02:00
ocornut	8c1f659b3d	MultiSelect: Demo: rework ExampleSelection with an ExampleSelectionAdapter layer, allowing to share more code accross examples using different storage systems. ... Not ideal way to showcase this demo but this is really more flexible.	2024-07-18 18:19:15 +02:00
ocornut	8fe6b31952	MultiSelect: (Breaking) Removed RangeSrcPassedBy in favor of favoring user to call IncludeByIndex(RangeSrcItem) which is easier/simpler to honor. ... Especially as recent changes made it required to also update RangeSrcPassedBy after last clipper Step. Should now be simpler.	2024-07-18 18:19:15 +02:00
ocornut	6ddc5f38af	MultiSelect: Demo: added simpler demo using Clipper. Clarify RangeSrcPassedBy doc.	2024-07-18 18:19:15 +02:00
ocornut	c3753809b1	MultiSelect: Demo: rework ExampleSelection names to map better to typical user code + variety of Comments tweaks.	2024-07-18 18:19:15 +02:00
ocornut	ff95fdb668	MultiSelect: (Breaking) RequestSetRange's parameter are RangeFirstItem...RangeLastItem (which was always ordered unlike RangeSrcItem...RangeDstItme). Removed RangeDstItem. Removed RangeDirection.	2024-07-18 18:19:15 +02:00
ocornut	af83a3eea4	MultiSelect: clear selection when leaving a scope with a nav directional request. ... May need to clarify how to depends on actions being performed (e.g. click doesn't). May become optional?	2024-07-18 18:19:15 +02:00
ocornut	6821401a3f	MultiSelect: Tweak debug log to print decimal+hex values for item data. ... Struggled to get standard PRIX64 to work on CI.	2024-07-18 18:19:15 +02:00
ocornut	c9eb3714e8	MultiSelect: move HasSelectionData to ImGuiItemFlags to facilitate copying around in standardized fieds. ... Required/motivated to simplify support for ImGuiTreeNodeFlags_NavLeftJumpsBackHere (bc3c0ce) in this branch.	2024-07-18 18:19:15 +02:00
ocornut	e82b49d2d4	MultiSelect: (Breaking) Use ImGuiSelectionUserData (= ImS64) instead of void* for selection user data. ... Less confusing for most users, less casting.	2024-07-18 18:19:15 +02:00
ocornut	140a2f0565	MultiSelect: Comments, tweaks. ... + Alignment to reduce noise on next commit.	2024-07-18 18:19:15 +02:00
ocornut	847b1dde8c	MultiSelect: (Breaking) Fix + Rename ImGuiMultiSelectFlags_NoMultiSelect to ImGuiMultiSelectFlags_SingleSelect as it seems easier to grasp. ... Feature was broken by "Tidying up..." June 30 commit.	2024-07-18 18:19:15 +02:00
ocornut	0cf376348b	MultiSelect: Cleanup unused comments/code.	2024-07-18 18:19:14 +02:00
ocornut	ab9326f4ae	MultiSelect: Fixed right-click handling in MultiSelectItemFooter() when not focused.	2024-07-18 18:19:14 +02:00
ocornut	e3616e151f	MultiSelect: Demo: Delete items from menu.	2024-07-18 18:19:14 +02:00
ocornut	c0035705ca	MultiSelect: Further simplication of user code to support Deletion. ... Provide standard RequestFocusItem storage.	2024-07-18 18:19:14 +02:00
ocornut	df1eeb9a20	MultiSelect: Maintain NavIdSelected for user. Simplify deletion demo.	2024-07-18 18:19:14 +02:00
ocornut	9223ffc255	MultiSelect: (Breaking) BeginMultiSelect() doesn't need two last params maintained by users. Moving some storage from user to core. Proper deletion demo.	2024-07-18 18:19:14 +02:00
ocornut	564dde0ee3	MultiSelect: Demo: first-draft of user-side deletion idioms. ... (will need support from lib)	2024-07-18 18:19:14 +02:00
ocornut	387fc13894	MultiSelect: Clarify and better enforce lifetime of BeginMultiSelect() value.	2024-07-18 18:19:14 +02:00
ocornut	961b81c362	MultiSelect: Tidying up/simpllifying MultiSelectItemFooter(). ... Intended to be entirely a no-op, merely a transform of source code for simplification. But committing separatey from behavior change in previous change.	2024-07-18 18:19:14 +02:00
ocornut	1ea9ca748c	MultiSelect: Remove the need for using IsItemToggledSelection(). Update comments. ... This is the simple version that past our tests. MultiSelectItemFooter() is in need of a cleanup.	2024-07-18 18:19:14 +02:00
ocornut	6ef70a97fd	MultiSelect: Remove ImGuiMultiSelectFlags_NoUnselect because I currently can't find use for this specific design. ... And/or it seem partly broken.	2024-07-18 18:19:14 +02:00
ocornut	ccf43d6a96	MultiSelect: (Breaking) Renamed 'RangeValue' -> 'RangeSelected' + amend comments.	2024-07-18 18:19:14 +02:00
ocornut	a83326bc52	MultiSelect: (Breaking) Renamed 'RangeSrc -> 'RangeSrcItem', "RangeDst' -> 'RangeDstItem' ... This is necessary to have consistent names in upcoming fields (NavIdItem etc.)	2024-07-18 18:19:13 +02:00
ocornut	a39f9e7661	MultiSelect: Internals rename of IO fields to avoid ambiguity with io/rw concepts + memset constructors, tweaks. ... debug	2024-07-18 18:19:13 +02:00
ocornut	c61ada200f	MultiSelect: Demo tweak. Removed multi-scope from Advanced (too messy), made it a seperate mini-demo.	2024-07-18 18:19:13 +02:00
ocornut	35b5ebc9b5	MultiSelect: (Breaking) Rename ImGuiMultiSelectData to ImGuiMultiSelectIO.	2024-07-18 18:19:13 +02:00
ocornut	11bcae1ebd	MultiSelect: refactor before introducing persistant state pool and to facilitate adding recursion + debug log calls. ... This is mostly the noisy/shallow stuff committed here, to get this out of the way.	2024-07-18 18:19:13 +02:00
ocornut	5d71314f71	MultiSelect: removed DragDropActive/preserve_existing_selection logic which seems unused + comments. ... Can't find trace of early prototype for range-select but I couldn't find way to trigger this anymore. May be wrong. Will find out.	2024-07-18 18:19:13 +02:00
ocornut	85954c845e	MultiSelect: Enter can alter selection if current item is not selected.	2024-07-18 18:19:13 +02:00
ocornut	d2f208a30c	MultiSelect: made SetNextItemSelectionData() optional to allow disjoint selection (e.g. with a CollapsingHeader between items). Amend demo.	2024-07-18 18:19:13 +02:00
ocornut	815c61b82e	MultiSelect: Fixed needing to set RangeSrcPassedBy when not using clipper.	2024-07-18 18:19:13 +02:00
ocornut	78cb1661cb	MultiSelect: Shallow tweaks/refactors. ... Including moving IsFocused back internally for now.	2024-07-18 18:19:13 +02:00
ocornut	a05700e327	MultiSelect: Enter doesn't alter selection (unlike Space). ... Fix for changes done in 5606.	2024-07-18 18:19:13 +02:00