Alexander Alekhin
1f2c83845d
backport: checks and fixes from static code analyzers results
...
original commit: 71f665bd8c
2020-09-02 19:05:47 +00:00
Alexander Alekhin
71f665bd8c
checks and fixes from static code analyzers results
2020-09-02 21:59:34 +03:00
catree
417d7a38de
Add Robot-World/Hand-Eye calibration function.
2020-08-27 07:24:07 +02:00
Alexander Alekhin
ba147d2be2
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-08-26 15:51:25 +00:00
Alexander Alekhin
c7422e4d90
Merge pull request #18171 from catree:fix_pnp_doc
2020-08-25 18:24:30 +00:00
catree
379b83e946
Fix cubic root computation to be able to handle negative values. Improve doc. Add regression test.
2020-08-25 03:37:56 +02:00
catree
dda1bf1887
Add broken implementation note for DLS and UPnP.
...
Add CV_LOG_DEBUG.
2020-08-25 03:07:00 +02:00
Maksym Ivashechkin
c9e1386e44
fix CV_Check warnings
2020-08-17 21:15:19 +02:00
Maksym Ivashechkin
a66f61748f
Merge pull request #17683 from ivashmak:homography
...
[GSoC] New RANSAC. Homography part
* change enum and squash commits
* add small improvements
* change function to static, update magsac
* remove path from samples, remove license, small updates
* update pnp solver, small improvements
* fix warnings
* add tutorial, comments
* fix markdown warnings
* fix markdown warnings
* fix markdown warnings
2020-08-14 22:42:26 +00:00
Alexander Alekhin
fa25faa2d2
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-08-06 14:15:52 +00:00
Pavel Rojtberg
3c3e131c38
Merge pull request #17977 from paroj:hervec
...
* calib3d: calibrateHandEye - allow using Rodrigues vectors for rotation
* calib3d: calibrateHandEye - test rvec representation
2020-07-30 22:59:15 +03:00
Vadim Pisarevsky
a2f7ef9d21
Merge pull request #17816 from vpisarev:essential_2cameras
...
* add findEssentialMat for two different cameras
* added smoke test for the newly added variant of findEssentialMatrix
Co-authored-by: tompollok <tom.pollok@gmail.com>
2020-07-29 16:28:01 +03:00
Christoph
657c8d1c65
Merge pull request #17454 from creinders:master
...
fix instable fisheye undistortPoints
* remove artefacts when (un)distorting fisheye images with large distortion coefficient values
* fix fisheye undistortion when theta is close to zero
* add fisheye image undistort and distort test
* Fixed type conversion warnings
* fixed trailing whitespace
2020-07-03 22:59:19 +00:00
Alexander Alekhin
593af7287b
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-05-18 17:50:16 +00:00
Ganesh Kathiresan
cddd7f10d5
Merge pull request #17224 from ganesh-k13:bugfix/calib3d/17201
...
* Fixed indexing in prefilter
* Initialised prefilter
* Initialised prefilter with value initialisation
* Added TC to trigger different Mem Allocs in BufferBM
* Optimize cases with only needed conditions
2020-05-14 16:30:01 +00:00
GFleishman
31ec9b2aa7
Merge pull request #16614 from GFleishman:estimateTranslation3D
...
added estimateTranslation3D to calib3d/ptsetreg
* added estimateTranslation3D; follows API and implementation structure for estimateAffine3D, but only allows for translation
* void variables in null function to suppress compiler warnings
* added test for estimateTranslation3D
* changed to Matx13d datatype for translation vector in ptsetreg and test; used short license in test
* removed iostream include
* calib3d: code cleanup
2020-04-07 19:58:25 +00:00
Alexander Alekhin
b4b4d21212
eliminate build warnings
2020-03-26 19:18:09 +00:00
Alexander Alekhin
ef395c3866
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-03-24 11:12:11 +00:00
Maksim Shabunin
0aac17d9f7
calib3d: check input values in dls
2020-03-24 12:22:26 +03:00
Alexander Alekhin
0b4c101e8a
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-03-23 16:54:35 +00:00
Maksim Shabunin
2f665ec589
calib3d: fixed VS2019 warning C4756
2020-03-23 14:46:21 +03:00
Alexander Alekhin
ca23c0e630
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-03-17 13:23:33 +03:00
Maksim Shabunin
7e7bb3027c
Fixs several problems found by static analysis
2020-03-16 19:03:24 +03:00
Alexander Duda
d594e72586
fix: estimateChessboardSharpness triggers out of range test
...
Problem is that iter1 += tcols, iter2 += tcols are called without check.
row < trows - 1 check is processed after increment in "for" statements.
2020-03-11 22:04:54 +01:00
Alexander Alekhin
27b71d6368
Merge pull request #16625 from D-Alex:findChessboard
2020-03-09 22:21:29 +00:00
Alexander Duda
44560c3e50
calib3d: add estimateChessboardSharpness
...
Image sharpness, as well as brightness, are a critical parameter for
accuracte camera calibration. For accessing these parameters for
filtering out problematic calibraiton images, this method calculates
edge profiles by traveling from black to white chessboard cell centers.
Based on this, the number of pixels is calculated required to transit
from black to white. This width of the transition area is a good
indication of how sharp the chessboard is imaged and should be below
~3.0 pixels.
Based on this also motion blur can be detectd by comparing sharpness in
vertical and horizontal direction. All unsharp images should be excluded
from calibration as they will corrupt the calibration result. The same
is true for overexposued images due to a none-linear sensor response.
This can be detected by looking at the average cell brightness of the
detected chessboard.
2020-03-09 08:58:18 +01:00
Eduard Trulls
7e637c134f
Expose maxIters in findFundamentalMat
...
Lets the user choose the maximum number of iterations the robust
estimator runs for, similary to findHomography. This can significantly
improve performance (at a computational cost).
2020-03-07 18:03:44 +03:00
Alexander Alekhin
45d073f889
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-02-26 20:09:03 +03:00
Maksim Shabunin
bf96d8239d
Use BufferArea in more places
2020-02-26 11:45:19 +03:00
Alexander Duda
a41cbbdc99
findChessboardCornersSB: performance + support for full FOV boards with markers
...
Changes:
* UMat for blur + rotate resulting in a speedup of around 2X on an i7
* support for boards larger than specified allowing to cover full FOV
* support for markers moving the origin into the center of the board
* increase detection accuracy
The main change is for supporting boards that are larger than the FOV of
the camera and have their origin in the board center. This allows
building OEM calibration targets similar to the one from intel real
sense utilizing corner points as close as possible to the image border.
2020-02-21 14:01:47 +01:00
Alexander Alekhin
96b26dc8f4
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-02-20 19:47:27 +03:00
Karl Liu
331a96c670
transplant 8p's normalization to 7p
...
use const instead of constexpr
2020-02-18 23:39:52 +08:00
Alexander Alekhin
aa2777ed61
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-02-10 19:40:29 +03:00
Maksim Shabunin
55cdeaa6dd
BufferArea: initial version, usage in StereoBM
...
New class BufferArea is used to hide complexity of buffers allocations and allow instrumentation with valgrind and sanitizers.
2020-02-07 14:57:36 +03:00
Alexander Alekhin
225566da7b
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-02-04 19:49:24 +03:00
Alexander Alekhin
0673866ceb
Merge pull request #16502 from tomoaki0705:fixTypo
2020-02-04 12:18:50 +00:00
Tomoaki Teshima
edaf4e0104
apply to correct range (entire 3.0 and 4.0 series)
2020-02-04 18:49:19 +09:00
Alexander Alekhin
560f85f8e5
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2020-01-28 14:26:57 +03:00
Ganesh Kathiresan
504cd8a9f5
Merge pull request #16405 from ganesh-k13:bugfix/solvepnp-crash
...
Added type check for solvePnPGeneric | Issue: #16049
* Added type check
* Added checks before type fix
* Tests for 16049
* calib3d: update solvePnP regression check (16049)
2020-01-23 15:23:03 +03:00
Alexander Alekhin
1996ae4a42
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-12-31 10:11:39 +00:00
Alexander Alekhin
523f081923
core(check): add Size_<int>
2019-12-28 13:50:39 +00:00
Alexander Alekhin
515ec6b98a
Merge pull request #16247 from alalek:backport_16241
2019-12-27 16:20:52 +00:00
Brian Wignall
f9c514b391
Fix spelling typos
...
backport commit 659ffaddb4
2019-12-27 12:46:53 +00:00
catree
badd0d1ff4
Add explicit size check for Rodrigues() function to prevent issue like https://stackoverflow.com/questions/58969553
2019-12-27 06:07:54 +01:00
Brian Wignall
659ffaddb4
Fix spelling typos
2019-12-26 06:45:03 -05:00
Alexander Alekhin
4c86fc13cb
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-12-19 15:09:05 +03:00
Sebastien Wybo
e801f0e954
Merge pull request #16011 from sebastien-wybo:fix_16007
...
* Fix #16007 - colinearity computed using all 3 coordinates
* calib3d(test): estimateAffine3D regression 16007
2019-12-19 12:59:18 +03:00
Alexander Alekhin
13bc55a015
calib3d: clarify error messages in collectCalibrationData()
2019-12-09 18:36:13 +03:00
Alexander Alekhin
8108fb0575
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-12-05 18:27:45 +03:00
Alexander Alekhin
c790779a37
Merge pull request #16024 from alalek:issue_15953
2019-12-05 14:23:48 +00:00
Alexander Alekhin
72f35e0626
Merge pull request #16052 from alalek:issue_16040
...
* calib3d: use normalized input in solvePnPGeneric()
* calib3d: java regression test for solvePnPGeneric
* calib3d: python regression test for solvePnPGeneric
2019-12-05 15:36:39 +03:00
Alexander Alekhin
9a4404276a
calib3d: revert stereoRectify() changes from PRs: 6836, 6972, 6955
...
(1/4) Revert "Correct image borders and principal point computation in cv::stereoRectify"
This reverts commit 93ff1fb2f2
.
(2/4) Revert "fix calib3d changes in 6836 plus some others"
This reverts commit fa42a1cfc2
.
(3/4) Revert "fix compiler warning"
This reverts commit b3d55489d3
.
(4/4) Revert "add test for 6836"
This reverts commit d06b8c4ea9
.
2019-11-30 23:37:49 +00:00
Alexander Alekhin
fc41c18c6f
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-11-18 13:56:24 +03:00
Alexander Alekhin
7ecdcf6ca6
build: GCC9 compilation
2019-11-12 18:49:34 +03:00
Alexander Alekhin
0d7f770996
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-11-04 09:58:29 +00:00
Alexander Alekhin
ee044771a7
Merge pull request #15478 from terfendail:wintr_stereosgbm
2019-10-31 19:24:06 +00:00
Alexander Alekhin
ea5499fa51
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-10-29 20:46:51 +00:00
André Lippok
86a8ff6129
Fixed typo in assertion
2019-10-27 17:43:31 +01:00
Vitaly Tuzov
42b1d04999
StereoSGBM algorithm updated to use wide universal intrinsics
2019-10-25 16:34:16 +03:00
Alexander Alekhin
055ffc0425
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-10-24 18:21:19 +00:00
Vitaly Tuzov
1ce5a724c7
Fixed StereoBM uniqueness check
2019-10-24 17:54:49 +03:00
Alexander Alekhin
507ca291e1
Merge pull request #12670 from alalek:imgproc_getRotationMatrix2D_return_type
2019-09-28 18:03:34 +00:00
Vitaly Tuzov
0a1b957331
StereoBM algorithm updated to use wide universal intrinsics
2019-09-25 14:37:12 +03:00
Alexander Alekhin
a74fe2ec01
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-09-20 21:11:49 +00:00
Daniel Kapusi
d2872afce0
Merge pull request #15341 from DiebBlue:is5769
...
* issue 5769 fixed: cv::stereoRectify fails if given inliers mask of type vector<uchar>
* issue5769 fix using reshape and add regression test
* regression test with outlier detection, testing vector and mat data
* Size comparision of wrong vector within CV_Assert in regression test corrected
* cleanup test code
2019-09-17 00:04:05 +03:00
Matt Bennett
b17d16623a
Prevent empty _Jo matrix multiplication when using calibrateCameraRO with iFixedPoint > 0
2019-09-04 15:33:03 +01:00
luz.paz
fcc7d8dd4e
Fix modules/ typos
...
Found using `codespell -q 3 -S ./3rdparty -L activ,amin,ang,atleast,childs,dof,endwhile,halfs,hist,iff,nd,od,uint`
backporting of commit: ec43292e1e
2019-08-16 17:34:29 +03:00
luz.paz
ec43292e1e
Fix modules/ typos
...
Found using `codespell -q 3 -S ./3rdparty -L activ,amin,ang,atleast,childs,dof,endwhile,halfs,hist,iff,nd,od,uint`
2019-08-15 18:02:09 -04:00
Alexander Alekhin
199ddff13b
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-07-18 20:25:25 +00:00
Alexander Alekhin
43eba3d750
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-07-04 18:44:13 +03:00
Alexander Alekhin
097d81363b
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-07-02 21:17:45 +00:00
armenpoghosov
edf2cbd5f7
Merge pull request #14828 from armenpoghosov:parmen_RANSACPointSetRegistrator_getSubset_disaster_cleanup
...
Parmen ransac point set registrator get subset disaster cleanup (#14828 )
2019-07-01 21:57:28 +03:00
Vitaly Tuzov
9befb7a1d7
Merge pull request #14916 from terfendail:wsignmask_deprecated
...
* Avoid using v_signmask universal intrinsic and mark it as deprecated
* Renamed v_find_negative to v_scan_forward
2019-07-01 19:53:51 +03:00
Alexander Alekhin
f33f88de31
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-06-21 17:27:14 +03:00
Alexander Alekhin
95d9cfb5c3
static analysis issues
2019-06-20 13:55:20 +03:00
Alexander Alekhin
66d7956e67
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-06-15 16:25:11 +00:00
Alexander Alekhin
11b020b9f9
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-06-10 19:05:28 +00:00
Alexander Alekhin
1e9ad5476d
core(intrin): drop hasSIMD128 checks
...
- use compile-time checks instead (`#if CV_SIMD128`)
- runtime checks are useless
2019-06-08 19:20:20 +00:00
Alexander Alekhin
ddcf388270
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-06-07 19:02:55 +03:00
Alexander Alekhin
f3de2b4be7
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-06-05 19:11:52 +03:00
Ahmed Ashour
1aca1d582e
Fix some typos
2019-06-05 12:24:13 +02:00
rasmus25
394bc91e07
Merge pull request #14718 from rasmus25:3.4
...
* Revert the bad parts of b085158d59
to fix https://github.com/opencv/opencv/issues/11131
but preserve the good parts to keep https://github.com/opencv/opencv/issues/10791 fixed
* calib3d: add regression test for stereoCalibrate to fix https://github.com/opencv/opencv/issues/11131
2019-06-04 18:43:42 +03:00
Alexander Alekhin
43467a2ac7
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-05-28 18:29:48 +00:00
Alexander Alekhin
a81c0e6db9
Merge pull request #14447 from catree:fix_issue_14423
2019-05-27 15:00:21 +00:00
Alexander Alekhin
483f28723c
calib3d: initialize local vars, fix indentation in for loops
2019-05-27 14:39:47 +03:00
Alexander Alekhin
166ecaeda8
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-05-23 19:50:20 +03:00
catree
7ed858e38e
Fix issue with solvePnPRansac and Nx3 1-channel input when the number of points is 5. Try to uniform the input shape of projectPoints and undistortPoints.
2019-05-22 14:19:16 +02:00
Alexander Alekhin
a433394870
Merge pull request #14362 from catree:feat_ippe
2019-05-20 18:16:52 +00:00
catree
33cb9c5ca5
Add SOLVEPNP_IPPE for planar pose estimation. Add solvePnPGeneric function that returns all the pose solutions and the reprojection errors.
2019-05-20 11:56:54 +02:00
Alexander Alekhin
e21262deba
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-05-16 04:40:39 +00:00
Alexander Alekhin
8b192b76c0
Merge pull request #14561 from alalek:fix_ctors_with_uninitialized_vars
2019-05-15 16:21:07 +00:00
Daniel Ingram
962d57b4d6
Merge pull request #14559 from daniel-s-ingram:master
...
* Fix typo: 'divisble' -> 'divisible'
* Fix typo: 'One of arguments' -> 'One of the arguments'
2019-05-15 18:41:43 +03:00
Alexander Alekhin
68012bfbf9
calib3d: fix uninitialized fields in ctors
2019-05-14 19:15:13 +00:00
Alexander Alekhin
b2abd8ca41
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-05-07 16:04:54 +00:00
Alexander Alekhin
fc57129300
Merge pull request #14431 from catree:feat_solvePnPRefine
2019-05-02 20:44:58 +00:00
Alexander Alekhin
e28e3c9491
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-05-01 08:27:45 +00:00
catree
dac31e84fb
Add solvePnPRefineLM to refine a pose according to a Levenberg-Marquardt iterative minimization process. Add solvePnPRefineVVS to refine a pose using a virtual visual servoing scheme.
2019-04-30 14:31:11 +02:00
ostarling
643d9df42d
Merge pull request #14411 from ostarling:3.4_fix_for_14242
...
* Fix for Homogenous precision #14242 :
- moved scale computation to an inline function
- use std::numeric_limits<float>::epsilon() instead of != 0.0
* Fix for Homogenous precision #14242 :
- fixed warnings for type conversion
* Fix for Homogenous precision #14242 :
- use float epsilon() for truncation of doubles
2019-04-29 17:12:04 +03:00
Alexander Alekhin
c024edb9a8
Merge remote-tracking branch 'upstream/3.4' into merge-3.4
2019-04-19 15:43:58 +03:00
Alexander Alekhin
78384d8923
build: avoid highgui dependency
2019-04-15 18:59:51 +00:00