Maksim Shabunin
0726c4d4ea
Merge pull request #4190 from sbokov:fixingStereoBMissue
2015-07-15 14:43:09 +00:00
sbokov
e0cea92f6e
Fixing possible invalid memory access in validateDisparity
2015-07-14 18:23:24 +03:00
Pavel Rojtberg
0688bb61ed
simplify 8point algorithm using Matx classes
2015-07-13 16:58:35 +02:00
themightyoarfish
fcc842f08b
Fixed typo in doc for findEssentialMat
2015-07-10 12:45:45 +02:00
Roman Donchenko
2e86d46cf2
CV_ChessboardDetectorTimingTest: don't ignore missing test data
2015-07-09 17:32:08 +03:00
Vadim Pisarevsky
80eec9d531
Merge pull request #4064 from MSOpenTech:test-contrib
2015-07-01 10:47:44 +00:00
Vadim Pisarevsky
0ed0f2953a
Merge pull request #4166 from sbokov:fixingStereoBMissue
2015-07-01 10:27:21 +00:00
sbokov
ff1687d378
Fixing uninitialized memory access problem
2015-06-30 18:16:56 +03:00
Evgeny Agafonchikov
6a6d58d389
Adding test support for WINRT
2015-06-30 15:35:20 +03:00
rajithr
510dec4927
Fixing resource leaks
2015-06-17 11:07:49 +05:30
Alexander Duda
def2256609
cv::stereoRectify: fix segfault in case of empty distCoeffs
...
cvStereoRectify assumes that NULL is provided in case of no distCoeffs
2015-06-12 13:50:43 +02:00
Ignas Daukšas
af62624849
Add cameraMatrix parameter to findEssentialMat and recoverPose
2015-06-03 10:50:33 +03:00
Vadim Pisarevsky
481f786fe7
added simple HAL test; added RHO homography test
2015-05-28 17:05:43 +03:00
Vadim Pisarevsky
dc587992a0
Merge pull request #4053 from vpisarev:calib3d_fixes
2015-05-26 11:23:50 +00:00
Vadim Pisarevsky
bb2e40b999
for some reason Calib3d_Homography.fromImages on ARM gives much smaller number of inliers than on x86/x64. Need to investigate more carefully, but let's decrease the tolerance threshold for now
2015-05-26 12:43:18 +03:00
Vadim Pisarevsky
ca1d8c1737
fixed another compile warning from MSVC
2015-05-26 10:29:13 +03:00
Vadim Pisarevsky
e944533f01
fixed compile warnings; reenabled solvePnPRansac.concurrency test
2015-05-26 00:19:58 +03:00
Vadim Pisarevsky
85149f8686
hack solvePoly to finds roots of polynoms with zero higher-order coefficients. The roots are populated in this case, which is not valid, strictly speaking, but good enough for function like correctMatches. This solves http://code.opencv.org/issues/4330
2015-05-25 23:43:39 +03:00
Vadim Pisarevsky
a12ec66a04
fixed useExtrinsicGuess=true case with single-precision input ( http://code.opencv.org/issues/2734 )
2015-05-25 22:40:10 +03:00
Vadim Pisarevsky
9d90b0549c
fixed bug http://code.opencv.org/issues/3882
2015-05-25 22:03:25 +03:00
Vadim Pisarevsky
3bc5958c58
added tests for http://code.opencv.org/issues/4011 and http://code.opencv.org/issues/3057 ; fixed random subset generation in both methods to increase chance for a good subset
2015-05-25 21:46:05 +03:00
Alexander Smorkalov
a9ae0c8e82
Test fisheye.rectify disabled for Tegra.
2015-05-24 13:31:08 +02:00
Dikay900
7ca0557b40
typos in comments
2015-05-23 17:36:45 +02:00
Aleksandr Petrikov
25b4cface0
add NEON realization for StereoBM(findCorrespondence, prefilterXSobel)
...
Conflicts:
modules/calib3d/src/stereobm.cpp
Add CV_Assert (ndisp % 8 == 0) to NEON version
2015-05-23 17:36:44 +02:00
Vadim Pisarevsky
2466ca02bf
removed cameraMatrix modification in the currently disabled uPnP algorithm for SolvePnP problem ( http://code.opencv.org/issues/3985 )
2015-05-23 14:19:55 +03:00
Vadim Pisarevsky
7fd5b3a0c5
added another triangulation test case from http://code.opencv.org/issues/3461 ; fixed partial derivative on distortion coefficients, as http://code.opencv.org/issues/4101 suggests
2015-05-23 14:15:11 +03:00
Vadim Pisarevsky
90a78585fb
reproduced test case from http://code.opencv.org/issues/4334
2015-05-23 13:16:32 +03:00
Christian Richardt
cbaf0ecaf6
Fixed triangulation bug http://code.opencv.org/issues/4334 .
2015-05-13 16:28:14 +02:00
Christian Richardt
242e64c08d
Fixed triangulation bug http://code.opencv.org/issues/4334 .
2015-05-13 15:47:00 +02:00
Martin Ueding
9e29762838
Add example data types for calibrateCamera call
...
It took me a while to figure out what was meant with
OpenCV Error: Assertion failed (i < 0) in getMat
While searching for this error message I found [a list of error
messages](https://adventuresandwhathaveyou.wordpress.com/2014/03/14/opencv-error-messages-suck/ )
which also explained what the problem was: The data type for `rvecs` was
not a simple `cv::Mat` but a `std::vector<cv::Mat>`.
After I fixed that, I got the next error message:
OpenCV Error: Assertion failed (ni > 0 && ni == ni1) in
collectCalibrationData, file
/build/buildd/opencv-2.4.9+dfsg/modules/calib3d/src/calibration.cpp,
line 3193
The problem here was that my data type for the `objectPoints` was just
`vector<Vec3f>` and not `vector<vector<Vec3f>>`.
In order to save other people the time looking for this, I added
explicit examples of the needed data types into the documentation of the
function. I had to re-read the current version a couple of times until I
can read the needed levels of `vector<>`. Having this example would have
really helped me there.
Conflicts:
modules/calib3d/include/opencv2/calib3d.hpp
2015-04-28 17:24:37 +02:00
Vadim Pisarevsky
e60dcc9b3b
Merge pull request #3966 from Dikay900:master_diff_to_2_4_2
2015-04-28 11:00:57 +00:00
Vadim Pisarevsky
7245803405
Merge pull request #3954 from martin-ueding:master
2015-04-28 10:55:05 +00:00
Maksim Shabunin
1138a38dbe
Use explicit no-sse flags when SSE is off
...
Also:
- Silence clang warnings about unsupported command line arguments
- Add diagnostic print to calib3d test
- Fixed perf test relative error check
- Fix iOS build problem
2015-04-27 15:36:10 +03:00
Mansour Moufid
b99f7a29df
Cast some image coordinates and sizes to double.
...
Conflicts:
modules/gpu/perf/perf_imgproc.cpp
Cast a long integer to double explicitly.
Conflicts:
modules/python/src2/cv2.cpp
Cast some matrix sizes to type int.
Change some vector mask types to unsigned.
Conflicts:
modules/core/src/arithm.cpp
2015-04-25 18:54:53 +02:00
Ilya Lavrenov
89e3c508d8
fixed tests for aarch64
2015-04-24 13:56:20 +03:00
Vadim Pisarevsky
1e90b2f51d
Merge pull request #3957 from dhood:fm-8pt-bug
2015-04-23 17:16:25 +00:00
Deanna Hood
eee210f3b5
Fix Bug #3441 , #4072 , #4173 : 8-point fundamental matrix calculation error
2015-04-23 10:09:48 -04:00
Deanna Hood
34bc3b8595
Don't relax error level for particular fundamental matrix calculation methods
2015-04-23 10:08:42 -04:00
Martin Ueding
5ffb53f229
Add example data types for calibrateCamera call
...
It took me a while to figure out what was meant with
OpenCV Error: Assertion failed (i < 0) in getMat
While searching for this error message I found [a list of error
messages](https://adventuresandwhathaveyou.wordpress.com/2014/03/14/opencv-error-messages-suck/ )
which also explained what the problem was: The data type for `rvecs` was
not a simple `cv::Mat` but a `std::vector<cv::Mat>`.
After I fixed that, I got the next error message:
OpenCV Error: Assertion failed (ni > 0 && ni == ni1) in
collectCalibrationData, file
/build/buildd/opencv-2.4.9+dfsg/modules/calib3d/src/calibration.cpp,
line 3193
The problem here was that my data type for the `objectPoints` was just
`vector<Vec3f>` and not `vector<vector<Vec3f>>`.
In order to save other people the time looking for this, I added
explicit examples of the needed data types into the documentation of the
function. I had to re-read the current version a couple of times until I
can read the needed levels of `vector<>`. Having this example would have
really helped me there.
2015-04-23 13:30:14 +02:00
Vadim Pisarevsky
063e4004ba
Merge pull request #3935 from vpisarev:extending_hal_part1
2015-04-21 14:02:02 +00:00
Vadim Pisarevsky
0f13208d81
Merge pull request #3929 from daeyun:findEssentialMat_doc
2015-04-21 12:20:02 +00:00
Pavel Rojtberg
78eac67a01
clean up cvTriangulatePoints by using C++ primitives directly.
...
- fixes the Calib3d_StereoCalibrate_C testcase.
update comment regarding cv::SVD::MODIFY_A
2015-04-21 11:29:26 +02:00
Vadim Pisarevsky
ee11a2d266
fully implemented SSE and NEON cases of intrin.hpp; extended the HAL with some basic math functions
2015-04-16 23:00:26 +03:00
Daeyun Shin
4686b935c1
Fix typo in documentation. F = K^-T * E * K^-1
2015-04-14 07:44:32 -05:00
Maksim Shabunin
56b02331f7
Commented unused constants in the RHO algorithm
2015-03-27 14:36:27 +03:00
Maksim Shabunin
fab2a947ca
Fix build for VC10
2015-03-27 12:15:26 +03:00
Olexa Bilaniuk
8a1d8c8470
Merge remote-tracking branch 'refs/remotes/upstream/master'
2015-03-18 02:21:36 -04:00
Olexa Bilaniuk
6d27d488bf
Bugfix in n* optimization.
...
Similar to the problem in LevMarq, arg.inl was being used instead of
best.inl. This opened us up to a potential segfault.
2015-03-18 02:21:16 -04:00
Vadim Pisarevsky
b708969326
Merge pull request #3832 from Dmitry-Me:fixNullPointerDereference3
2015-03-17 10:36:52 +00:00
Vadim Pisarevsky
8cf45ce0af
Merge pull request #3828 from vpisarev:fix_win32_perf_calib3d_solvepnp_failure
2015-03-17 10:34:53 +00:00
Dmitry-Me
52a8d37f11
Fix potential null pointer dereference
2015-03-16 18:36:12 +03:00
Vadim Pisarevsky
ca19ae8b5a
in solvePnPRansac call the solvePnP in the end with all the inliers to get more precise estimate
2015-03-16 16:56:26 +03:00
Vadim Pisarevsky
5c352c9146
temporarily use EPNP in SolvePnP instead of UPNP or DLS algorithms, since the latter two are not quite stable
2015-03-16 12:46:24 +03:00
Olexa Bilaniuk
7e3cc44738
More docs on variable accesses.
...
Listed accesses for more functions.
2015-03-14 12:41:25 -04:00
Vadim Pisarevsky
1760078f67
trying to make solvePnPSmallPoints pass
2015-03-13 20:11:33 +03:00
Vadim Pisarevsky
7e07220440
made the solvepnp a bit more modest; test 5-point configuration instead of 4-point in some cases; reduce the noise in 4-point configurations in other cases
2015-03-13 18:04:23 +03:00
Olexa Bilaniuk
9c432f4f75
Silence Windows warnings.
2015-03-06 12:16:38 -05:00
Olexa Bilaniuk
2113636d29
Made seed a constant.
2015-03-06 09:24:45 -05:00
Olexa Bilaniuk
fcdbacdbb0
Corrected initialization of smart pointer.
2015-03-06 09:15:00 -05:00
sanuj
441cd22343
Add documentation for solvePnP in calib3d
2015-03-06 19:18:22 +05:30
Olexa Bilaniuk
52e67c1a29
Whitespace & Doc fixes on lower half of rho.cpp.
...
Spaced methods & functions more consistently, and started documenting
which members does each method access directly or through its callers
within RHO_HEST_REFC.
2015-03-04 05:04:52 -05:00
Olexa Bilaniuk
27fd810b6f
Silenced build warnings on Windows.
2015-03-04 02:09:59 -05:00
Olexa Bilaniuk
736b42b372
Refactorings and renamings.
...
- Deleted "RefC" from names of external-interface functions.
- Renamed rhorefc.[cpp|hpp] to rho.[cpp|hpp]
- Introduced RHO_HEST base class, from which RHO_HEST_REFC inherits.
- rhoInit() currently only returns a Ptr<RHO_HEST_REFC>, but in the
future it will be allowed to return pointers to other derived classes,
depending on the values returned by cv::checkHardwareSupport().
2015-03-04 01:43:13 -05:00
Olexa Bilaniuk
408f93340a
External interface converted to use OpenCV Ptr<> smart pointer.
2015-03-03 23:12:33 -05:00
Olexa Bilaniuk
f592321771
Internal buffers converted to use OpenCV dynamic memory allocation.
2015-03-03 22:57:40 -05:00
Olexa Bilaniuk
bb01231990
Substituted the NaN check with OpenCV's implementation.
2015-03-03 13:06:36 -05:00
Olexa Bilaniuk
16f36a5fda
Replaced division by reciprocal + multiply in a few places.
2015-03-03 11:55:36 -05:00
Olexa Bilaniuk
e1abc416cf
Changed seeding in initialization.
...
The call to rand()/random() is now a call to (unsigned)cv::theRNG().
2015-03-03 11:48:41 -05:00
Olexa Bilaniuk
0f6ea38eac
Added OPENCV_ prefix to #include guard.
2015-03-03 11:42:04 -05:00
Olexa Bilaniuk
a2affe70d9
Deleted last remnants of restrict keyword.
2015-03-03 11:40:44 -05:00
Olexa Bilaniuk
b229d6b7ac
Moved constants to cv:: namespace.
2015-03-03 08:05:52 -05:00
Olexa Bilaniuk
ed2a23768e
Merge remote-tracking branch 'refs/remotes/upstream/master'
2015-03-02 17:55:34 -05:00
Vadim Pisarevsky
7c7a63bebc
Merge pull request #3772 from Dmitry-Me:reduceVariableScope4
2015-03-02 19:52:18 +00:00
Maksim Shabunin
37c74e38f4
Python support
2015-03-02 18:13:00 +03:00
Maksim Shabunin
457123027e
Modified java wrapping mechanism
2015-03-02 18:12:30 +03:00
Dmitry-Me
4e582b131b
Reduce veriables scope, move declaration to first use
2015-03-02 16:27:48 +03:00
Vadim Pisarevsky
e43a14ccd2
Merge pull request #3750 from Dmitry-Me:reduceVariableScope3
2015-03-02 10:55:37 +00:00
Vadim Pisarevsky
0172bd6beb
Merge pull request #3756 from eliteraspberries:cast-double
2015-03-02 10:52:28 +00:00
Vladislav Vinogradov
cda6fed41f
move tegra namespace out of cv to prevent conflicts
2015-02-27 12:52:11 +03:00
Olexa Bilaniuk
5748cea80d
Removed unnecessary precision in damped Cholesky decomposition.
...
Cholesky decomposition is stable; It is not necessary to carry it out
internally at double precision if the result will be truncated to single
precision when stored.
2015-02-26 21:47:29 -05:00
Vladislav Vinogradov
44e41baffe
use new functions before all tegra:: calls
2015-02-26 19:34:58 +03:00
Dmitry-Me
2311504c44
Reduce variables scope
2015-02-25 10:38:44 +03:00
Mansour Moufid
b7be49426d
Cast some image coordinates and sizes to double.
2015-02-24 12:21:34 -05:00
Olexa Bilaniuk
f454929d9c
PRNG changes: xorshift128+ algorithm, and seeding API.
...
- Switched to the extremely fast, while simple and high-quality,
xorshift128+ PRNG algorithm by Sebastiano Vigna in "Further scramblings
of Marsaglia's xorshift generators. CoRR, abs/1402.6246, 2014" (2^128-1
period, passes BigCrush tests). Performance improved by 10% over
random().
- Added an API to allow seeding with a specified seed, rather than using
rand() or random(). This allows deterministic, reproducible results in
tests using our algorithm (although findHomography() does not yet
support passing an entropy source on its own end).
2015-02-21 12:31:55 -05:00
Olexa Bilaniuk
0ea009f611
Merge remote-tracking branch 'refs/remotes/upstream/master'
2015-02-20 08:26:04 -05:00
Olexa Bilaniuk
f148f23382
Merge remote-tracking branch 'refs/remotes/upstream/master'
2015-02-18 21:04:39 -05:00
Vijay Pradeep
49bc100e51
Removing rng_seed arg in order to maintain ABI compatibility. Hardcoding seed
2015-02-17 09:19:36 -08:00
Maksim Shabunin
da383e65e2
Remove deprecated methods from cv::Algorithm
2015-02-16 15:28:54 +03:00
Vadim Pisarevsky
edab3916aa
Merge pull request #3696 from Dmitry-Me:shouldPassByReference
2015-02-16 11:29:22 +00:00
Vladislav Vinogradov
a932d8aba1
use full qualified name for all internal namespaces to prevent ambiguous symbol errors
2015-02-16 11:31:21 +03:00
Olexa Bilaniuk
e5696bc5e6
Whitespace change reverts to minimize delta w.r.t master.
2015-02-13 08:07:15 -05:00
Hamid Bazargani
e22678018b
Fix sacCalcJacobianErrors arguments. (curr.inl replaced with best.inl)
...
Fix the issue given NULL inlMask
2015-02-13 00:30:18 -05:00
Hamid Bazargani
42176f8eb1
Fix sacCalcJacobianErrors arguments. (curr.inl replaced with best.inl)
...
Fix the issue given NULL inlMask
2015-02-13 00:09:37 -05:00
ASUS
9a555063e8
Fix sacCalcJacobianErrors arguments. (curr.inl replaced with best.inl)
...
Fix the issue given NULL inlMask
2015-02-12 23:34:48 -05:00
ASUS
6b04351ce1
Merge branch 'accuracy' of https://github.com/obilaniu/opencv into accuracy
...
Conflicts:
modules/calib3d/src/rhorefc.cpp
2015-02-12 21:27:08 -05:00
ASUS
6dbf13d7b5
saveBestModel() is modified. accuracy test is passed.
2015-02-12 21:22:52 -05:00
Olexa Bilaniuk
ff2509af56
Fixed printouts in testcase to blame the correct method for a failure.
...
Previously, certain test failures by the method RHO would result in an
error blaming RANSAC instead. The fix involves a parameter change to
several functions in test_homography.cpp.
2015-02-12 14:42:37 -05:00
Dmitry-Me
c3f8fc41b7
Parameters should have been passed by reference
2015-02-12 17:32:43 +03:00
Olexa Bilaniuk
ccd33a721e
Fixed build failures related to designSPRTTest().
2015-02-07 01:19:40 -05:00
Olexa Bilaniuk
adac8c04bb
Converted to C++ style, + bugfixes.
...
The code has been refactored in response to feedback on Pull Request
Also, outputZeroH() now also zeroes the inlier set, much like
outputModel().
2015-02-07 00:56:58 -05:00