Прун Виктор
93ff1fb2f2
Correct image borders and principal point computation in cv::stereoRectify
2016-03-28 15:59:18 +03:00
Krishnaraj Bhat
9b8013d193
gcc6: fix misleading indentation warning
...
cosmetic changes to fix this warning.
real bugs not found
2016-03-07 17:06:16 +05:30
Vadim Pisarevsky
7f4a1bcac7
Merge pull request #6160 from paroj:fe_distort
2016-03-02 13:34:32 +00:00
Alexander Alekhin
81f21e6e6c
Merge pull request #6139 from ioxp:master
2016-02-25 11:41:49 +00:00
Pavel Rojtberg
bb605279b6
clarify how to use fisheye::distortPoints
2016-02-24 16:18:13 +01:00
aravind
7ad849718c
Fixed Fisheye Camera model documentation.
2016-02-19 01:17:39 +05:30
Philipp Hasper
3f1eeba39d
findHomography sets output mask to all zeros in case of no inlier
2016-02-18 17:58:28 +01:00
Josep Bosch
5384a2205a
Adapted estimateNewCameraMatrix to make it work with pincushion-like distortion.
2016-02-11 11:27:43 +01:00
Dmitry-Me
bf604f1780
Reduce variables scope
2016-02-01 11:10:13 +03:00
Alexander Alekhin
0655a2dc20
Merge pull request #5963 from KeySecure:master
2016-01-14 12:08:28 +00:00
Alexander Alekhin
cda8e449ec
Merge pull request #5954 from smidm:patch-1
2016-01-14 12:07:37 +00:00
KeySecure
e6ac2ca3c9
make Xcode 7.2 happy.
2016-01-13 20:19:19 +08:00
Matěj Šmíd
3e176bbfa0
fisheye documentation typo
2016-01-12 16:33:34 +01:00
Alexander Karsakov
e784ea7178
Fixed getSubset method to support Nx3 1-channel matrices as input (3xN 1-channel matrices doesn't supported at all).
2016-01-12 13:26:17 +03:00
Alexander Karsakov
0c9c7d5f3b
Added test for checking that solvePnPRansac accepts vector<Point3f> and Nx3 1-channel or 1xN/Nx1 3-channel matrices as input.
2016-01-12 12:13:28 +03:00
Emanuel Jöbstl
4e469f2866
Changed parameter order in documentation
...
Changed parameter order in documentation of findEssentialMat, because threshold and probability were switched.
2016-01-08 14:46:17 +00:00
Kai Hugo Hustoft Endresen
551b5d3e1a
StereoSGBM.cpp - use SSE2 for pass 2 using MODE_HH
...
With a test image set of 2800x1400 bytes on a Intel Core i7 5960X this improves runtime of MODE_HH with about 10%. (this particular replaced code segment is approx 3 times faster than the non-SSE2 variant). I was able to reduce runtime by 130 ms by this simple fix.
The second part of the SSE2 optimized part could probably be optimized further by using shift SSE2 operations, but I imagine this would improve performance 10-20 ms at best.
2016-01-08 00:32:52 +01:00
Pavel Rojtberg
ac481e6174
calib3d: port Rodrigues to cpp primitives
2015-12-24 21:34:34 +01:00
Alexander Alekhin
323e24e3ef
change links from samples/python2 to samples/python
2015-12-18 11:00:30 +03:00
Maksim Shabunin
84f37d352f
HAL moved back to core
2015-12-17 12:33:23 +03:00
Thomas Dunker
6882c10b45
Extension of the camera distortion model for tilted image sensors (Scheimpflug condition) including test
2015-12-14 15:20:34 +01:00
Vadim Pisarevsky
5cdf0e3e89
Merge pull request #5351 from paroj:calibout
2015-12-11 16:21:06 +00:00
Pavel Rojtberg
60c06e551a
calibrateCamera: do not require rvec and tvec to be vector<Mat>
...
if they are not we also do not need to allocate a local copy of the rvec
and tvec
2015-12-11 11:01:57 +01:00
Pavel Rojtberg
205775ed52
calibrateCamera: only allocate and compute rvecs, tvecs when needed
...
also replace C defines with C++ enums
2015-12-11 10:58:26 +01:00
Vadim Pisarevsky
21b415f6be
Merge pull request #5691 from paroj:levmarqLU
2015-12-11 08:39:05 +00:00
Pavel Rojtberg
b5ddaae427
calib3d: add CALIB_USE_LU to use LU decomposition in solver
2015-12-10 23:26:37 +01:00
Pavel Rojtberg
4c251bd260
CvLevMarq: add solve method to interface
2015-12-10 23:02:18 +01:00
Pavel Rojtberg
22b64e2c28
CvLevMarq: remove fixed rows instead of setting them to zero
...
use the same approach like in fisheye calibration: instead of setting
masked out rows to zero, remove them from the equation system.
This way JtJ does not become singular and we can use the much faster LU
decomposition instead of SVD.
This results in a speedup of the Calibrate unit tests of 3x-10x.
2015-12-10 23:02:18 +01:00
Pavel Rojtberg
9d89c369f8
update SOLVEPNP documentation
2015-12-10 23:02:17 +01:00
Vadim Pisarevsky
6ead99985f
Merge pull request #4086 from IgnasD:cameraMat_five-point
2015-12-10 09:37:43 +00:00
Vadim Pisarevsky
3c8bd19e56
Merge pull request #5309 from paroj:sampsonDist
2015-12-10 07:08:18 +00:00
Vadim Pisarevsky
5d6292fc97
Merge pull request #5675 from paroj:fisheyecalib
2015-12-10 07:07:12 +00:00
emiswelt
2e9ef3f9e3
Changed parameter order of cv::stereoRectify in documentation,
...
so it matches the code.
2015-12-08 22:28:32 +00:00
Alexander Alekhin
d86d8ed909
Merge 2.4 into master
...
PR #2968 : cce2d99
8578f9c
Fixed bug which caused crash of GPU version of feature matcher in stitcher
The bug caused crash of GPU version of feature matcher in stitcher when
we use ORB features.
PR #3236 : 5947519
Check sure that we're not already below required leaf false alarm rate before continuing to get negative samples.
PR #3190
fix blobdetector
PR #3562 (part): 82bd82e
TBB updated to 4.3u2. Fix for aarch64 support.
PR #3604 (part): 091c7a3
OpenGL interop sample reworked not ot use cvconfig.h
PR #3792 : afdf319
Add -L for CUDA libs path to pkg-config
Add all dirs from CUDA_LIBS_PATH as -L linker options to
OPENCV_LINKER_LIBS. These will end up in opencv.pc.
PR #3893 : 122b9f8
Turn ocv_convert_to_lib_name into a function
PR #5490 : ec5244a
fixed memory leak in findHomography tests
PR #5491 : 0d5b739
delete video readers
PR #5574
PR #5202
2015-12-08 10:24:54 +03:00
Pavel Rojtberg
16fcd78f03
add sampson distance error measure
...
the first order approximation of the geometric error
2015-11-25 16:39:49 +01:00
Vadim Pisarevsky
152874eaed
Merge pull request #5620 from paroj:calibratecpp
2015-11-23 18:35:25 +00:00
Pavel Rojtberg
cefa1dc5cb
switch mask type from vector<int> to vector<uchar>
2015-11-21 00:45:45 +01:00
Rok Mandeljc
980d84e4a2
calib3d: improve documentation of reprojectImageTo3D
...
Make a note about 16-bit signed format - the function assumes that
values have no fractional bits (so 16-bit disparity from StereoBM
and StereoSGBM cannot be directly used!)
2015-11-19 11:05:13 +01:00
Maksim Shabunin
eebd4cad66
Fix compilation problems with XCode 7.1.1 and cmake 3.3.2
2015-11-17 18:52:55 +03:00
Pavel Rojtberg
81e814d9ed
clean up fisheye calibration code
...
improves performance by factor 1.2 to 2.0
2015-11-16 02:24:53 +01:00
Pavel Rojtberg
9233472bdd
use cpp functions in CvLevMarq::step for better readability
2015-11-12 00:20:13 +01:00
Vadim Pisarevsky
3942b1f362
Merge pull request #5340 from alalek:ocl_off
2015-11-10 16:53:36 +00:00
Pavel Rojtberg
742fb559f7
use cpp functions in cvCalibrateCamera2 to make it more readable
2015-11-08 19:25:38 +01:00
Vadim Pisarevsky
33dc41056f
Merge pull request #5392 from elenash:fisheye_fix
2015-11-03 10:57:36 +00:00
Vadim Pisarevsky
8512ca7490
Merge pull request #5484 from PolarNick239:master
2015-11-02 15:45:59 +00:00
Maksim Shabunin
f49936a849
Fixed cmake and build issues when using Visual Studio 2015
2015-10-29 11:50:48 +03:00
Maksim Shabunin
6e9d0d9a0c
Visual Studio 2015 warning and test fixes
2015-10-20 12:48:37 +03:00
Suleyman TURKMEN
73240b736b
Update camera_calibration_and_3d_reconstruction.rst
2015-10-16 22:30:00 +03:00
Ilya Lavrenov
ec5244a73a
fixed memory leak in findHomography tests
2015-10-12 00:11:45 +03:00
Nickolay Polyarniy
846e6f731a
stereoRectifyUncalibrated: assertion of input points shape fixed
...
Fix for https://github.com/Itseez/opencv/issues/4426
Documentation says that input points format is the same to input for findFundamentalMat
2015-10-10 14:00:31 +03:00
Elena Shipunova
e539a9632d
Fix in fisheye calibrate function: #5389
2015-10-01 19:03:26 +03:00
Pavel Vlasov
e837d69f8f
IPPInitSingelton was added to contain IPP related global variables;
...
OPENCV_IPP env var now allows to select IPP architecture level for IPP9+;
IPP initialization logic was unified across modules;
2015-10-01 09:58:48 +03:00
Pavel Vlasov
14b006e808
IPP_VERSION_X100 was changed to:
...
IPP_VERSION_MAJOR * 100 + IPP_VERSION_MINOR*10 + IPP_VERSION_UPDATE
to manage changes between updates more easily.
IPP_DISABLE_BLOCK was added to ease tracking of disabled IPP functions;
2015-09-25 17:50:15 +03:00
Pavel Vlasov
2177c7c5a8
Some IPP functions were encapsulated;
...
Minor changes to IPP implementations;
2015-09-25 17:30:26 +03:00
robertxwu
db78de9c3b
findChessboardCorners causes crash due to out-of-bounds memory corruption.
...
Refer to the following issue for detail:
https://github.com/Itseez/opencv/issues/5145
2015-09-24 12:59:00 +03:00
robertxwu
4a68cc1675
re-submit
2015-09-21 13:57:25 -07:00
Pavel Rojtberg
f0282337e3
simplify error conditions
...
`A || !A` is `true` so write `(A && B) || !A` as `B || !A`
2015-09-18 12:12:49 +02:00
Alexander Alekhin
7213e5f68a
ocl: correct disabling of OpenCL code
2015-09-13 20:28:23 +03:00
Elad Joseph
7c16ad3f49
Update documentation in calib3d.hpp
...
Fixed small mistake in documentation.
The prism coefficients in y'' equation were mistakenly written as s1,s2 instead of s3,s4
2015-08-30 12:42:30 +03:00
sbokov
1ef8cf5a23
Replacing SSE with v_extract
2015-07-27 19:49:25 +03:00
Maksim Shabunin
ecd3661119
Merge pull request #4179 from sbokov:improvingStereoSGBM
2015-07-24 21:12:56 +00:00
sbokov
f40b580bb8
Fixing StereoSGBM ROI
...
Now StereoSGBM behaves similarly to StereoBM in terms of ROI handling.
2015-07-23 23:17:16 +03:00
sbokov
aea4157340
Adding new HAL-accelerated MODE_SGBM_3WAY
...
New mode is approximately 2-3 times faster than MODE_SGBM
with minimal degradation in quality and uses universal
HAL intrinsics. A performance test was added. The accuracy
test was updated to support the new mode.
2015-07-23 23:08:26 +03:00
Vadim Pisarevsky
6d3bc7c82d
Merge pull request #4183 from paroj:8point
2015-07-22 11:01:23 +00:00
Vadim Pisarevsky
c976c1192d
Merge pull request #4181 from themightyoarfish:findEssMatDocTypoFix
2015-07-21 12:06:45 +00:00
Vadim Pisarevsky
61c0ff007a
Merge pull request #4197 from themightyoarfish:projectPointsDocBugfix
2015-07-21 11:56:46 +00:00
Alexander Alekhin
bbe75fe1d2
calib3d: normalize Rodrigues vector in perf test
2015-07-20 17:05:25 +03:00
themightyoarfish
b8f93e08e9
Fixed documentation bug for projectPoints: Distortion coefficients cannot actually be NULL
2015-07-17 17:34:33 +02:00
Maksim Shabunin
0726c4d4ea
Merge pull request #4190 from sbokov:fixingStereoBMissue
2015-07-15 14:43:09 +00:00
sbokov
e0cea92f6e
Fixing possible invalid memory access in validateDisparity
2015-07-14 18:23:24 +03:00
Pavel Rojtberg
0688bb61ed
simplify 8point algorithm using Matx classes
2015-07-13 16:58:35 +02:00
themightyoarfish
fcc842f08b
Fixed typo in doc for findEssentialMat
2015-07-10 12:45:45 +02:00
Roman Donchenko
2e86d46cf2
CV_ChessboardDetectorTimingTest: don't ignore missing test data
2015-07-09 17:32:08 +03:00
Vadim Pisarevsky
80eec9d531
Merge pull request #4064 from MSOpenTech:test-contrib
2015-07-01 10:47:44 +00:00
Vadim Pisarevsky
0ed0f2953a
Merge pull request #4166 from sbokov:fixingStereoBMissue
2015-07-01 10:27:21 +00:00
sbokov
ff1687d378
Fixing uninitialized memory access problem
2015-06-30 18:16:56 +03:00
Evgeny Agafonchikov
6a6d58d389
Adding test support for WINRT
2015-06-30 15:35:20 +03:00
rajithr
510dec4927
Fixing resource leaks
2015-06-17 11:07:49 +05:30
Alexander Duda
def2256609
cv::stereoRectify: fix segfault in case of empty distCoeffs
...
cvStereoRectify assumes that NULL is provided in case of no distCoeffs
2015-06-12 13:50:43 +02:00
Ignas Daukšas
af62624849
Add cameraMatrix parameter to findEssentialMat and recoverPose
2015-06-03 10:50:33 +03:00
Vadim Pisarevsky
481f786fe7
added simple HAL test; added RHO homography test
2015-05-28 17:05:43 +03:00
Vadim Pisarevsky
dc587992a0
Merge pull request #4053 from vpisarev:calib3d_fixes
2015-05-26 11:23:50 +00:00
Vadim Pisarevsky
bb2e40b999
for some reason Calib3d_Homography.fromImages on ARM gives much smaller number of inliers than on x86/x64. Need to investigate more carefully, but let's decrease the tolerance threshold for now
2015-05-26 12:43:18 +03:00
Vadim Pisarevsky
ca1d8c1737
fixed another compile warning from MSVC
2015-05-26 10:29:13 +03:00
Vadim Pisarevsky
e944533f01
fixed compile warnings; reenabled solvePnPRansac.concurrency test
2015-05-26 00:19:58 +03:00
Vadim Pisarevsky
85149f8686
hack solvePoly to finds roots of polynoms with zero higher-order coefficients. The roots are populated in this case, which is not valid, strictly speaking, but good enough for function like correctMatches. This solves http://code.opencv.org/issues/4330
2015-05-25 23:43:39 +03:00
Vadim Pisarevsky
a12ec66a04
fixed useExtrinsicGuess=true case with single-precision input ( http://code.opencv.org/issues/2734 )
2015-05-25 22:40:10 +03:00
Vadim Pisarevsky
9d90b0549c
fixed bug http://code.opencv.org/issues/3882
2015-05-25 22:03:25 +03:00
Vadim Pisarevsky
3bc5958c58
added tests for http://code.opencv.org/issues/4011 and http://code.opencv.org/issues/3057 ; fixed random subset generation in both methods to increase chance for a good subset
2015-05-25 21:46:05 +03:00
Alexander Smorkalov
a9ae0c8e82
Test fisheye.rectify disabled for Tegra.
2015-05-24 13:31:08 +02:00
Dikay900
7ca0557b40
typos in comments
2015-05-23 17:36:45 +02:00
Aleksandr Petrikov
25b4cface0
add NEON realization for StereoBM(findCorrespondence, prefilterXSobel)
...
Conflicts:
modules/calib3d/src/stereobm.cpp
Add CV_Assert (ndisp % 8 == 0) to NEON version
2015-05-23 17:36:44 +02:00
Vadim Pisarevsky
2466ca02bf
removed cameraMatrix modification in the currently disabled uPnP algorithm for SolvePnP problem ( http://code.opencv.org/issues/3985 )
2015-05-23 14:19:55 +03:00
Vadim Pisarevsky
7fd5b3a0c5
added another triangulation test case from http://code.opencv.org/issues/3461 ; fixed partial derivative on distortion coefficients, as http://code.opencv.org/issues/4101 suggests
2015-05-23 14:15:11 +03:00
Vadim Pisarevsky
90a78585fb
reproduced test case from http://code.opencv.org/issues/4334
2015-05-23 13:16:32 +03:00
Christian Richardt
cbaf0ecaf6
Fixed triangulation bug http://code.opencv.org/issues/4334 .
2015-05-13 16:28:14 +02:00
Christian Richardt
242e64c08d
Fixed triangulation bug http://code.opencv.org/issues/4334 .
2015-05-13 15:47:00 +02:00
Martin Ueding
9e29762838
Add example data types for calibrateCamera call
...
It took me a while to figure out what was meant with
OpenCV Error: Assertion failed (i < 0) in getMat
While searching for this error message I found [a list of error
messages](https://adventuresandwhathaveyou.wordpress.com/2014/03/14/opencv-error-messages-suck/ )
which also explained what the problem was: The data type for `rvecs` was
not a simple `cv::Mat` but a `std::vector<cv::Mat>`.
After I fixed that, I got the next error message:
OpenCV Error: Assertion failed (ni > 0 && ni == ni1) in
collectCalibrationData, file
/build/buildd/opencv-2.4.9+dfsg/modules/calib3d/src/calibration.cpp,
line 3193
The problem here was that my data type for the `objectPoints` was just
`vector<Vec3f>` and not `vector<vector<Vec3f>>`.
In order to save other people the time looking for this, I added
explicit examples of the needed data types into the documentation of the
function. I had to re-read the current version a couple of times until I
can read the needed levels of `vector<>`. Having this example would have
really helped me there.
Conflicts:
modules/calib3d/include/opencv2/calib3d.hpp
2015-04-28 17:24:37 +02:00
Vadim Pisarevsky
e60dcc9b3b
Merge pull request #3966 from Dikay900:master_diff_to_2_4_2
2015-04-28 11:00:57 +00:00
Vadim Pisarevsky
7245803405
Merge pull request #3954 from martin-ueding:master
2015-04-28 10:55:05 +00:00
Maksim Shabunin
1138a38dbe
Use explicit no-sse flags when SSE is off
...
Also:
- Silence clang warnings about unsupported command line arguments
- Add diagnostic print to calib3d test
- Fixed perf test relative error check
- Fix iOS build problem
2015-04-27 15:36:10 +03:00
Mansour Moufid
b99f7a29df
Cast some image coordinates and sizes to double.
...
Conflicts:
modules/gpu/perf/perf_imgproc.cpp
Cast a long integer to double explicitly.
Conflicts:
modules/python/src2/cv2.cpp
Cast some matrix sizes to type int.
Change some vector mask types to unsigned.
Conflicts:
modules/core/src/arithm.cpp
2015-04-25 18:54:53 +02:00
Ilya Lavrenov
89e3c508d8
fixed tests for aarch64
2015-04-24 13:56:20 +03:00
Vadim Pisarevsky
1e90b2f51d
Merge pull request #3957 from dhood:fm-8pt-bug
2015-04-23 17:16:25 +00:00
Deanna Hood
eee210f3b5
Fix Bug #3441 , #4072 , #4173 : 8-point fundamental matrix calculation error
2015-04-23 10:09:48 -04:00
Deanna Hood
34bc3b8595
Don't relax error level for particular fundamental matrix calculation methods
2015-04-23 10:08:42 -04:00
Martin Ueding
5ffb53f229
Add example data types for calibrateCamera call
...
It took me a while to figure out what was meant with
OpenCV Error: Assertion failed (i < 0) in getMat
While searching for this error message I found [a list of error
messages](https://adventuresandwhathaveyou.wordpress.com/2014/03/14/opencv-error-messages-suck/ )
which also explained what the problem was: The data type for `rvecs` was
not a simple `cv::Mat` but a `std::vector<cv::Mat>`.
After I fixed that, I got the next error message:
OpenCV Error: Assertion failed (ni > 0 && ni == ni1) in
collectCalibrationData, file
/build/buildd/opencv-2.4.9+dfsg/modules/calib3d/src/calibration.cpp,
line 3193
The problem here was that my data type for the `objectPoints` was just
`vector<Vec3f>` and not `vector<vector<Vec3f>>`.
In order to save other people the time looking for this, I added
explicit examples of the needed data types into the documentation of the
function. I had to re-read the current version a couple of times until I
can read the needed levels of `vector<>`. Having this example would have
really helped me there.
2015-04-23 13:30:14 +02:00
Vadim Pisarevsky
063e4004ba
Merge pull request #3935 from vpisarev:extending_hal_part1
2015-04-21 14:02:02 +00:00
Vadim Pisarevsky
0f13208d81
Merge pull request #3929 from daeyun:findEssentialMat_doc
2015-04-21 12:20:02 +00:00
Pavel Rojtberg
78eac67a01
clean up cvTriangulatePoints by using C++ primitives directly.
...
- fixes the Calib3d_StereoCalibrate_C testcase.
update comment regarding cv::SVD::MODIFY_A
2015-04-21 11:29:26 +02:00
Vadim Pisarevsky
ee11a2d266
fully implemented SSE and NEON cases of intrin.hpp; extended the HAL with some basic math functions
2015-04-16 23:00:26 +03:00
Daeyun Shin
4686b935c1
Fix typo in documentation. F = K^-T * E * K^-1
2015-04-14 07:44:32 -05:00
Maksim Shabunin
56b02331f7
Commented unused constants in the RHO algorithm
2015-03-27 14:36:27 +03:00
Maksim Shabunin
fab2a947ca
Fix build for VC10
2015-03-27 12:15:26 +03:00
Olexa Bilaniuk
8a1d8c8470
Merge remote-tracking branch 'refs/remotes/upstream/master'
2015-03-18 02:21:36 -04:00
Olexa Bilaniuk
6d27d488bf
Bugfix in n* optimization.
...
Similar to the problem in LevMarq, arg.inl was being used instead of
best.inl. This opened us up to a potential segfault.
2015-03-18 02:21:16 -04:00
Vadim Pisarevsky
b708969326
Merge pull request #3832 from Dmitry-Me:fixNullPointerDereference3
2015-03-17 10:36:52 +00:00
Vadim Pisarevsky
8cf45ce0af
Merge pull request #3828 from vpisarev:fix_win32_perf_calib3d_solvepnp_failure
2015-03-17 10:34:53 +00:00
Dmitry-Me
52a8d37f11
Fix potential null pointer dereference
2015-03-16 18:36:12 +03:00
Vadim Pisarevsky
ca19ae8b5a
in solvePnPRansac call the solvePnP in the end with all the inliers to get more precise estimate
2015-03-16 16:56:26 +03:00
Vadim Pisarevsky
5c352c9146
temporarily use EPNP in SolvePnP instead of UPNP or DLS algorithms, since the latter two are not quite stable
2015-03-16 12:46:24 +03:00
Olexa Bilaniuk
7e3cc44738
More docs on variable accesses.
...
Listed accesses for more functions.
2015-03-14 12:41:25 -04:00
Vadim Pisarevsky
1760078f67
trying to make solvePnPSmallPoints pass
2015-03-13 20:11:33 +03:00
Vadim Pisarevsky
7e07220440
made the solvepnp a bit more modest; test 5-point configuration instead of 4-point in some cases; reduce the noise in 4-point configurations in other cases
2015-03-13 18:04:23 +03:00
Olexa Bilaniuk
9c432f4f75
Silence Windows warnings.
2015-03-06 12:16:38 -05:00
Olexa Bilaniuk
2113636d29
Made seed a constant.
2015-03-06 09:24:45 -05:00
Olexa Bilaniuk
fcdbacdbb0
Corrected initialization of smart pointer.
2015-03-06 09:15:00 -05:00
sanuj
441cd22343
Add documentation for solvePnP in calib3d
2015-03-06 19:18:22 +05:30
Olexa Bilaniuk
52e67c1a29
Whitespace & Doc fixes on lower half of rho.cpp.
...
Spaced methods & functions more consistently, and started documenting
which members does each method access directly or through its callers
within RHO_HEST_REFC.
2015-03-04 05:04:52 -05:00
Olexa Bilaniuk
27fd810b6f
Silenced build warnings on Windows.
2015-03-04 02:09:59 -05:00
Olexa Bilaniuk
736b42b372
Refactorings and renamings.
...
- Deleted "RefC" from names of external-interface functions.
- Renamed rhorefc.[cpp|hpp] to rho.[cpp|hpp]
- Introduced RHO_HEST base class, from which RHO_HEST_REFC inherits.
- rhoInit() currently only returns a Ptr<RHO_HEST_REFC>, but in the
future it will be allowed to return pointers to other derived classes,
depending on the values returned by cv::checkHardwareSupport().
2015-03-04 01:43:13 -05:00
Olexa Bilaniuk
408f93340a
External interface converted to use OpenCV Ptr<> smart pointer.
2015-03-03 23:12:33 -05:00
Olexa Bilaniuk
f592321771
Internal buffers converted to use OpenCV dynamic memory allocation.
2015-03-03 22:57:40 -05:00
Olexa Bilaniuk
bb01231990
Substituted the NaN check with OpenCV's implementation.
2015-03-03 13:06:36 -05:00
Olexa Bilaniuk
16f36a5fda
Replaced division by reciprocal + multiply in a few places.
2015-03-03 11:55:36 -05:00
Olexa Bilaniuk
e1abc416cf
Changed seeding in initialization.
...
The call to rand()/random() is now a call to (unsigned)cv::theRNG().
2015-03-03 11:48:41 -05:00
Olexa Bilaniuk
0f6ea38eac
Added OPENCV_ prefix to #include guard.
2015-03-03 11:42:04 -05:00
Olexa Bilaniuk
a2affe70d9
Deleted last remnants of restrict keyword.
2015-03-03 11:40:44 -05:00
Olexa Bilaniuk
b229d6b7ac
Moved constants to cv:: namespace.
2015-03-03 08:05:52 -05:00
Olexa Bilaniuk
ed2a23768e
Merge remote-tracking branch 'refs/remotes/upstream/master'
2015-03-02 17:55:34 -05:00
Vadim Pisarevsky
7c7a63bebc
Merge pull request #3772 from Dmitry-Me:reduceVariableScope4
2015-03-02 19:52:18 +00:00
Maksim Shabunin
37c74e38f4
Python support
2015-03-02 18:13:00 +03:00
Maksim Shabunin
457123027e
Modified java wrapping mechanism
2015-03-02 18:12:30 +03:00
Dmitry-Me
4e582b131b
Reduce veriables scope, move declaration to first use
2015-03-02 16:27:48 +03:00
Vadim Pisarevsky
e43a14ccd2
Merge pull request #3750 from Dmitry-Me:reduceVariableScope3
2015-03-02 10:55:37 +00:00
Vadim Pisarevsky
0172bd6beb
Merge pull request #3756 from eliteraspberries:cast-double
2015-03-02 10:52:28 +00:00
Vladislav Vinogradov
cda6fed41f
move tegra namespace out of cv to prevent conflicts
2015-02-27 12:52:11 +03:00
Olexa Bilaniuk
5748cea80d
Removed unnecessary precision in damped Cholesky decomposition.
...
Cholesky decomposition is stable; It is not necessary to carry it out
internally at double precision if the result will be truncated to single
precision when stored.
2015-02-26 21:47:29 -05:00
Vladislav Vinogradov
44e41baffe
use new functions before all tegra:: calls
2015-02-26 19:34:58 +03:00
Dmitry-Me
2311504c44
Reduce variables scope
2015-02-25 10:38:44 +03:00
Mansour Moufid
b7be49426d
Cast some image coordinates and sizes to double.
2015-02-24 12:21:34 -05:00
Olexa Bilaniuk
f454929d9c
PRNG changes: xorshift128+ algorithm, and seeding API.
...
- Switched to the extremely fast, while simple and high-quality,
xorshift128+ PRNG algorithm by Sebastiano Vigna in "Further scramblings
of Marsaglia's xorshift generators. CoRR, abs/1402.6246, 2014" (2^128-1
period, passes BigCrush tests). Performance improved by 10% over
random().
- Added an API to allow seeding with a specified seed, rather than using
rand() or random(). This allows deterministic, reproducible results in
tests using our algorithm (although findHomography() does not yet
support passing an entropy source on its own end).
2015-02-21 12:31:55 -05:00
Olexa Bilaniuk
0ea009f611
Merge remote-tracking branch 'refs/remotes/upstream/master'
2015-02-20 08:26:04 -05:00
Olexa Bilaniuk
f148f23382
Merge remote-tracking branch 'refs/remotes/upstream/master'
2015-02-18 21:04:39 -05:00
Vijay Pradeep
49bc100e51
Removing rng_seed arg in order to maintain ABI compatibility. Hardcoding seed
2015-02-17 09:19:36 -08:00
Maksim Shabunin
da383e65e2
Remove deprecated methods from cv::Algorithm
2015-02-16 15:28:54 +03:00
Vadim Pisarevsky
edab3916aa
Merge pull request #3696 from Dmitry-Me:shouldPassByReference
2015-02-16 11:29:22 +00:00
Vladislav Vinogradov
a932d8aba1
use full qualified name for all internal namespaces to prevent ambiguous symbol errors
2015-02-16 11:31:21 +03:00
Olexa Bilaniuk
e5696bc5e6
Whitespace change reverts to minimize delta w.r.t master.
2015-02-13 08:07:15 -05:00
Hamid Bazargani
e22678018b
Fix sacCalcJacobianErrors arguments. (curr.inl replaced with best.inl)
...
Fix the issue given NULL inlMask
2015-02-13 00:30:18 -05:00
Hamid Bazargani
42176f8eb1
Fix sacCalcJacobianErrors arguments. (curr.inl replaced with best.inl)
...
Fix the issue given NULL inlMask
2015-02-13 00:09:37 -05:00
ASUS
9a555063e8
Fix sacCalcJacobianErrors arguments. (curr.inl replaced with best.inl)
...
Fix the issue given NULL inlMask
2015-02-12 23:34:48 -05:00
ASUS
6b04351ce1
Merge branch 'accuracy' of https://github.com/obilaniu/opencv into accuracy
...
Conflicts:
modules/calib3d/src/rhorefc.cpp
2015-02-12 21:27:08 -05:00
ASUS
6dbf13d7b5
saveBestModel() is modified. accuracy test is passed.
2015-02-12 21:22:52 -05:00
Olexa Bilaniuk
ff2509af56
Fixed printouts in testcase to blame the correct method for a failure.
...
Previously, certain test failures by the method RHO would result in an
error blaming RANSAC instead. The fix involves a parameter change to
several functions in test_homography.cpp.
2015-02-12 14:42:37 -05:00
Dmitry-Me
c3f8fc41b7
Parameters should have been passed by reference
2015-02-12 17:32:43 +03:00
Olexa Bilaniuk
ccd33a721e
Fixed build failures related to designSPRTTest().
2015-02-07 01:19:40 -05:00
Olexa Bilaniuk
adac8c04bb
Converted to C++ style, + bugfixes.
...
The code has been refactored in response to feedback on Pull Request
Also, outputZeroH() now also zeroes the inlier set, much like
outputModel().
2015-02-07 00:56:58 -05:00
Olexa Bilaniuk
87c2b8197a
Bug fixes in mask output.
...
Previously, the output mask of inliers could remain completely
uninitialized. This fix is the first part of a solution.
2015-02-05 02:18:41 -05:00
Olexa Bilaniuk
b90800f0c7
Corrected typo in comment.
...
The inverted JtJ does not multiply itself, but rather Jte. Correct this
in the comment.
2015-02-04 12:12:14 -05:00
Olexa Bilaniuk
2609e77af7
Silence spurious loss-of-data warnings from Windows.
...
Added explicit casts to silence warnings in fundam.cpp and rhorefc.cpp.
2015-02-04 02:26:01 -05:00
Olexa Bilaniuk
ce0570b777
Splitting vectorized code into separate branch.
...
Deleted SSE code from master branch.
Slight cleanups in fundam.cpp were made as a consequence.
2015-02-03 23:33:52 -05:00
Olexa Bilaniuk
69b146412a
Edited Doxygen documentation in the module calib3d.
...
Added a mention within calib3d.hpp that the flag RHO is available as an
option on calls to findHomography().
2015-02-03 22:55:40 -05:00
Olexa Bilaniuk
8907e6feac
Merge remote-tracking branch 'refs/remotes/upstream/master' into rho
2015-02-03 22:50:45 -05:00
Vadim Pisarevsky
bd4580a242
Merge pull request #3589 from JBosch:master
2015-01-21 10:46:53 +00:00
Olexa Bilaniuk
045f8294bb
Merge remote-tracking branch 'refs/remotes/upstream/master' into rho
2015-01-20 13:11:09 -05:00
Olexa Bilaniuk
02124f19e6
Further LevMarq improvements.
...
Implemented a damping-parameter choice strategy similar to that
described in http://www2.imm.dtu.dk/documents/ftp/tr99/tr05_99.pdf .
Removed a few debug statements.
Chosen a new starting lambda value, 0.01.
We now actually output the mask of inliers.
2015-01-15 04:21:16 -05:00
Olexa Bilaniuk
ff91af825d
LevMarq made semi-functional.
...
Replaced the complex rules OpenCV uses to select lambda with a naive but
fast heuristic. It's imperfect but produces good results. It is still
subject to the same problem as OpenCV - namely, on occasion LevMarq will
make a poor result even worse.
2015-01-14 04:22:48 -05:00
Vijay Pradeep
1292fdf71a
Now using default arg instead of overloads
2015-01-13 11:25:01 -08:00
Olexa Bilaniuk
4401095b38
Optimizations to Jacobian and error calculations.
...
Deleted multiplications by zero and consequent additions of zero terms.
2015-01-12 11:33:05 -05:00
Olexa Bilaniuk
7fca146b21
More LevMarq bugfixes.
...
LevMarq now doesn't outright fail, but doesn't seem to improve things
much if at all.
2015-01-12 05:37:40 -05:00
Olexa Bilaniuk
33a3fba2d1
Work on LevMarq code.
...
Refactoring of Cholesky decomposition.
Fix for memory corruption bug.
LevMarq as a whole still non-functional.
2015-01-12 04:58:07 -05:00
Olexa Bilaniuk
c175a86cbb
Merge remote-tracking branch 'upstream/master' into rho
2015-01-12 02:11:14 -05:00
Timur Sattarov
4762728fd5
More sensible error messages
2015-01-11 03:56:07 +04:00
Vijay Pradeep
964d5a20e9
Whitespace fix
2015-01-09 10:44:19 -08:00
Vijay Pradeep
177478a8ad
overload instead of default arg for ABI backwards compatibility. rng_seed is now 'int' to support python port
2015-01-09 10:18:08 -08:00
Josep Bosch
75c99d65a5
Fisheye calibration methods available now in python
2015-01-09 10:05:36 +01:00
Vijay Pradeep
a1c5740044
solvePnPRansac now accepts a seed and is deterministic
2015-01-08 18:24:55 -08:00
Vijay Pradeep
042ff210d5
Fixing race condition by expanding resultsMutex lock section
2015-01-08 15:26:15 -08:00
Vadim Pisarevsky
1c8493fb0d
Merge pull request #3549 from mshabunin:sphinx-doc-remove
2014-12-31 09:14:22 +00:00
Olexa Bilaniuk
46631c4b18
Merge remote-tracking branch 'upstream/master' into rho
2014-12-29 20:55:24 -05:00
Julien Nabet
2d5e3b57ea
Fix cppcheck reports warnings:
...
(performance) Possible inefficient checking for 'lmap' emptiness
(warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
(style) Array index '<xxx>' is used before limits check
2014-12-27 10:54:34 +01:00
Maksim Shabunin
d01bedbc61
Removed Sphinx documentation files
2014-12-26 19:12:19 +03:00
Maksim Shabunin
c485aee464
Included c-headers for better 2.4 compatibility
2014-12-19 17:05:26 +03:00
Maksim Shabunin
91e21847e2
Some changes to make migration to 3.0 easier
2014-12-16 13:00:31 +03:00
Olexa Bilaniuk
bcc630a8dc
Merge remote-tracking branch 'upstream/master' into rho
2014-12-15 12:31:22 -05:00
Dmitry-Me
f269828160
Reduce variables scope, move declaration to first use point
2014-12-08 18:21:17 +03:00
Olexa Bilaniuk
51963f95dd
Merge remote-tracking branch 'upstream/master' into rho
2014-12-05 15:56:33 -05:00
Dmitry-Me
cb049657e5
Prevent division by zero
2014-12-02 14:44:09 +03:00
Maksim Shabunin
03e213ccae
Doxygen documentation: BiB references and fixes
2014-12-01 15:50:55 +03:00